Just did a quick check, and it seems like the only one that behaves a little bit differently as a top-level rollup or an individual subcrate run is "Should have multiple tests which pass." , which will give you credit if you have total_tests > 1 drawing from all your workspace crates in the roll-up scenario,
but naturally only gives credit if total_tests > 1 drawing from the particular subcrate if you run in the context of just that subcrate
Which may be fine, or may be a point for refinement.
i feel "multiple tests which pass" could be misleading
Could you elaborate a little bit on the problematic aspect?
(I concur there's plenty of room to improve wording, just trying to understand which ways matter most)
so you check if there is more than 1 test that passes?
uhmm okay i got it now. you just want to check if the person has written tests, not whether the build is failing or quality of tests (which are of course difficult to gauge)
Quality of tests would be a big project unto itself, one I'm okay with leaving out for now.
The current check does actually confirm whether or not the test build is failing.
yah i agree.
@ZackPierce It might be nice to require certain compiler lints enabled.
And for tests, you could integrate with coverage and use the % coverage.
@waywardmonkeys Yep, I definitely see how it would be straightforward to do a number of integrations with extant tooling for deeper checks
e.g. actually running rustfmt to see if anything would have changed
e.g. using tarpaulin or coverage or mutagen or mull to examine test quality
I think the tough part of the cargo-culture project is striking the right balance between rules that are available versus those that are default
and having a great pattern for tailoring to organizational needs
@KodrAus I don’t think there needs to be a lotof coordination … but it would be helped by having better tools from crates.io for analyzing what things are using outdated versions … or which transitively depend on multiple versions of things.
@KodrAus But when compiler updates happen that result in new warnings for rustdoc … or a widely used crate gets an update … then having a list of things / crates would be useful.
@KodrAus Or things like right now, you can’t compile serde docs with a nightly compiler.
@waywardmonkeys Yeh, I was wondering if something like a GitHub repository with issues, maybe containing a checklist of relevant libraries, might be visible enough for folks to get involved?
@KodrAus thanks for submitting some issues on cargo-culture!
mdbook 0.1.8 shipped today. I am prepared to release the cookbook!
I'm sure I've used some incorrect terms in the RFC and would love others to review it before I took the next step to submit it.
Hi, just wanted to announce that there will be FOSDEM devroom dedicated to dependency management/ecosystem next year; if you are working on any cool tool or have interesting best practices to share, feel free to submit a proposal here: https://t.co/oz2ap3vGsN?amp=1