Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Brian Egan
@brianegan
Hrm, tried a few things, but I wonder if there's a bug with travis or some config there?
I pushed up a 1 word change to the Readme as a test from the last passing master branch, and even that failed :(
Frank Pepermans
@frankpepermans
Honestly I've no idea :) haven't had a chance to look yet either
Brian Egan
@brianegan
Haha, no worries
Think it's just driving my developer brain crazy haha
Why can I no fix!?
Frank Pepermans
@frankpepermans
Haha I know the feeling
Frank Pepermans
@frankpepermans
@brianegan merged all PRs except the timeout one, it has some conflicts
and why is this chat suddenly empty? :D
Frank Pepermans
@frankpepermans
build seems to be fixed, did you change anything?
Brian Egan
@brianegan
@frankpepermans Hey, cool! Nope, I tried a couple o' reruns and I guess it started magically working this morning :)
Not cool, Travis haha
Quickly resolved the conflicts on that last PR as well, so hopefully no errors and we can do a merge on that one as well :)
Frank Pepermans
@frankpepermans
done!
now where's them peeps form rx.io :D
Hans Van den Keybus
@dotdotcommadot
Yeah, I know. We should look for another way to get in touch I think...
Brian Egan
@brianegan
We should perhaps invite them from that Twitter thread into the Github thread?
That way we could all chat there?
A bit easier than 140 chars :)
Frank Pepermans
@frankpepermans
yeah maybe, or via mail if they prefer that
Hans Van den Keybus
@dotdotcommadot
I’ve posed the question on the RxJS gitter… hopefully someone of the team will pick it up :)
Frank Pepermans
@frankpepermans
FYI I've added @brianegan and @dotdotcommadot as pub uploaders https://pub.dartlang.org/packages/rxdart
Hans Van den Keybus
@dotdotcommadot
Kewl, thanks! :)
Brian Egan
@brianegan
Oh cool :)
Brian Egan
@brianegan
Oh snap, looks like it's moving over!
Frank Pepermans
@frankpepermans
Yep :) seems the repo is good enough as is to transfer, great work!
Brian Egan
@brianegan
:fire: :sparkles: :clap: :ship:
Hans Van den Keybus
@dotdotcommadot
The dragDrop example was acting weird.
I’ve cleaned it up and created a pull request.
I’ve removed the controller.close() method, since I don’t think any of these controllers should be closed (since you want to be able to drag/drop after you did this a first time)
I’d say; have a look and correct me if I’m wrong :)
Frank Pepermans
@frankpepermans
@brianegan just added the using operator, I dunno how this acts in Java, but I disallow asBroadcastStream here, since the dispose needs to be called when the subscription terminates.
However if it is a hot observable, canceling all subscriptions still never triggers the onCancel, so the dispose can never take place
Hans Van den Keybus
@dotdotcommadot

Observable has a method asyncMap, which looks like this:

  @override
  Observable<S> asyncMap<S>(dynamic convert(T value)) =>
      new Observable<S>(stream.asyncMap(convert));

Shouldn’t that be

  @override
  Observable<S> asyncMap<S>(dynamic convert(T value)) =>
      new Observable<S>(super.asyncMap(convert));

(=> replaced stream with super)

Ah I see, I guess I’m wrong
Brian Egan
@brianegan
Yah, Observable is really a simple wrapper class around a given Stream
Hans Van den Keybus
@dotdotcommadot
Indeed, thx
Brian Egan
@brianegan
@frankpepermans Sounds good! I'll take a look this evening. tbh, I haven't tried out the using operator :) I'll take a look at the Java version this evening to see what it's up to
Frank Pepermans
@frankpepermans
thx! yeah haven't used it either myself
some source code I check on using closes the controller after adding the first event, that's an opion here too, except that when you then dispose, you cannot call addError since the controller is... closed :/
Brian Egan
@brianegan
Ah, yah :(
Hans Van den Keybus
@dotdotcommadot
https://github.com/ReactiveX/rxdart
WHOOP WHOOP
Frank Pepermans
@frankpepermans
📣🎺🎸🎷
Brian Egan
@brianegan
"The Reactive Extensions for Dart"
:) :) :)
Hans Van den Keybus
@dotdotcommadot
Well done both of you!! (and the other guys how contributed parts to this repo as well of course)
The lib is starting to look very good I think!
Frank Pepermans
@frankpepermans
true! and thanks :)
PS I've opened the ReactiveX/rxdart gitter channel
Hans Van den Keybus
@dotdotcommadot
I’ve been watching too much Fargo, so I’m off to bed, but I’ll implement the changes on the PR’s tomorrow.
But we should definitely discuss the ‘naming convention’ on streams and streamControllers I think
Frank Pepermans
@frankpepermans
this can go soon
Hans Van den Keybus
@dotdotcommadot
Ow yeah, wait, I’ll move over :)
Razvan Lung
@long1eu
hi!
what is the equivalent of next() in rxdart?