Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 15 15:55
    Queenscripts starred salesforce/design-system-react
  • Jun 15 07:45

    dependabot[bot] on npm_and_yarn

    (compare)

  • Jun 15 07:45
    dependabot[bot] closed #2889
  • Jun 15 07:44
    dependabot[bot] commented #2889
  • Jun 15 07:44
    dependabot[bot] assigned #2899
  • Jun 15 07:44
    dependabot[bot] review_requested #2899
  • Jun 15 07:44
    dependabot[bot] labeled #2899
  • Jun 15 07:44
    dependabot[bot] opened #2899
  • Jun 15 07:44

    dependabot[bot] on npm_and_yarn

    Bump karma from 5.2.3 to 6.3.4 … (compare)

  • Jun 14 16:50

    interactivellama on master

    Update README.md (compare)

  • Jun 14 16:46
    interactivellama labeled #2744
  • Jun 14 16:39
    interactivellama commented #2836
  • Jun 14 16:37
    interactivellama labeled #2836
  • Jun 14 16:36
    interactivellama edited #2836
  • Jun 14 16:33
    interactivellama closed #2644
  • Jun 14 16:33
    interactivellama commented #2644
  • Jun 14 16:31
    interactivellama closed #2780
  • Jun 14 16:31
    interactivellama commented #2780
  • Jun 14 16:29
    interactivellama labeled #2780
Pulkit Gupta
@pulkonet
Hi, @interactivellama I was thinking to fix the above mentioned issues in TrialBar and ProgressBar
In TrialBar it is a string left in trial
Kevin Parkerson
@kevinparkerson
@pulkonet he has a PR out fixing all the issues already, so no need. Thanks for being proactive though!
Pulkit Gupta
@pulkonet
Oh, so he is fixing all the issues?
Kevin Parkerson
@kevinparkerson
Yup :) I’m reviewing the PR now actually
Stephen James
@interactivellama
Yeah, most where just / or * or such
There were only a few issues with words.
Pulkit Gupta
@pulkonet
OK, I saw the PR but didn't realise that you would be fixing all of those
But don't we need to add a proper label prop for these?
Like here: In TrialBar it is a string left in trial
Pulkit Gupta
@pulkonet
That's a lot of work :p I could have fixed in the components I worked on atleast
Thanks anyway
Stephen James
@interactivellama
I went ahead and added it, so the CI would pass. It was not a lot of time. We missed it in the code reviews. I appreciate you taking ownership.
Kevin Parkerson
@kevinparkerson
no worries! we missed that stuff in the initial reviews so our fault
haha what he said :laughing:
Pulkit Gupta
@pulkonet

I was going through the ProgressBar code, and I found this

getDescription({ labels }) {
        if (this.props.labels.label) {
            return (
                <div
                    className="slds-grid slds-grid_align-spread slds-p-bottom_x-small"
                    id="progress-bar-label-id-4"
                >
                    <span>{labels.label}</span>
                    <span aria-hidden="true">
                        <strong>
                            {this.props.value}% {labels.complete}
                        </strong>
                    </span>
                </div>
            );
        }
        return '';
    }

being called

const labels = assign({}, defaultProps.labels, this.props.labels);
        const style = assign({}, defaultProps.style, this.props.style);
        return (
            <div id={this.getId()} style={style}>
                {this.props.orientation === 'horizontal' &&
                    this.getDescription({ labels })}
like this
Stephen James
@interactivellama
Is that id hard coded?
Pulkit Gupta
@pulkonet
Yes,
Stephen James
@interactivellama
I’d love for you to fix that.
Where there any other issues you saw?
Pulkit Gupta
@pulkonet
Yes
labels is assigned as retrieved from defaultProps and props
Stephen James
@interactivellama
it’s an object merge.
Pulkit Gupta
@pulkonet
but in getDescription this.props.labels.label is null checked, instead of labels.label
It shouldn't create much of an issue, but is it deliberately done, if so I would like to know why
Stephen James
@interactivellama
got it. Cool. Yep that’s a bug. I appreciate your attention to that detail.
Pulkit Gupta
@pulkonet
OK, I would raise a PR fixing both of those.
Stephen James
@interactivellama
That would be great!
Kevin Parkerson
@kevinparkerson
good catches @pulkonet!
Pulkit Gupta
@pulkonet
:)
Stephen James
@interactivellama
Storybook upgrade PR was merged today. salesforce/design-system-react#2192
Please use the Accessibility tab to fix markup issues. Screen Shot
All new component stories should have accessibility markup testing added to them in the CI. Please pull down master branch for open PRs when you have a chance and npm install
Ashwin Shenoy
@aswinshenoy
Yes, :) Storybook 5 looks so improved both ui and functionality wise.
Stephen James
@interactivellama
@aswinshenoy @kevinparkerson I will review the TreeGrid today. @kevinparkerson has requested me to review it a few times, and I have not followed through, so that’s on me.
Ashwin Shenoy
@aswinshenoy
cool, thank you so much.
Ashwin Shenoy
@aswinshenoy
While, I got a little stuck at doing the "boring" tests, I thought of taking a break, and worked on Map component (a easy-to-implement high priority component :D ) and I have submitted a PR - #2230. I think this one is simple enough to be included within GSoC goals, as we aren't sure about completing Chat/Activity Timeline as I proposed as goals. :)
Stephen James
@interactivellama
Sounds good. Feel free to subsitute. Please update the Google doc if that’s what you are planning on doing.
Ashwin Shenoy
@aswinshenoy
Yeah sure, this one seemed quite interesting for me and could do it a hours time :D I thought if "big" components aren't gonna be feasible now, I will do a few "small" ones :)
Stephen James
@interactivellama
I’m going to discontinue the book discussion on Senior Software Engineer, but if you do have questions about anything specific, please ask. I highly recommend: Chapters 6, 9 and 11. They are non-coding chapters about conmmunicaiton with others: Interacting with non-technical co-workers, writing emails, documentation, etc. response to times to certain types of messages.
Kshitiz Kumar
@kshitijk83
hello coders, kshitiz here, want to contribute in this project, can anyone tell me from where should I start? techs: MERN stack ,javascript(advanced)
Stephen James
@interactivellama
Welcome @kshitijk83 I’d recommend reviewing the backlog. This is the current sprint https://github.com/salesforce/design-system-react/projects/37
Please propose something from the milestones or current sprint.
Stephen James
@interactivellama
@kshitijk83 This would be a good one to pick up. salesforce/design-system-react#2385
Kshitiz Kumar
@kshitijk83
sorry for the late replies but i got myself busy into exams, can you suggest me other issue to start with? it would be a great help
as it this issue is closed now