Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 06 11:40

    raboof on main

    Added support for different git… Merge pull request #197 from li… (compare)

  • Apr 06 11:40
    raboof closed #197
  • Apr 06 11:40
    raboof closed #196
  • Apr 06 11:38
    raboof commented #197
  • Apr 06 10:20
    liorregev commented #197
  • Apr 06 10:20
    lightbend-cla-validator commented #197
  • Apr 06 10:20
    liorregev synchronize #197
  • Apr 06 09:52
    lightbend-cla-validator commented #197
  • Apr 06 09:52
    liorregev synchronize #197
  • Apr 06 08:41

    raboof on main

    Fix console reader issues (#219… (compare)

  • Apr 06 08:41
    raboof closed #219
  • Apr 05 19:10
    djspiewak synchronize #219
  • Apr 05 18:53
    lightbend-cla-validator commented #219
  • Apr 05 18:53
    djspiewak opened #219
  • Mar 29 14:52
    SethTisue commented #215
  • Mar 29 14:52
    armanbilge commented #215
  • Mar 29 14:51
    SethTisue closed #215
  • Mar 29 14:51
    SethTisue commented #215
  • Mar 29 14:48

    SethTisue on v2.0.0

    (compare)

  • Mar 29 14:36
    SethTisue closed #216
Leonard Ehrenfried
@leonardehrenfried
i'm having a horrible time trying to get sbt-git to build on travis at the moment.
Boris Chazalet
@bchazalet
because of java 8?
Leonard Ehrenfried
@leonardehrenfried
no, downloads from repo.typesafe.com time out or they simply throw an error.
Boris Chazalet
@bchazalet
that may be related to the previous error you were having on travis then?
Leonard Ehrenfried
@leonardehrenfried
yes, they are all pretty much the same error. can't download from repo.typesafe.com
Leonard Ehrenfried
@leonardehrenfried
things like this take a long time:
wget https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/compile/0.13.16-M1/jars/compile.jar
Boris Chazalet
@bchazalet
that's very strange
takes a second on my machine
Leonard Ehrenfried
@leonardehrenfried
sometimes it's quite fast, sometimes it takes 30s. very weird.
at least i have build now that has downloaded sbt but it's craaawling: https://travis-ci.org/sbt/sbt-git/builds/233559905
resolving and downloading artifacts for 22 minutes now.
Boris Chazalet
@bchazalet
wow
Leonard Ehrenfried
@leonardehrenfried
i've added caching of the ivy cache to the travis build in order for the cache to work the build has to pass at least one.
Boris Chazalet
@bchazalet
do you believe that's a temporary glitch from travis?
otherwise i would suggest using coursier here
Leonard Ehrenfried
@leonardehrenfried
i don't really know. at least the latest build has now finished successfully and a cache was build.
Boris Chazalet
@bchazalet
:+1:
I think we should probably release one more version with your PR merged for java 7
and then upgrade to java 8
so that java 7 users can benefit from your PR too
Leonard Ehrenfried
@leonardehrenfried
good idea but how many scala users are still using java 7? it has not received updates for 2 years.
Boris Chazalet
@bchazalet
more than you'd think! :)
anyway it doesn't cost us much to do it that way
Leonard Ehrenfried
@leonardehrenfried
sure
we don't really need any of the newer features of jgit.
java.time.OffsetDateTime would be nice but oh well.
@bchazalet do you have the credentials to cut a release?
Boris Chazalet
@bchazalet
I don't. @hseeberger and @dwijnand do. I approved the PR, hopefully @hseeberger can do the rest? :)
Leonard Ehrenfried
@leonardehrenfried
alright, does it help if i request their review on the pull request?
Boris Chazalet
@bchazalet
it can't hurt!
Leonard Ehrenfried
@leonardehrenfried
i don't appear to be able to. oh well.
Boris Chazalet
@bchazalet
I asked for @hseeberger's one. He's usually quite reactive.
Heiko Seeberger
@hseeberger
hseeberger is on vacation!
Leonard Ehrenfried
@leonardehrenfried
@dwijnand since Heiko is on vacation would you be able to release?
Boris Chazalet
@bchazalet
ahah enjoy @hseeberger !
Dale Wijnand
@dwijnand
@leonardehrenfried I'll give it a shot in the morning (UK time)
Leonard Ehrenfried
@leonardehrenfried
@dwijnand Sorry to be a pest, but did you manage to release sbt-git? Our CI builds are craaawling and to large parts because if the large dependency tree of the current version.
Dale Wijnand
@dwijnand
Aaahh! Sorry I forgot.
Dale Wijnand
@dwijnand
Leonard Ehrenfried
@leonardehrenfried
you're a gentleman and a scholar. thanks!
@dwijnand would you welcome a pr that automates the release with sbt-release?
Dale Wijnand
@dwijnand
Absolutely.
For the record, the process is currently: bump the version in the README (edit and commit), git tag the repo, load (or reload) the build in sbt, run publish.
Leonard Ehrenfried
@leonardehrenfried
Okay, I will automate this and send a pr.
Dale Wijnand
@dwijnand
thank you
Boris Chazalet
@bchazalet
what about credentials? what kind of credentials does it take to be able to publish?
Dale Wijnand
@dwijnand
I'm not sure, I've never collaborated on publishing an sbt plugin before.
Maybe Heiko knows.
Leonard Ehrenfried
@leonardehrenfried
I don't know either but I guess you use your personal credentials which gives you access to the repository.
Leonard Ehrenfried
@leonardehrenfried
@dwijnand automatically setting the version in the readme during release is possible with a hacky parse-and-replace step. do you prefer that or would you be okay with a badge that shows the current version like i did here: https://github.com/leonardehrenfried/play-json-traits/