Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 06 11:40

    raboof on main

    Added support for different git… Merge pull request #197 from li… (compare)

  • Apr 06 11:40
    raboof closed #197
  • Apr 06 11:40
    raboof closed #196
  • Apr 06 11:38
    raboof commented #197
  • Apr 06 10:20
    liorregev commented #197
  • Apr 06 10:20
    lightbend-cla-validator commented #197
  • Apr 06 10:20
    liorregev synchronize #197
  • Apr 06 09:52
    lightbend-cla-validator commented #197
  • Apr 06 09:52
    liorregev synchronize #197
  • Apr 06 08:41

    raboof on main

    Fix console reader issues (#219… (compare)

  • Apr 06 08:41
    raboof closed #219
  • Apr 05 19:10
    djspiewak synchronize #219
  • Apr 05 18:53
    lightbend-cla-validator commented #219
  • Apr 05 18:53
    djspiewak opened #219
  • Mar 29 14:52
    SethTisue commented #215
  • Mar 29 14:52
    armanbilge commented #215
  • Mar 29 14:51
    SethTisue closed #215
  • Mar 29 14:51
    SethTisue commented #215
  • Mar 29 14:48

    SethTisue on v2.0.0

    (compare)

  • Mar 29 14:36
    SethTisue closed #216
Boris Chazalet
@bchazalet
I don't. @hseeberger and @dwijnand do. I approved the PR, hopefully @hseeberger can do the rest? :)
Leonard Ehrenfried
@leonardehrenfried
alright, does it help if i request their review on the pull request?
Boris Chazalet
@bchazalet
it can't hurt!
Leonard Ehrenfried
@leonardehrenfried
i don't appear to be able to. oh well.
Boris Chazalet
@bchazalet
I asked for @hseeberger's one. He's usually quite reactive.
Heiko Seeberger
@hseeberger
hseeberger is on vacation!
Leonard Ehrenfried
@leonardehrenfried
@dwijnand since Heiko is on vacation would you be able to release?
Boris Chazalet
@bchazalet
ahah enjoy @hseeberger !
Dale Wijnand
@dwijnand
@leonardehrenfried I'll give it a shot in the morning (UK time)
Leonard Ehrenfried
@leonardehrenfried
@dwijnand Sorry to be a pest, but did you manage to release sbt-git? Our CI builds are craaawling and to large parts because if the large dependency tree of the current version.
Dale Wijnand
@dwijnand
Aaahh! Sorry I forgot.
Dale Wijnand
@dwijnand
Leonard Ehrenfried
@leonardehrenfried
you're a gentleman and a scholar. thanks!
@dwijnand would you welcome a pr that automates the release with sbt-release?
Dale Wijnand
@dwijnand
Absolutely.
For the record, the process is currently: bump the version in the README (edit and commit), git tag the repo, load (or reload) the build in sbt, run publish.
Leonard Ehrenfried
@leonardehrenfried
Okay, I will automate this and send a pr.
Dale Wijnand
@dwijnand
thank you
Boris Chazalet
@bchazalet
what about credentials? what kind of credentials does it take to be able to publish?
Dale Wijnand
@dwijnand
I'm not sure, I've never collaborated on publishing an sbt plugin before.
Maybe Heiko knows.
Leonard Ehrenfried
@leonardehrenfried
I don't know either but I guess you use your personal credentials which gives you access to the repository.
Leonard Ehrenfried
@leonardehrenfried
@dwijnand automatically setting the version in the readme during release is possible with a hacky parse-and-replace step. do you prefer that or would you be okay with a badge that shows the current version like i did here: https://github.com/leonardehrenfried/play-json-traits/
Dale Wijnand
@dwijnand
While I like the badge, being able to copy and paste is very convenient (as well as common).
Dale Wijnand
@dwijnand
I was going to suggest adding a little comment to that part of the readme to avoid regressions in the feature (like coursier does https://github.com/coursier/coursier/blob/7b1bbae2085bbcc075c803ce3aaf15c6b9bd80f4/project/plugins.sbt#L23) but it turns out that comments in markdown aren't supported, and the workarounds involve abusing the link syntax: http://stackoverflow.com/questions/4823468/comments-in-markdown -.-
Leonard Ehrenfried
@leonardehrenfried
Would anyone be able to review this: sbt/sbt-git#130
Brian P. Holt
@bpholt
It seems that the recommendation for suppressing DEBUG messages from jgit is to import the no-op slf4j jar, but we have internal sbt plugins that import an actual logging backend, so that’s not an option for us. Is there another way to change the slf4j loglevel to suppress those messages?
Brian P. Holt
@bpholt
FWIW, I was able to add a logback.xml config file (since we’re using logback as the slf4j backend) to another sbt plugin and use it to configure the logging from sbt-git. For some reason adding logback.xml to the sbt meta-build of the project including sbt-git didn’t work (I suspect because of a classloader conflict), but for my purposes adding the file to the plugin actually works better anyway, so that’s fine.
Dale Wijnand
@dwijnand
You should see if adding a logback.xml to project/src/main/resources gets loaded for the build and affects sbt-git's (jgit's) logging.
Brian P. Holt
@bpholt
@dwijnand Thanks. I tried that, but it didn’t load it. I can’t find the specific code now, but I was able to define a task in a build.sbt that could use the classloader to load from project/src/main/resources, but the classloader used by the logger factory inside jgit did not have any classes or resources defined in project. It did have the jars of all the sbt plugins, though, which is why adding the file as a resource to a plugin worked.
Dale Wijnand
@dwijnand
Yeah I eventually saw your message elsewhere. Looks like we'd need to tweak sbt to support that.
Brian P. Holt
@bpholt
FWIW, I created sbt/sbt#3498 in case there’s interest in making that change to sbt
Dale Wijnand
@dwijnand
Nice one, thanks.
drocsid
@drocsid
I don't use Windows, but where is the git.sbt file supposed to reside, in /project or / ?
drocsid
@drocsid
looks like in /
Dale Wijnand
@dwijnand
project
drocsid
@drocsid
Hmm think I got an error when I put it in project
or I should say /project
Dale Wijnand
@dwijnand
well what error?
drocsid
@drocsid
but it doesn't say that in the docs
Dale Wijnand
@dwijnand
do you mean where to put useJGit?
yeah that doesn't go in project
drocsid
@drocsid
git.sbt contains useJGit
I put it in /
seems to work but I haven't tested it
Really just using this plugin to see if I can collect the branch names from it. Can I collect the branch names from it?
in a variable or val to work with publish?
drocsid
@drocsid
```
git status Error: Could not find or load main class org.eclipse.jgit.pgm.Main [error] Nonzero exit code (1) running JGit.
I'm going to assume that I need to add JGit as a dependency. Not sure why that's not in the docs