Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Nicolas Rinaudo
    @nrinaudo

    I'm having a frustrating time adding sbt-header as a dependency of an autoplugin I'm writing. I feel like I've set everything up right:

    • my autoplugin's build.sbt declares addSbtPlugin("de.heikoseeberger" % "sbt-header" % "1.6.0").
    • it declares its requirement as it should: override def requires = HeaderPlugin

    But whenever a project actually uses it (by declaring it as a plugin in build/plugins.sbt), sbt fails to load with a messy stack trace that boils down to java.lang.ClassNotFoundException: de.heikoseeberger.sbtheader.HeaderPlugin$

    Help would be appreciated, although I do realise this might very well not be related to sbt-header
    Heiko Seeberger
    @hseeberger
    @nrinaudo, could you please minimize the problem and provide the code with an issue?
    Nicolas Rinaudo
    @nrinaudo
    @hseeberger yeah, I did that yesterday evening. As is often the case, that sorted the problem out: it was, somehow, an SBT or ivy caching problem. Clearing all caches fixed my issue.
    It also might be worth pointing out that, before fixing it, I managed to reproduce it with other autoplugins, not just sbt-header.
    Heiko Seeberger
    @hseeberger
    Glad to hear ;-)
    Jean-Rémi Desjardins
    @jedesah
    @hseeberger Would it be possible to get a new release? Really looking forward to that new exclude functionality! :-)
    Tim Gifford
    @timgifford
    I have a different folder structure for integration tests (src/it/scala) and would like to createHeaders for that folder. Any suggestions? My sbt foo is weak!
    Heiko Seeberger
    @hseeberger
    Published sbt-header 3.0.0 for sbt 1.0.0.
    Nicolas Rinaudo
    @nrinaudo
    @hseeberger am I right to understand that, as far as sbt-header is concerned, sbt 0.13.x is EOL?
    or are there any plan to cross build to 0.13 and 1.0.0 for a while?
    Heiko Seeberger
    @hseeberger
    Just use 2.0.0
    for sbt 0.13
    It's feature equal to 3.0.0.
    Nicolas Rinaudo
    @nrinaudo
    I understand that, and that's what I might end up doing, but I have an autoplugin that I need to support both 0.13 and 1.0.0, at least for a while. And I currently cannot because sbt-header and tut do not cross-compile
    that sounded like an accusation, sorry. It's a perfectly legitimate decision to make, I just wanted to make sure it was by design and not an oversight
    Heiko Seeberger
    @hseeberger
    Got it. Please PR cross building.
    Nicolas Rinaudo
    @nrinaudo
    will do, thanks!
    A. Alonso Dominguez
    @alonsodomin
    there is already a PR for cross building sbt-header: sbt/sbt-header#120
    also notice that there is a bug in sbt 0.13.16 & 1.0.0 regarding SBT cross-builds of plugins that depend on other plugins: sbt/sbt#3393
    Nicolas Rinaudo
    @nrinaudo
    Interesting. I'm running in exactly the same problem
    I mean the one described in your PR,not the one yu linked to
    A. Alonso Dominguez
    @alonsodomin
    mmm, that’s defo interesting… I assumed it was something regarding my local environment when I saw that Travis did not have that problem...
    Nicolas Rinaudo
    @nrinaudo
    Is it possible that the modules (not plugins) aren't published locally for 1.0.0?
    Thibaut Robert
    @trobert
    hi
    is there a public repo somewhere with the last snapshot version ?
    I am migrating from 1.0 to 3.0 and I just found out that I need #140
    Heiko Seeberger
    @hseeberger
    No snapshots. We'll release soon.
    Thibaut Robert
    @trobert
    okay, I'll wait then, thanks
    Heiko Seeberger
    @hseeberger
    Released 4.0.0.
    Thibaut Robert
    @trobert
    nice! that was quick ;)
    Nicolas Rinaudo
    @nrinaudo
    I'm running in an issue that looks like a regression from 3.0.x: it seems that headerCheck does not behave the way it used it, and ignores headerCreate::unmanagedSources

    Looking at the diff:

    I might be missing something, but this kind of looks like a bug to me - why does headerCheck have its own unmanagedSources, different from (and not even a superset of) these of headerCreate? I would expect both tasks to work on exactly the same files

    Jonas Fonseca
    @jonas
    @hseeberger Any plans for a release with the recent change that provides access to the existing header when calling CommentCreator.apply? That would be very useful for Akka HTTP.
    Heiko Seeberger
    @hseeberger
    @jonas just released 4.1.0. Have fun.
    Jonas Fonseca
    @jonas
    Thanks!
    Nicolas Rinaudo
    @nrinaudo
    @hseeberger regarding sbt/sbt-header#149, if you confirm that it's a regression and not intended, I can probably provide a PR relatively quickly if you're interested
    Nicolas Rinaudo
    @nrinaudo
    @hseeberger is there any chance this could make it into a 4.1.1 any time soon? The reason I spotted that is because it caused some of own tests to fail, and I'd really like to re-enable them :)
    if not no worries, of course, your project, your release schedule
    Heiko Seeberger
    @hseeberger
    Will do. Glad you like it!
    Nicolas Rinaudo
    @nrinaudo
    thanks, appreciate it!
    Nicolas Rinaudo
    @nrinaudo
    @hseeberger sorry to be a pain about this, but are you going to release a version with that headerCheck fix soon? “No” is a perfectly good answer, I’d just like to know if I should wait for it before releasing a new version of my plugin that depends on it, or if I should just stay on 3.0.0 for the moment
    Nicolas Rinaudo
    @nrinaudo
    @hseeberger thanks, didn't even realise you'd released "silently"!
    This has led me to find a bug in the documentation. The way source lookup works has changed and Integration with other plugins is no longer working, at least for sbt-boilerplate - you're not supposed to use unmanagedSources, but to work directly with headerSources
    happy to submit a PR for the sbt-boilerplate part, but I wouldn't know how to check / fix the sbt-twirl part
    Heiko Seeberger
    @hseeberger
    Sounds good, PR please.
    Paul Cleary
    @pauljamescleary
    quick question, I am using lazy val IntegrationTest extends Test for my integration tests. I have enablePlugins(AutomateHeaderPlugin as well as .settings(automateHeaderSettings(IntegrationTest, MultiJvm)). When I to sbt compile or sbt test:compile all file headers are generated. However, it:compile does not generate the file headers.
    doh, nevermind. Gotta add headerSettings(IntegrationTest)
    sbt/sbt-header#124
    Gergő Törcsvári
    @tg44
    Hy! Is there an easy way to add for example javascript files to this tool?
    (It's working great for our scala files, but we have some javascript in our play app too.)
    Gergő Törcsvári
    @tg44
    (for future reference, you need to create a project with your js dir, make it as a resource dir, and from that you can use this as a readme describes with adding filetypes, and filter out files)