by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jul 02 00:04

    cquiroz on master

    Update sbt-scalajs, scalajs-com… Merge pull request #199 from sc… (compare)

  • Jul 02 00:04
    cquiroz closed #199
  • Jul 01 22:56
    scala-steward opened #199
  • Jun 27 23:43

    cquiroz on master

    Update sbt to 1.3.13 Merge pull request #198 from sc… (compare)

  • Jun 27 23:43
    cquiroz closed #198
  • Jun 27 22:52
    scala-steward opened #198
  • Jun 27 18:44

    cquiroz on master

    Update sbt-tpolecat to 0.1.13 Merge pull request #197 from sc… (compare)

  • Jun 27 18:44
    cquiroz closed #197
  • Jun 27 00:26
    scala-steward opened #197
  • Jun 20 00:49

    cquiroz on master

    Update scalafmt-core to 2.6.1 Merge pull request #196 from sc… (compare)

  • Jun 20 00:49
    cquiroz closed #196
  • Jun 19 18:41
    scala-steward opened #196
  • Jun 19 03:10

    cquiroz on master

    Update scalatest to 3.2.0 Merge pull request #195 from sc… (compare)

  • Jun 19 03:10
    cquiroz closed #195
  • Jun 19 02:28
    scala-steward opened #195
  • Jun 17 13:10
    cquiroz closed #194
  • Jun 17 13:08

    cquiroz on master

    Reformat Signed-off-by: Carlos… (compare)

  • Jun 17 02:28
    scala-steward opened #194
  • Jun 02 21:16

    cquiroz on master

    Update sbt-tpolecat to 0.1.12 Merge pull request #193 from sc… (compare)

  • Jun 02 21:16
    cquiroz closed #193
Matthew de Detrich
@mdedetrich
@cquiroz Actually I found another problem, it appears that the sbt-plugin doesn't generate tzdb_java.scala for all versions of Scala
Carlos Quiroz
@cquiroz
hmm
Matthew de Detrich
@mdedetrich
i.e. if you are using crossScalaVersions I get the following error if I do +compile 
[error] source file '/Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala' could not be found
[error] one error found
[error] (logisticsCommonJS / Compile / compileIncremental) Compilation failed
[error] Total time: 5 s, completed Oct 22, 2018 7:18:34 PM
Carlos Quiroz
@cquiroz
I haven’t tried that
so it seems to tell that it was generated
but it wasn’t?
Matthew de Detrich
@mdedetrich
It generated it for Scala 2.12.x, but not for Scala 2.11.x
Carlos Quiroz
@cquiroz
what if you compile each version separated?
Matthew de Detrich
@mdedetrich
Tried that by using set scalaVersion in ThisBuild := "2.11.12"
Carlos Quiroz
@cquiroz
or ++2.11.12
Matthew de Detrich
@mdedetrich
nope
never new that command existed though, thanks!
So I figured out why its happening
If you go into an SBT project, do ++2.11.12 and then do compile:sourceManaged it still points to 2.11
same deal with compile:resourceManaged
Which is what you are using here https://github.com/cquiroz/sbt-tzdb/blob/master/src/main/scala/io/github/sbt/tzdb/SbtTzdb.scala#L53-L54
Carlos Quiroz
@cquiroz
the generated file gos to resourceManaged
Matthew de Detrich
@mdedetrich
resourceManaged is the same
Should I ask in sbt?
Carlos Quiroz
@cquiroz
i think so, My expertise on sbt is very limited :S
Matthew de Detrich
@mdedetrich
I think your detection may be the issue
https://github.com/cquiroz/sbt-tzdb/blob/master/src/main/scala/io/github/sbt/tzdb/SbtTzdb.scala#L83
Should probably be 
IOTasks.providerFile(sourceManaged in compile, "TzdbZoneRulesProvider.scala", "java.time.zone")
Lets see if that fixes it
Carlos Quiroz
@cquiroz
i see
Matthew de Detrich
@mdedetrich
I am trying it locally to see if it fixes it, gimme 20-30 minutes (sbt is kinda slow)
Hmm now its being kinda weird, doesn't detect it in any case
Carlos Quiroz
@cquiroz
sbt is infuriating
Matthew de Detrich
@mdedetrich
Can't agree with you more
Is there a task to manually generate the resource?
Carlos Quiroz
@cquiroz
there is a single task that will generate the tzdb
Matthew de Detrich
@mdedetrich
sbt:logistics-common> show logisticsCommonTestJS:tzdbCodeGen
[info] * /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/java/time/zone/TzdbZoneRulesProvider.scala
[info] * /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala
[success] Total time: 0 s, completed Oct 22, 2018 7:47:45 PM
sbt:logistics-common> logisticsCommonTestJS/test
[info] Compiling 2 Scala sources to /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/classes ...
[error] source file '/Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala' could not be found
[error] one error found
[error] (logisticsCommonJS / Compile / compileIncremental) Compilation failed
[error] Total time: 2 s, completed Oct 22, 2018 7:47:52 PM
sbt:logistics-common>
The hell
Okay so I think I may have found an issue
This file definitely doesn't exist
That is /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala
Carlos Quiroz
@cquiroz
you can see that I check if the file exists and it won’t be generated in that case
But it maybe checking in the incorrect place
in this case
Matthew de Detrich
@mdedetrich
Yeah the thing is this file doesn't even exist
So its not even downloading it
Matthew de Detrich
@mdedetrich
So I figured out on thing, multiple compiles in a row doesn't work
Thats what I think is causing the issue
I have to manually wipe src_managed and resource_managed and then update sbt
Carlos Quiroz
@cquiroz
hmm
doesn’t seem very satisfactory
Matthew de Detrich
@mdedetrich
Anyways I found another issue
I am getting