Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • May 16 11:22
    sideeffffect synchronize #376
  • May 16 10:39
    sideeffffect synchronize #376
  • May 16 10:02
    sideeffffect synchronize #376
  • May 16 09:42
    sideeffffect synchronize #376
  • May 14 16:21
    scala-steward opened #377
  • May 09 13:35

    cquiroz on master

    Update portable-scala-reflect t… Merge pull request #373 from sc… (compare)

  • May 09 13:35
    cquiroz closed #373
  • May 09 12:02
    sideeffffect commented #376
  • May 09 11:07
    sideeffffect synchronize #376
  • May 09 10:40
    sideeffffect edited #376
  • May 09 10:39
    sideeffffect edited #376
  • May 09 10:39
    sideeffffect opened #376
  • May 09 10:15
    sideeffffect commented #373
  • Apr 30 20:29

    cquiroz on master

    Update scalafmt-core to 3.5.2 Merge pull request #375 from sc… (compare)

  • Apr 30 20:29
    cquiroz closed #375
  • Apr 30 16:17
    scala-steward opened #375
  • Apr 26 03:51

    cquiroz on master

    Update scalatest to 3.2.12 Merge pull request #374 from sc… (compare)

  • Apr 26 03:51
    cquiroz closed #374
  • Apr 25 10:21
    scala-steward opened #374
  • Apr 20 16:13
    scala-steward opened #373
Matthew de Detrich
@mdedetrich
@cquiroz Actually I found another problem, it appears that the sbt-plugin doesn't generate tzdb_java.scala for all versions of Scala
Carlos Quiroz
@cquiroz
hmm
Matthew de Detrich
@mdedetrich
i.e. if you are using crossScalaVersions I get the following error if I do +compile 
[error] source file '/Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala' could not be found
[error] one error found
[error] (logisticsCommonJS / Compile / compileIncremental) Compilation failed
[error] Total time: 5 s, completed Oct 22, 2018 7:18:34 PM
Carlos Quiroz
@cquiroz
I haven’t tried that
so it seems to tell that it was generated
but it wasn’t?
Matthew de Detrich
@mdedetrich
It generated it for Scala 2.12.x, but not for Scala 2.11.x
Carlos Quiroz
@cquiroz
what if you compile each version separated?
Matthew de Detrich
@mdedetrich
Tried that by using set scalaVersion in ThisBuild := "2.11.12"
Carlos Quiroz
@cquiroz
or ++2.11.12
Matthew de Detrich
@mdedetrich
nope
never new that command existed though, thanks!
So I figured out why its happening
If you go into an SBT project, do ++2.11.12 and then do compile:sourceManaged it still points to 2.11
same deal with compile:resourceManaged
Which is what you are using here https://github.com/cquiroz/sbt-tzdb/blob/master/src/main/scala/io/github/sbt/tzdb/SbtTzdb.scala#L53-L54
Carlos Quiroz
@cquiroz
the generated file gos to resourceManaged
Matthew de Detrich
@mdedetrich
resourceManaged is the same
Should I ask in sbt?
Carlos Quiroz
@cquiroz
i think so, My expertise on sbt is very limited :S
Matthew de Detrich
@mdedetrich
I think your detection may be the issue
https://github.com/cquiroz/sbt-tzdb/blob/master/src/main/scala/io/github/sbt/tzdb/SbtTzdb.scala#L83
Should probably be 
IOTasks.providerFile(sourceManaged in compile, "TzdbZoneRulesProvider.scala", "java.time.zone")
Lets see if that fixes it
Carlos Quiroz
@cquiroz
i see
Matthew de Detrich
@mdedetrich
I am trying it locally to see if it fixes it, gimme 20-30 minutes (sbt is kinda slow)
Hmm now its being kinda weird, doesn't detect it in any case
Carlos Quiroz
@cquiroz
sbt is infuriating
Matthew de Detrich
@mdedetrich
Can't agree with you more
Is there a task to manually generate the resource?
Carlos Quiroz
@cquiroz
there is a single task that will generate the tzdb
Matthew de Detrich
@mdedetrich
sbt:logistics-common> show logisticsCommonTestJS:tzdbCodeGen
[info] * /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/java/time/zone/TzdbZoneRulesProvider.scala
[info] * /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala
[success] Total time: 0 s, completed Oct 22, 2018 7:47:45 PM
sbt:logistics-common> logisticsCommonTestJS/test
[info] Compiling 2 Scala sources to /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/classes ...
[error] source file '/Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala' could not be found
[error] one error found
[error] (logisticsCommonJS / Compile / compileIncremental) Compilation failed
[error] Total time: 2 s, completed Oct 22, 2018 7:47:52 PM
sbt:logistics-common>
The hell
Okay so I think I may have found an issue
This file definitely doesn't exist
That is /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala
Carlos Quiroz
@cquiroz
you can see that I check if the file exists and it won’t be generated in that case
But it maybe checking in the incorrect place
in this case
Matthew de Detrich
@mdedetrich
Yeah the thing is this file doesn't even exist
So its not even downloading it
Matthew de Detrich
@mdedetrich
So I figured out on thing, multiple compiles in a row doesn't work
Thats what I think is causing the issue
I have to manually wipe src_managed and resource_managed and then update sbt
Carlos Quiroz
@cquiroz
hmm
doesn’t seem very satisfactory
Matthew de Detrich
@mdedetrich
Anyways I found another issue
I am getting