by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 02 21:16

    cquiroz on master

    Update sbt-tpolecat to 0.1.12 Merge pull request #193 from sc… (compare)

  • Jun 02 21:16
    cquiroz closed #193
  • Jun 02 20:45
    scala-steward opened #193
  • May 31 01:23

    cquiroz on master

    Update sbt to 1.3.12 Merge pull request #192 from sc… (compare)

  • May 31 01:23
    cquiroz closed #192
  • May 31 01:09
    cquiroz closed #191
  • May 31 00:53
    scala-steward opened #192
  • May 29 20:59
    scala-steward opened #191
  • May 26 14:58

    cquiroz on master

    Update scalafmt-core to 2.5.3 Merge pull request #190 from sc… (compare)

  • May 26 14:58
    cquiroz closed #190
  • May 26 02:31
    scala-steward opened #190
  • May 16 02:02

    cquiroz on master

    Update sbt-scalajs, scalajs-com… Merge pull request #189 from sc… (compare)

  • May 16 02:02
    cquiroz closed #189
  • May 15 22:17
    scala-steward opened #189
  • May 14 15:23

    cquiroz on master

    Update sbt-scalafmt to 2.4.0 Merge pull request #188 from sc… (compare)

  • May 14 15:23
    cquiroz closed #188
  • May 14 14:38
    scala-steward opened #188
  • May 11 15:55

    cquiroz on master

    Update scalafmt Signed-off-by:… (compare)

  • May 11 15:48

    cquiroz on master

    Update scalatest to 3.1.2 Merge pull request #186 from sc… (compare)

  • May 11 15:48
    cquiroz closed #186
Carlos Quiroz
@cquiroz
i think so, My expertise on sbt is very limited :S
Matthew de Detrich
@mdedetrich
I think your detection may be the issue
Should probably be
IOTasks.providerFile(sourceManaged in compile, "TzdbZoneRulesProvider.scala", "java.time.zone")
Lets see if that fixes it
Carlos Quiroz
@cquiroz
i see
Matthew de Detrich
@mdedetrich
I am trying it locally to see if it fixes it, gimme 20-30 minutes (sbt is kinda slow)
Hmm now its being kinda weird, doesn't detect it in any case
Carlos Quiroz
@cquiroz
sbt is infuriating
Matthew de Detrich
@mdedetrich
Can't agree with you more
Is there a task to manually generate the resource?
Carlos Quiroz
@cquiroz
there is a single task that will generate the tzdb
Matthew de Detrich
@mdedetrich
sbt:logistics-common> show logisticsCommonTestJS:tzdbCodeGen
[info] * /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/java/time/zone/TzdbZoneRulesProvider.scala
[info] * /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala
[success] Total time: 0 s, completed Oct 22, 2018 7:47:45 PM
sbt:logistics-common> logisticsCommonTestJS/test
[info] Compiling 2 Scala sources to /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/classes ...
[error] source file '/Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala' could not be found
[error] one error found
[error] (logisticsCommonJS / Compile / compileIncremental) Compilation failed
[error] Total time: 2 s, completed Oct 22, 2018 7:47:52 PM
sbt:logistics-common>
The hell
Okay so I think I may have found an issue
This file definitely doesn't exist
That is /Users/mdedetrich/zalando-github/logistics-common/logistics-common/js/target/scala-2.11/src_managed/main/tzdb/tzdb_java.scala
Carlos Quiroz
@cquiroz
you can see that I check if the file exists and it won’t be generated in that case
But it maybe checking in the incorrect place
in this case
Matthew de Detrich
@mdedetrich
Yeah the thing is this file doesn't even exist
So its not even downloading it
Matthew de Detrich
@mdedetrich
So I figured out on thing, multiple compiles in a row doesn't work
Thats what I think is causing the issue
I have to manually wipe src_managed and resource_managed and then update sbt
Carlos Quiroz
@cquiroz
hmm
doesn’t seem very satisfactory
Matthew de Detrich
@mdedetrich
Anyways I found another issue
I am getting
[error] java.time.DateTimeException: Invalid value for HourOfDay (valid values 0 - 23): 25
[error]     at java.time.temporal.ValueRange.checkValidValue(ValueRange.java:311)
[error]     at java.time.temporal.ChronoField.checkValidValue(ChronoField.java:703)
[error]     at java.time.LocalTime.of(LocalTime.java:296)
[error]     at kuyfi.TZDBParser$.$anonfun$hourMinParserLT$1(TZDBParser.scala:118)
[error]     at atto.Parser$$anon$5.$anonfun$apply$5(Parser.scala:29)
[error]     at cats.Eval$.advance(Eval.scala:272)
[error]     at cats.Eval$.loop$1(Eval.scala:354)
[error]     at cats.Eval$.cats$Eval$$evaluate(Eval.scala:372)
[error]     at cats.Eval$Defer.value(Eval.scala:258)
[error]     at atto.ParserFunctions.parseOnly(Parser.scala:102)
[error]     at atto.ParserFunctions.parseOnly$(Parser.scala:99)
[error]     at atto.Parser$.parseOnly(Parser.scala:42)
[error]     at atto.syntax.ParserOps.parseOnly(ParserOps.scala:19)
[error]     at atto.syntax.ParserOps.parseOnly$(ParserOps.scala:18)
[error]     at atto.syntax.ToParserOps$$anon$1.parseOnly(ParserOps.scala:99)
[error]     at kuyfi.TZDBParser$.parseFile(TZDBParser.scala:256)
[error]     at kuyfi.TZDBParser$.$anonfun$parseAll$3(TZDBParser.scala:293)
[error]     at scala.collection.Iterator$$anon$10.next(Iterator.scala:457)
[error]     at scala.collection.Iterator.foreach(Iterator.scala:944)
[error]     at scala.collection.Iterator.foreach$(Iterator.scala:944)
[error]     at scala.collection.AbstractIterator.foreach(Iterator.scala:1432)
[error]     at scala.collection.generic.Growable.$plus$plus$eq(Growable.scala:59)
[error]     at scala.collection.generic.Growable.$plus$plus$eq$(Growable.scala:50)
[error]     at scala.collection.mutable.ListBuffer.$plus$plus$eq(ListBuffer.scala:186)
[error]     at scala.collection.mutable.ListBuffer.$plus$plus$eq(ListBuffer.scala:44)
[error]     at scala.collection.TraversableOnce.to(TraversableOnce.scala:310)
[error]     at scala.collection.TraversableOnce.to$(TraversableOnce.scala:308)
[error]     at scala.collection.AbstractIterator.to(Iterator.scala:1432)
[error]     at scala.collection.TraversableOnce.toList(TraversableOnce.scala:294)
[error]     at scala.collection.TraversableOnce.toList$(TraversableOnce.scala:294)
[error]     at scala.collection.AbstractIterator.toList(Iterator.scala:1432)
[error]     at kuyfi.TZDBParser$.$anonfun$parseAll$1(TZDBParser.scala:294)
[error]     at cats.effect.internals.IORunLoop$.step(IORunLoop.scala:167)
[error]     at cats.effect.IO.unsafeRunTimed(IO.scala:307)
[error]     at cats.effect.IO.unsafeRunSync(IO.scala:242)
[error]     at io.gitub.sbt.tzdb.TzdbPlugin$.tzdbCodeGenImpl(SbtTzdb.scala:79)
[error]     at io.gitub.sbt.tzdb.TzdbPlugin$.$anonfun$projectSettings$3(SbtTzdb.scala:60)
[error]     at scala.Function1.$anonfun$compose$1(Function1.scala:44)
[error]     at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:40)
[error]     at sbt.std.Transform$$anon$4.work(System.scala:67)
[error]     at sbt.Execute.$anonfun$submit$2(Execute.scala:269)
[error]     at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:16)
[error]     at sbt.Execute.work(Execute.scala:278)
[error]     at sbt.Execute.$anonfun$submit$1(Execute.scala:269)
[error]     at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178)
[error]     at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)
[error]     at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error]     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error]     at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error]     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error]     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error]     at java.lang.Thread.run(Thread.java:748)
So I think the tz data may be screwed?
There seems to be a 25 there
Carlos Quiroz
@cquiroz
ah yes,
that is fixed
Matthew de Detrich
@mdedetrich
Is it released?
Carlos Quiroz
@cquiroz
did a fix yesterday on version 0.3.0
the tz db has changed a lot lately
Matthew de Detrich
@mdedetrich
Ah I see, did you publish 0.3.0?
Carlos Quiroz
@cquiroz
yes
Matthew de Detrich
@mdedetrich
Hmm so I was using a seriously outdated version of sbt-tzdb
So my previous thing may be a false alarm
Let me see how it works now!
Carlos Quiroz
@cquiroz
i haven’t changed that part in a long time
But please do try
Matthew de Detrich
@mdedetrich
Will do
Matthew de Detrich
@mdedetrich
Okay thanks, updating sbt-tzdb fixed the original issue
And also multiple compiles in a row work
So let me see if crossCompiling works
Hmm okay it doesn't, @cquiroz I will try and work on fixing this tonight and I will send a PR if am successful okay?