Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • May 01 11:38

    cquiroz on master

    Bump actions/cache from v2.1.4 … Merge pull request #283 from cq… (compare)

  • May 01 11:38

    cquiroz on github_actions

    (compare)

  • May 01 11:38
    cquiroz closed #283
  • May 01 05:29
    dependabot[bot] labeled #283
  • May 01 05:29
    dependabot[bot] opened #283
  • May 01 05:29

    dependabot[bot] on github_actions

    Bump actions/cache from v2.1.4 … (compare)

  • Apr 27 15:42
    cquiroz closed #280
  • Apr 27 15:42

    cquiroz on master

    Update sbt-microsites to 1.3.4 Merge pull request #282 from sc… (compare)

  • Apr 27 15:42
    cquiroz closed #282
  • Apr 27 14:24
    scala-steward opened #282
  • Apr 26 15:35

    cquiroz on master

    Update sbt to 1.5.1 Merge pull request #281 from sc… (compare)

  • Apr 26 15:35
    cquiroz closed #281
  • Apr 26 07:29
    scala-steward opened #281
  • Apr 23 14:22
    scala-steward opened #280
  • Apr 22 01:06

    cquiroz on v2.2.2

    (compare)

  • Apr 22 01:05

    cquiroz on master

    Update scala 3 Signed-off-by: … Merge pull request #279 from cq… (compare)

  • Apr 22 01:05

    cquiroz on scala-update

    (compare)

  • Apr 22 01:05
    cquiroz closed #279
  • Apr 22 00:37
    cquiroz opened #279
  • Apr 21 23:29

    cquiroz on scala-update

    Update scala 3 Signed-off-by: … (compare)

Carlos Quiroz
@cquiroz
I could just make Category top level and that would solve it
but then the API would not match the original java API
Which I guess is mostly a non issue
But still
Carlos Quiroz
@cquiroz
I published 2.0.0-RC4 with support for scala.js 1.0 and sbt-locales
If nothing major is found this will become 2.0.0 next week
Carlos Quiroz
@cquiroz
RC4 ended up incorrectly bulit. I’ll get RC5 asap
Alex Henning Johannessen
@ahjohannessen
@cquiroz :+1:
Carlos Quiroz
@cquiroz
RC5 is on its way to maven central
Carlos Quiroz
@cquiroz
I’m removing the custom serialization format on
I doubt this will affect many people but just in case feel free to comment
Andriy Plokhotnyuk
@plokhotnyuk
Hi, All! Thanks to contributors of the scala-java-time library!
Last week jsoniter-scala got Scala.js support only because your great product exists!
Andriy Plokhotnyuk
@plokhotnyuk
Would you be interested in porting some efficient routines for parsing and serialization of java.time._ values from/to the string representation?
Carlos Quiroz
@cquiroz
Thanks @plokhotnyuk
I’m not sure what do you mean? There are as part of the API methods to read/write strings
Andriy Plokhotnyuk
@plokhotnyuk
Yep, and jsoniter-scala has much more efficient version of parse and toString routines that outperform the original implementation from 10x to 100x times depending on data type and version of JVM.
Please, see results of benchmarks for java.time._ types here to estimate a possible speed up.
Carlos Quiroz
@cquiroz
Parsing and formatting are some of the most complicated parts of scala-java-time so any improvement would be great
Note that parsing and formatting are greatly influenced by the locale
Also I’m very interested on the js size as the library is already quite good, I’d prefer a smaller code size over faster speed
But as I said any improvements would be creatly appreciated
Andriy Plokhotnyuk
@plokhotnyuk
How do you measure 'js size' of the library? I mean which exact command-line or sbt command can print the size in bytes to make it checked in the CI build... Is the timezone DB included in it?
Carlos Quiroz
@cquiroz
it is not really sience :D I have a demo project that makes a few calls into the API
and check the size as fullOptJS
it is not accurate as it depends on what you actually call and the size of your db but it gives you a notion
Andriy Plokhotnyuk
@plokhotnyuk
So, the idea is to use as much java.time._ classes as possible to make them picked by the linker to the result *-fastopt.js and *-opt.js files, isn't it?
Carlos Quiroz
@cquiroz
yes
Andriy Plokhotnyuk
@plokhotnyuk
First results from the Chrome browser:
image.png
image.png
image.png
image.png
image.png
Andriy Plokhotnyuk
@plokhotnyuk
image.png
Carlos Quiroz
@cquiroz
👍👏
Andriy Plokhotnyuk
@plokhotnyuk
You can run them in your browser here.
Trond Bjerkestrand
@tbjerkes_twitter
Hi! When moving from sjs 0.6 to 1.1 I experience a problem with fullOptJS as soon as I use ZonedDateTime . Did anyone else experience this ?
Carlos Quiroz
@cquiroz
What kind of problem?
Trond Bjerkestrand
@tbjerkes_twitter
[error] (client / Compile / fullOptJS) INTERNAL COMPILER ERROR.
Let me push a minimal example to a repo
Trond Bjerkestrand
@tbjerkes_twitter
fastOptJS works well - also fullOptJS in sjs 0.6
Carlos Quiroz
@cquiroz
Oh that seems an issue to be raised at the scalajs level
Trond Bjerkestrand
@tbjerkes_twitter
Yes, wil do, just wanted to find if anyone else had seen it over here.
Trond Bjerkestrand
@tbjerkes_twitter
Actually the problem only occurs when scala-java-time-tzdb is among the dependencies (scala-js/scala-js#4098)
Matthew de Detrich
@mdedetrich

So I am using Circe 0.13.0 and I am getting this error

[error] Referring to non-existent method java.time.format.DateTimeFormatter$.ofPattern(java.lang.String)java.time.format.DateTimeFormatter
[error]   called from de.zalando.logistics.common.itemtrace.model.DeployedCirceImplicits.$$init$()scala.Unit
[error]   called from de.zalando.logistics.common.DeployedGlobalCirceImplicits$.<init>()
[error]   called from states.States$.<init>()
[error]   called from components.Header$.$$anonfun$component$2(japgolly.scalajs.react.CompScope$DuringCallbackU,components.HeaderProps,scala.runtime.BoxedUnit)japgolly.scalajs.react.ReactElement
[error]   called from components.Header$.<init>()
[error]   called from components.Content$.$$anonfun$component$2(japgolly.scalajs.react.CompScope$DuringCallbackU,components.ContentProps,scala.runtime.BoxedUnit)japgolly.scalajs.react.ReactElement
[error]   called from components.Content$.<init>()
[error]   called from components.backend.Backend.render(components.MainProps,states.States$MainObject)japgolly.scalajs.react.ReactElement
[error]   called from components.MainComponent$.$$anonfun$App$3(japgolly.scalajs.react.CompScope$DuringCallbackU)japgolly.scalajs.react.ReactElement
[error]   called from components.MainComponent$.<init>()
[error]   called from components.KeyCapture$Backend.render(components.KCInput)japgolly.scalajs.react.ReactComponentU
[error]   called from components.KeyCapture$.$$anonfun$component$3(japgolly.scalajs.react.CompScope$DuringCallbackU)japgolly.scalajs.react.ReactComponentU
[error]   called from components.KeyCapture$.<init>()
[error]   called from Main$.main([java.lang.String)scala.Unit
[error]   called from core module module initializers

Even though I have "io.github.cquiroz" %%% "scala-java-time" % scalaJavaTimeV, in my Scala.js settings (scalaJavaTimeV is 2.0.0). Any ideas?

Carlos Quiroz
@cquiroz
Can you reproduce it calling the method outside Circe?
Matthew de Detrich
@mdedetrich
This is happening at compile time though, not at runtime?