Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 14 13:43

    cquiroz on master

    Update sbt to 1.5.4 Merge pull request #297 from sc… (compare)

  • Jun 14 13:43
    cquiroz closed #297
  • Jun 14 04:43
    scala-steward opened #297
  • Jun 08 20:48

    cquiroz on master

    Update scalajs-compiler to 1.6.0 Merge pull request #296 from sc… (compare)

  • Jun 08 20:48
    cquiroz closed #296
  • Jun 08 20:19
    scala-steward opened #296
  • Jun 08 16:29
    scala-steward opened #295
  • Jun 07 16:42
    ekrich commented #45
  • Jun 07 16:33
    cquiroz commented #45
  • Jun 07 16:20
    ekrich commented #45
  • Jun 07 15:58
    cquiroz commented #45
  • Jun 07 15:09
    ekrich commented #45
  • Jun 01 13:53

    cquiroz on master

    Update sbt to 1.5.3 Merge pull request #291 from sc… (compare)

  • Jun 01 13:53
    cquiroz closed #291
  • Jun 01 13:51

    cquiroz on github_actions

    (compare)

  • Jun 01 13:51

    cquiroz on master

    Bump olafurpg/setup-scala from … Merge pull request #292 from cq… (compare)

  • Jun 01 13:51
    cquiroz closed #292
  • Jun 01 13:51

    cquiroz on master

    Bump actions/cache from 2.1.5 t… Merge pull request #293 from cq… (compare)

  • Jun 01 13:51

    cquiroz on github_actions

    (compare)

  • Jun 01 05:25
    dependabot[bot] labeled #293
Carlos Quiroz
@cquiroz
Thanks @plokhotnyuk
I’m not sure what do you mean? There are as part of the API methods to read/write strings
Andriy Plokhotnyuk
@plokhotnyuk
Yep, and jsoniter-scala has much more efficient version of parse and toString routines that outperform the original implementation from 10x to 100x times depending on data type and version of JVM.
Please, see results of benchmarks for java.time._ types here to estimate a possible speed up.
Carlos Quiroz
@cquiroz
Parsing and formatting are some of the most complicated parts of scala-java-time so any improvement would be great
Note that parsing and formatting are greatly influenced by the locale
Also I’m very interested on the js size as the library is already quite good, I’d prefer a smaller code size over faster speed
But as I said any improvements would be creatly appreciated
Andriy Plokhotnyuk
@plokhotnyuk
How do you measure 'js size' of the library? I mean which exact command-line or sbt command can print the size in bytes to make it checked in the CI build... Is the timezone DB included in it?
Carlos Quiroz
@cquiroz
it is not really sience :D I have a demo project that makes a few calls into the API
and check the size as fullOptJS
it is not accurate as it depends on what you actually call and the size of your db but it gives you a notion
Andriy Plokhotnyuk
@plokhotnyuk
So, the idea is to use as much java.time._ classes as possible to make them picked by the linker to the result *-fastopt.js and *-opt.js files, isn't it?
Carlos Quiroz
@cquiroz
yes
Andriy Plokhotnyuk
@plokhotnyuk
First results from the Chrome browser:
image.png
image.png
image.png
image.png
image.png
Andriy Plokhotnyuk
@plokhotnyuk
image.png
Carlos Quiroz
@cquiroz
👍👏
Andriy Plokhotnyuk
@plokhotnyuk
You can run them in your browser here.
Trond Bjerkestrand
@tbjerkes_twitter
Hi! When moving from sjs 0.6 to 1.1 I experience a problem with fullOptJS as soon as I use ZonedDateTime . Did anyone else experience this ?
Carlos Quiroz
@cquiroz
What kind of problem?
Trond Bjerkestrand
@tbjerkes_twitter
[error] (client / Compile / fullOptJS) INTERNAL COMPILER ERROR.
Let me push a minimal example to a repo
Trond Bjerkestrand
@tbjerkes_twitter
fastOptJS works well - also fullOptJS in sjs 0.6
Carlos Quiroz
@cquiroz
Oh that seems an issue to be raised at the scalajs level
Trond Bjerkestrand
@tbjerkes_twitter
Yes, wil do, just wanted to find if anyone else had seen it over here.
Trond Bjerkestrand
@tbjerkes_twitter
Actually the problem only occurs when scala-java-time-tzdb is among the dependencies (scala-js/scala-js#4098)
Matthew de Detrich
@mdedetrich

So I am using Circe 0.13.0 and I am getting this error

[error] Referring to non-existent method java.time.format.DateTimeFormatter$.ofPattern(java.lang.String)java.time.format.DateTimeFormatter
[error]   called from de.zalando.logistics.common.itemtrace.model.DeployedCirceImplicits.$$init$()scala.Unit
[error]   called from de.zalando.logistics.common.DeployedGlobalCirceImplicits$.<init>()
[error]   called from states.States$.<init>()
[error]   called from components.Header$.$$anonfun$component$2(japgolly.scalajs.react.CompScope$DuringCallbackU,components.HeaderProps,scala.runtime.BoxedUnit)japgolly.scalajs.react.ReactElement
[error]   called from components.Header$.<init>()
[error]   called from components.Content$.$$anonfun$component$2(japgolly.scalajs.react.CompScope$DuringCallbackU,components.ContentProps,scala.runtime.BoxedUnit)japgolly.scalajs.react.ReactElement
[error]   called from components.Content$.<init>()
[error]   called from components.backend.Backend.render(components.MainProps,states.States$MainObject)japgolly.scalajs.react.ReactElement
[error]   called from components.MainComponent$.$$anonfun$App$3(japgolly.scalajs.react.CompScope$DuringCallbackU)japgolly.scalajs.react.ReactElement
[error]   called from components.MainComponent$.<init>()
[error]   called from components.KeyCapture$Backend.render(components.KCInput)japgolly.scalajs.react.ReactComponentU
[error]   called from components.KeyCapture$.$$anonfun$component$3(japgolly.scalajs.react.CompScope$DuringCallbackU)japgolly.scalajs.react.ReactComponentU
[error]   called from components.KeyCapture$.<init>()
[error]   called from Main$.main([java.lang.String)scala.Unit
[error]   called from core module module initializers

Even though I have "io.github.cquiroz" %%% "scala-java-time" % scalaJavaTimeV, in my Scala.js settings (scalaJavaTimeV is 2.0.0). Any ideas?

Carlos Quiroz
@cquiroz
Can you reproduce it calling the method outside Circe?
Matthew de Detrich
@mdedetrich
This is happening at compile time though, not at runtime?
or on fastOptJs I think
Matthew de Detrich
@mdedetrich
it appears to be some sought of linking error
Carlos Quiroz
@cquiroz
Circe was producing a minimal java time package just to get to compile, perhaps that is still present in your case?
I use Circe on my scala.js projects just fine, though I don’t recall if there are date fields on the Json structured
Matthew de Detrich
@mdedetrich

Circe was producing a minimal java time package just to get to compile, perhaps that is still present in your case?

You mean the dependency wasn't being overwritten? Let me ask in Circe then

Carlos Quiroz
@cquiroz
I’m not sure how that works on the circe side. but the scala.js linker gets very confused if there are two packages providing the same set of classes
Matthew de Detrich
@mdedetrich
Hmm, so should I be including circe-generic or something else
Matthew de Detrich
@mdedetrich
@cquiroz Do you have any tips on how to resolve this issue? I am kinda stuck here and Travis understandably doesn't want to help because hes sick of the fragmentation caused by not having java-time in standard Scala.js
Carlos Quiroz
@cquiroz
Do you think this could be reproduced without circe?
The method in particular is implemented at
It would be interesting to see a minmial reproduction with or without circe
Matthew de Detrich
@mdedetrich
Yeah I will work on a reproduction
Also its many methods, not just that one
Matthew de Detrich
@mdedetrich
So I figured out the issue,probably due to some dependency resolution