by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Aug 10 13:58
    pshirshov closed #206
  • Aug 10 13:58
    pshirshov commented #206
  • Aug 08 16:30

    cquiroz on libupdates

    Lib updates Signed-off-by: Car… (compare)

  • Aug 08 16:28

    cquiroz on testfx

    (compare)

  • Aug 08 16:28

    cquiroz on master

    Fix running test on the latest … Update scala versions Signed-o… Merge pull request #208 from cq… (compare)

  • Aug 08 16:28
    cquiroz closed #208
  • Aug 08 15:59
    cquiroz synchronize #208
  • Aug 08 15:59

    cquiroz on testfx

    Update scala versions Signed-o… (compare)

  • Aug 08 15:48
    cquiroz opened #208
  • Aug 08 15:19

    cquiroz on testfx

    Fix running test on the latest … (compare)

  • Aug 08 15:15

    cquiroz on testfx

    Fix running test on the latest … (compare)

  • Aug 08 15:07
    cquiroz commented #206
  • Aug 08 14:49
    pshirshov commented #206
  • Aug 07 04:32
    scala-steward opened #207
  • Aug 06 19:38
    cquiroz commented #206
  • Aug 06 13:44
    pshirshov opened #206
  • Aug 01 18:30
    scala-steward opened #205
  • Jul 24 23:50
    cquiroz closed #204
  • Jul 20 18:34
    scala-steward opened #204
  • Jul 10 21:03

    cquiroz on master

    Update scalafmt-core to 2.6.3 Merge pull request #203 from sc… (compare)

Carlos Quiroz
@cquiroz
it is not really sience :D I have a demo project that makes a few calls into the API
and check the size as fullOptJS
it is not accurate as it depends on what you actually call and the size of your db but it gives you a notion
Andriy Plokhotnyuk
@plokhotnyuk
So, the idea is to use as much java.time._ classes as possible to make them picked by the linker to the result *-fastopt.js and *-opt.js files, isn't it?
Carlos Quiroz
@cquiroz
yes
Andriy Plokhotnyuk
@plokhotnyuk
First results from the Chrome browser:
image.png
image.png
image.png
image.png
image.png
Andriy Plokhotnyuk
@plokhotnyuk
image.png
Carlos Quiroz
@cquiroz
👍👏
Andriy Plokhotnyuk
@plokhotnyuk
You can run them in your browser here.
Trond Bjerkestrand
@tbjerkes_twitter
Hi! When moving from sjs 0.6 to 1.1 I experience a problem with fullOptJS as soon as I use ZonedDateTime . Did anyone else experience this ?
Carlos Quiroz
@cquiroz
What kind of problem?
Trond Bjerkestrand
@tbjerkes_twitter
[error] (client / Compile / fullOptJS) INTERNAL COMPILER ERROR.
Let me push a minimal example to a repo
Trond Bjerkestrand
@tbjerkes_twitter
fastOptJS works well - also fullOptJS in sjs 0.6
Carlos Quiroz
@cquiroz
Oh that seems an issue to be raised at the scalajs level
Trond Bjerkestrand
@tbjerkes_twitter
Yes, wil do, just wanted to find if anyone else had seen it over here.
Trond Bjerkestrand
@tbjerkes_twitter
Actually the problem only occurs when scala-java-time-tzdb is among the dependencies (scala-js/scala-js#4098)
Matthew de Detrich
@mdedetrich

So I am using Circe 0.13.0 and I am getting this error

[error] Referring to non-existent method java.time.format.DateTimeFormatter$.ofPattern(java.lang.String)java.time.format.DateTimeFormatter
[error]   called from de.zalando.logistics.common.itemtrace.model.DeployedCirceImplicits.$$init$()scala.Unit
[error]   called from de.zalando.logistics.common.DeployedGlobalCirceImplicits$.<init>()
[error]   called from states.States$.<init>()
[error]   called from components.Header$.$$anonfun$component$2(japgolly.scalajs.react.CompScope$DuringCallbackU,components.HeaderProps,scala.runtime.BoxedUnit)japgolly.scalajs.react.ReactElement
[error]   called from components.Header$.<init>()
[error]   called from components.Content$.$$anonfun$component$2(japgolly.scalajs.react.CompScope$DuringCallbackU,components.ContentProps,scala.runtime.BoxedUnit)japgolly.scalajs.react.ReactElement
[error]   called from components.Content$.<init>()
[error]   called from components.backend.Backend.render(components.MainProps,states.States$MainObject)japgolly.scalajs.react.ReactElement
[error]   called from components.MainComponent$.$$anonfun$App$3(japgolly.scalajs.react.CompScope$DuringCallbackU)japgolly.scalajs.react.ReactElement
[error]   called from components.MainComponent$.<init>()
[error]   called from components.KeyCapture$Backend.render(components.KCInput)japgolly.scalajs.react.ReactComponentU
[error]   called from components.KeyCapture$.$$anonfun$component$3(japgolly.scalajs.react.CompScope$DuringCallbackU)japgolly.scalajs.react.ReactComponentU
[error]   called from components.KeyCapture$.<init>()
[error]   called from Main$.main([java.lang.String)scala.Unit
[error]   called from core module module initializers

Even though I have "io.github.cquiroz" %%% "scala-java-time" % scalaJavaTimeV, in my Scala.js settings (scalaJavaTimeV is 2.0.0). Any ideas?

Carlos Quiroz
@cquiroz
Can you reproduce it calling the method outside Circe?
Matthew de Detrich
@mdedetrich
This is happening at compile time though, not at runtime?
or on fastOptJs I think
Matthew de Detrich
@mdedetrich
it appears to be some sought of linking error
Carlos Quiroz
@cquiroz
Circe was producing a minimal java time package just to get to compile, perhaps that is still present in your case?
I use Circe on my scala.js projects just fine, though I don’t recall if there are date fields on the Json structured
Matthew de Detrich
@mdedetrich

Circe was producing a minimal java time package just to get to compile, perhaps that is still present in your case?

You mean the dependency wasn't being overwritten? Let me ask in Circe then

Carlos Quiroz
@cquiroz
I’m not sure how that works on the circe side. but the scala.js linker gets very confused if there are two packages providing the same set of classes
Matthew de Detrich
@mdedetrich
Hmm, so should I be including circe-generic or something else
Matthew de Detrich
@mdedetrich
@cquiroz Do you have any tips on how to resolve this issue? I am kinda stuck here and Travis understandably doesn't want to help because hes sick of the fragmentation caused by not having java-time in standard Scala.js
Carlos Quiroz
@cquiroz
Do you think this could be reproduced without circe?
The method in particular is implemented at
It would be interesting to see a minmial reproduction with or without circe
Matthew de Detrich
@mdedetrich
Yeah I will work on a reproduction
Also its many methods, not just that one
Matthew de Detrich
@mdedetrich
So I figured out the issue,probably due to some dependency resolution
Assuming you have a shared frontend/backend project (where you have js/shared/jvm), putting scala-java-time in both shared and js caused the issue
Putting it in only shared fixed the problem
Carlos Quiroz
@cquiroz
Hmm, ok it maybe there twice and it confuses the linked
Linker
Matthew de Detrich
@mdedetrich
Aren't you only meant to resolve a single jar only once or am I missing something here?
In any case I am happy it was resolved
Carlos Quiroz
@cquiroz
I think resoultion works fine at compilation time
But it is undefined on the linker, at any rate it is more of a question for scala.js
Matthew de Detrich
@mdedetrich
Okay I will make an issue for it