The tests don’t touch a lot of code but ...
The only difference is the
SCALAJS_VERSION=1.0.0-RC1?
I was waiting for Scala-collection-compat to try it out.
Ah yes it seems you have that.
You'll have to add a fake
trait URLConnection as well for this to work in 1.x.
0.6.x was too tolerant about that kind of situation.
Although, in a broader context, at some point you should refactor so that you don't need those fake things at all anymore. This is not a long term solution, because such a hack does not compose with another library that would have the same hack but with a different set of methods. One of the fakes would win on the classpath, and the code trying to use the other methods will fail to link.
Yes, I understand. It is a large library and I have no users and no help. I can’t get any users without some support but clearly the whole library could be changed and I am trying to improve it as well. There is tons of stuff I don’t like but I would some direction and users before making major unguided changes. Certainly only the Properties method is in play for a real implementation submitted to Scala.js
@sjrd Appreciate you taking a look :smile:
We released Scala.js 1.0.0-RC2, with a few bug fixes, more tests, some removal of deprecated APIs, and an important internal IR change. If no critical issue is found by the end of January 2020, this will become the final 1.0.0 release.
scalajs-bundler 0.16.0 should work out of the box with this new version. Mill 0.5.3 as well. For libraries, they will need to be republished for 1.0.0-RC2.
I'm excited about Scala.js 1.0! Re: https://twitter.com/scala_lang/status/1205570208561152000?s=12, are there instructions anywhere on how to add the RC to cross-builds? It's not obvious to me how I'd add the 0.6 and 1.0 plugins to my builds.
then at the sbt prompt you can do
SCALAJS_VERSION=1.0.0-RC2 sbt
that will set you up to play with the 1.0.0-RC2 version
That's clever though, thanks for the pointer
Hi all, I have the question whether do you use the tool https://github.com/sjrd/scala-js-ts-importer or some other similar tools to get type definitions at least half-automatically done? Someone told me that the typescript language is iterating so fast and there is almost no point in making a tool like this unless you are actively maintaining it with each new TS version. I wonder what about this one? I seem to be maintained. Do you have any experience to share in this subject?
It contains automatically generated typings for quite a lot of js libs
And it's actively maintained
Thank you @sbrunk, this is a fascinating resource. I see in the description that it "generally works", so I guess they are automatically generated, and still some manual adjustment might be needed. But it's better than nothing! Additionally, it is said: "All currently published artefacts should be considered snapshots and will be deleted without notice. Expect the first stable release soon". Ok, so it's an exciting preview. I can't wait for the release ;-)
I like this project. I see there some of my needs is already done. Now I have to add the missing ones.
So I'm still interested if about the tool to convert something for myself. I wonder whether the project from @sjrd is still valid and worth considering?
I like this project. I see there some of my needs is already done. Now I have to add the missing ones.
So I'm still interested if about the tool to convert something for myself. I wonder whether the project from @sjrd is still valid and worth considering?
It's true that typescript has been iterating at an amazing speed, but it has stabilized a lot since 3.0 (which is ages ago)
Right now I'm experimenting with alternative distribution methods, I think a final release is going to take the form of an sbt plugin instead
Also if you have any libraries you want right away I can add them to the nightly build
@oyvindberg Thank you for the response. A lot of Leaflet related stuff is already there. The one "missing" is https://github.com/Asymmetrik/leaflet-d3, but I'm not sure it's something that is in your scope?
I'll add it to the build for tomorrow so you can try. Note that the library uses module augmentation (see https://alligator.io/typescript/module-augmentation/ , essentially they type up a certain type of monkey patching), so you'll need to understand how that works. This demo demonstrates the concept for jquery and jqueryui https://github.com/oyvindberg/ScalablyTypedDemos/blob/master/jquery/src/main/scala/demo/JQueryDemo.scala