Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 29 08:35
    @sjrd banned @8bitpitRBX_twitter
  • May 23 13:44
    @sjrd banned @BIGCRYPTO001_gitlab
  • May 01 14:31
    @sjrd banned @Certificates1_gitlab
  • Apr 22 15:31
    @sjrd banned @lerbatax
  • Jan 31 23:04
    sjrd commented #3555
  • Jan 31 22:56
    sjrd review_requested #3555
  • Jan 31 22:56
    sjrd opened #3555
  • Jan 31 21:06

    sjrd on 0.6.x

    Remove dead code: specific coll… Adapt the signature of `js.Arra… Merge pull request #3554 from s… (compare)

  • Jan 31 21:06
    sjrd closed #3554
  • Jan 31 20:54
    erikvanoosten commented #2665
  • Jan 31 16:33
    sjrd commented #3538
  • Jan 31 15:54

    sjrd on master

    Fix analyzer cycle detection to… Add toString methods to analyze… Do not provide linked ClassInfo… and 1 more (compare)

  • Jan 31 15:54
    sjrd closed #3552
  • Jan 31 15:54

    sjrd on master

    Remove Logger.success It is un… Make level helpers final Clean-up ScalaConsoleLogger cod… and 1 more (compare)

  • Jan 31 15:54
    sjrd closed #3553
  • Jan 31 15:33
    sjrd commented #2665
  • Jan 31 15:30
    erikvanoosten commented #2665
  • Jan 31 10:41
    sjrd review_requested #3554
  • Jan 31 10:41
    sjrd opened #3554
  • Jan 31 10:05
    gzm0 synchronize #3552
Eric K Richardson
@ekrich
I am not sure I understand. I didn’t make any changes and this is my first attempt to cross compile. I did add some things to support 0.6.x, is that what you are asking about?
The tests don’t touch a lot of code but ...
Sébastien Doeraene
@sjrd
Is this the sjs10rc1 branch in sconfig?
The only difference is the SCALAJS_VERSION=1.0.0-RC1?
Eric K Richardson
@ekrich
Yes, that is the one.
I was waiting for Scala-collection-compat to try it out.
Sébastien Doeraene
@sjrd
Do you have a fake implementation of URL or something like that? How come ParseableURL works in 0.6.x?
Ah yes it seems you have that.
Eric K Richardson
@ekrich
Yes, I have a fake one - let me take look.
Sébastien Doeraene
@sjrd
The problem is that your fake URL references URLConnection in the result type of a method, but URLConnection itself does not exist.
You'll have to add a fake trait URLConnection as well for this to work in 1.x.
0.6.x was too tolerant about that kind of situation.
Eric K Richardson
@ekrich
Ok, man it is late there almost 7 pm on the west coast in the US. The rabbit hole didn’t go to deep in 0.6.x. Thanks for the help, I’ll report back after I get a chance to try that out.
Sébastien Doeraene
@sjrd
Although, in a broader context, at some point you should refactor so that you don't need those fake things at all anymore. This is not a long term solution, because such a hack does not compose with another library that would have the same hack but with a different set of methods. One of the fakes would win on the classpath, and the code trying to use the other methods will fail to link.
Eric K Richardson
@ekrich
Yes, I understand. It is a large library and I have no users and no help. I can’t get any users without some support but clearly the whole library could be changed and I am trying to improve it as well. There is tons of stuff I don’t like but I would some direction and users before making major unguided changes. Certainly only the Properties method is in play for a real implementation submitted to Scala.js
@sjrd Appreciate you taking a look :smile:
Eric K Richardson
@ekrich
@sjrd Adding an empty URLConnection trait allows the library to work for 1.0.0-RC1. I would have gotten there eventually but wanted to ask first. I am hoping some people may find a use for ekrich/sconfig to parse HOCON.
Sébastien Doeraene
@sjrd
Nice :) Thanks for confirming that it solved the issue.
Eric K Richardson
@ekrich
@sjrd I actually had to add and modify some stubs after all - only a few little things. The parser and tokenizer have references to FileInputStream and URL and these should be agnostic and just taking a InputStream of some sort. Not super great abstraction.
Eric K Richardson
@ekrich
When do we expect RC2 to be online?
Eric K Richardson
@ekrich
I think I jumped the gun.
Sébastien Doeraene
@sjrd
We're going to announce it tomorrow. It's already on Maven Central.
Eric K Richardson
@ekrich
Thanks, I will try again.
Henry Ong
@1mdc
Hi, I have same error as in this ticket. Does any one have a workaround? scala-js/scala-js#3458
We released Scala.js 1.0.0-RC2, with a few bug fixes, more tests, some removal of deprecated APIs, and an important internal IR change. If no critical issue is found by the end of January 2020, this will become the final 1.0.0 release.
scalajs-bundler 0.16.0 should work out of the box with this new version. Mill 0.5.3 as well. For libraries, they will need to be republished for 1.0.0-RC2.
Robert Walker
@olofwalker
What is the status of Scala.JS and Dotty?
Sébastien Doeraene
@sjrd
Robert Walker
@olofwalker
Thanks, will take a look
Brian P. Holt
@bpholt
I'm excited about Scala.js 1.0! Re: https://twitter.com/scala_lang/status/1205570208561152000?s=12, are there instructions anywhere on how to add the RC to cross-builds? It's not obvious to me how I'd add the 0.6 and 1.0 plugins to my builds.
Eric K Richardson
@ekrich
You can look at ekrich/sconfig on github and peek at the project/plugins.sbt
then at the sbt prompt you can do SCALAJS_VERSION=1.0.0-RC2 sbt
that will set you up to play with the 1.0.0-RC2 version
Brian P. Holt
@bpholt
Yeah I was afraid it wasn't as simple as adding another kind of crossVersion :(
That's clever though, thanks for the pointer
Sébastien Doeraene
@sjrd
@bpholt There are detailed instructions at the end of the release notes of the RCs.
Marcin Szałomski
@baldram
Hi all, I have the question whether do you use the tool https://github.com/sjrd/scala-js-ts-importer or some other similar tools to get type definitions at least half-automatically done? Someone told me that the typescript language is iterating so fast and there is almost no point in making a tool like this unless you are actively maintaining it with each new TS version. I wonder what about this one? I seem to be maintained. Do you have any experience to share in this subject?
Sören Brunk
@sbrunk
@baldram have a look at https://github.com/oyvindberg/ScalablyTyped from @oyvindberg
It contains automatically generated typings for quite a lot of js libs
And it's actively maintained
Marcin Szałomski
@baldram
Thank you @sbrunk, this is a fascinating resource. I see in the description that it "generally works", so I guess they are automatically generated, and still some manual adjustment might be needed. But it's better than nothing! Additionally, it is said: "All currently published artefacts should be considered snapshots and will be deleted without notice. Expect the first stable release soon". Ok, so it's an exciting preview. I can't wait for the release ;-)
I like this project. I see there some of my needs is already done. Now I have to add the missing ones.
So I'm still interested if about the tool to convert something for myself. I wonder whether the project from @sjrd is still valid and worth considering?
Øyvind Raddum Berg
@oyvindberg
@baldram rewriting typescript is an ambitious proposition, so it won't be perfect.
It's true that typescript has been iterating at an amazing speed, but it has stabilized a lot since 3.0 (which is ages ago)
Right now I'm experimenting with alternative distribution methods, I think a final release is going to take the form of an sbt plugin instead
Also if you have any libraries you want right away I can add them to the nightly build
Marcin Szałomski
@baldram
@oyvindberg Thank you for the response. A lot of Leaflet related stuff is already there. The one "missing" is https://github.com/Asymmetrik/leaflet-d3, but I'm not sure it's something that is in your scope?
Øyvind Raddum Berg
@oyvindberg
I'll add it to the build for tomorrow so you can try. Note that the library uses module augmentation (see https://alligator.io/typescript/module-augmentation/ , essentially they type up a certain type of monkey patching), so you'll need to understand how that works. This demo demonstrates the concept for jquery and jqueryui https://github.com/oyvindberg/ScalablyTypedDemos/blob/master/jquery/src/main/scala/demo/JQueryDemo.scala
Marcin Szałomski
@baldram
Thank you @oyvindberg for your effort and that references.