scala-js/scala-js

Scala.js, the Scala to JavaScript compiler

Eric K Richardson

@ekrich

@sjrd If I do as you suggested, I run into this problem.

[error]   not found: https://repo1.maven.org/maven2/org/scala-js/scalajs-junit-test-runtime_0.27/1.2.0/scalajs-junit-test-runtime_0.27-1.2.0.pom

Sébastien Doeraene

@sjrd

For scalajs-junit-test-runtime you also need the withDottyCompat.

It's a "normal" dependency. Not a "core" dependency like dotty-library.

Eric K Richardson

@ekrich

That one comes with the .enablePlugins(ScalaJSJUnitPlugin) so not sure how to do that.

Tobias Schlatter

@gzm0

Thanks @gzm0 for the continued reviews and not getting too frustrated with me

Keep it up! Thank you for your contributions.

Sébastien Doeraene

@sjrd

Oh right.

I don't think ScalaJSJUnitPlugin is ready to deal to dotty.

You'll have to do its config by hand instead.

For dotty it's really just a matter of

libraryDependencies += "org.scala-js" %% "scalajs-junit-test-runtime" % scalaJSVersion  % "test" withDottyCompat()

Eric K Richardson

@ekrich

I think that is working - will there have to be the compiler plugin etc for Scala 2?

Sébastien Doeraene

@sjrd

Yes, for Scala 2 you need the compiler plugin.

In dotty I forcefully put the compiler plugin for JUnit inside the main compiler, because it was easier. But I'd like to pull it out when I get the chance.

Eric K Richardson

@ekrich

Ok, thanks. I'll let you know when I get it working.

Eric K Richardson

@ekrich

Any idea what this might mean? [error] Assignment to static member org.ekrich.config.ConfigSyntax.JSON not supported

It is an enum

Sébastien Doeraene

@sjrd

Probably a bug ;)

We haven't really tested enums with the JS support.

Feel free to file an issue on the lampepfl/dotty repo.

Eric K Richardson

@ekrich

Ok, I will thanks.

Eric K Richardson

@ekrich

FYI - lampepfl/dotty#9809

Sébastien Doeraene

@sjrd

Thanks :)

Matt Hughes

@matthughes

My project is on 2.13.3 / scalajs 1.1.1. All I changed was scalajs version to 1.2.0 and sbt fails to load with:

[error] sbt.librarymanagement.ResolveException: Error downloading org.scala-js:sbt-scalajs;sbtVersion=1.0;scalaVersion=2.12:1.2.0

I don’t get where it’s getting 2.12 from.

Running SBT 1.3.13

Eric K Richardson

@ekrich

Sometimes that is sporactic - you might try again.

nafg

@nafg

Apologies if I've said this before, it would be nice if all of the amazing dead code elimination logic in scala.js could also be leveraged to tell me what in my codebase is dead code

Bonus points if that could be run on JVM code, but even if it was just logged from what scala.js is doing anyway

Nikita Gazarov

@raquo

@nafg not exactly what you're asking for, but the pointers here can indirectly give you some class usage info: scala-js/scala-js#3556

João Costa

@JD557

that might be the case, I'll try to run some local benchmarks later. Thanks :)

Update on this: Turns out that Firefox struggles a lot with multiple flatMaps and the ES 5.1 is indeed faster than the ES 2015 (in FF). Here's the code that I used, in case anyone wants to try to replicate the results: https://gist.github.com/JD557/3acf3d426c21f66fd9e8e25ab21813fe

Eric K Richardson

@ekrich

@sjrd I haven't been able to get the ScalaJSJUnitPlugin configured manually. Seth was trying to help me over in sbt/sbt. His suggestion with compilerPlugin adds the dependency but I am not sure what else is needed. I tried setting autoCompilerPlugins := true but that didn't help.

Eric Peters

@er1c

Is there any way to cancel the older pushes of #4169 https://scala-webapps.epfl.ch/sjsjenkins/blue/organizations/jenkins/scalajs-main/activity

Eric Peters

@er1c

@sjrd did you have an opinion on adding the sbt scalastyle alias verses just using the one I created (scalastyleCheck) for https://github.com/scala-js/scala-js/pull/4169/files/9daaa5ca88bc9bdf9ef691659b9b555b70674478#diff-fdc3abdfd754eeb24090dbd90aeec2ce ?

my muscle memory is to type sbt scalastyle which is where that is coming from

Eric Peters

@er1c

:+1: thanks for responding, updated PR - just trying to push them through so I don't forget about em :)

Eric Peters

@er1c

@sjrd no issues with the scalastyleCheck after merge?

Alexis Hernandez

@AlexITC

what can anyone recommend for rendering charts with sjs? I have saw some wrappers over js libraries, but they are outdated, and there is no sjs 1.0.0 support

Sébastien Doeraene

@sjrd

@er1c apparently not ;)

aappddeevv

@aappddeevv

Where do you want to render it and to what output format?

Alexis Hernandez

@AlexITC

Just a webpage, a simple bar chart, there are many js libraries but I haven't found any upgraded facade

Gábor Bakos

@aborg0

@AlexITC check out https://scalablytyped.org/docs/readme.html (I have a working demo with SJS 1 and chart.js, it was working with plot.ly too. https://github.com/aborg0/oeis-series)

1 reply

Øyvind Raddum Berg

@oyvindberg

@AlexITC If you don't mind some react in there I found nivo pretty awesome, check the demo at https://github.com/ScalablyTyped/SlinkyDemos

1 reply

kerr

@hepin1989

@aborg0 does scalablytyped generate from d.ts?

Gábor Bakos

@aborg0

Yes, that's how it works. You specify the npmDependencies for the .d.ts and the actual .js and from the .ts it generates Scala sources.

Robert Walker

@olofwalker

ScalablyTyped is an amazing project, try it out!

kerr

@hepin1989

@aborg0 Thanks, at work I have to use https://github.com/alibaba/ice, which is current go with typescript :(

Gábor Bakos

@aborg0

@hepin1989 That should not be an issue if the .ts files are bundled in the npm package. (Though I haven't tried. @oyvindberg probably can confirm whether that usecase is supported or not.)

Øyvind Raddum Berg

@oyvindberg

It doesn't accept .ts files, but if that's what you receive you could always run the typescript compiler with --declaration and have it generate the .d.ts files for you

Stuart Schmukler

@sasconsul

I am having problems with the tutorial's step 1, the command "npm install source-map-support" fails because there was no package.json generated by the sbt run. Here is the transcript:
webapp % npm install source-map-support
npm WARN saveError ENOENT: no such file or directory, open '/Users/sasconsul/devenv/github/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/Users/sasconsul/devenv/github/package.json'
npm WARN github No description
npm WARN github No repository field.
npm WARN github No README data
npm WARN github No license field.

source-map-support@0.5.19
updated 1 package and audited 212 packages in 0.702s

1 package is looking for funding
run npm fund for details

found 23 vulnerabilities (19 low, 4 high)
run npm audit fix to fix them, or npm audit for detail

trepidacious

@trepidacious

@sasconsul Maybe npm init first? That said, you often don't need to have a package.json in scala-js, generally a plugin will handle that kind of thing for you, e.g. with npmDependencies and sbt-scalajs-bundler

Sébastien Doeraene

@sjrd

Those were only warnings. The command succeeded.

Where communities thrive

People

Repo info

Activity