Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 08 20:43
    @sjrd banned @sw7240614
  • Sep 29 2019 08:35
    @sjrd banned @8bitpitRBX_twitter
  • May 23 2019 13:44
    @sjrd banned @BIGCRYPTO001_gitlab
  • May 01 2019 14:31
    @sjrd banned @Certificates1_gitlab
  • Apr 22 2019 15:31
    @sjrd banned @lerbatax
  • Jan 31 2019 23:04
    sjrd commented #3555
  • Jan 31 2019 22:56
    sjrd review_requested #3555
  • Jan 31 2019 22:56
    sjrd opened #3555
  • Jan 31 2019 21:06

    sjrd on 0.6.x

    Remove dead code: specific coll… Adapt the signature of `js.Arra… Merge pull request #3554 from s… (compare)

  • Jan 31 2019 21:06
    sjrd closed #3554
  • Jan 31 2019 20:54
    erikvanoosten commented #2665
  • Jan 31 2019 16:33
    sjrd commented #3538
  • Jan 31 2019 15:54

    sjrd on master

    Fix analyzer cycle detection to… Add toString methods to analyze… Do not provide linked ClassInfo… and 1 more (compare)

  • Jan 31 2019 15:54
    sjrd closed #3552
  • Jan 31 2019 15:54

    sjrd on master

    Remove Logger.success It is un… Make level helpers final Clean-up ScalaConsoleLogger cod… and 1 more (compare)

  • Jan 31 2019 15:54
    sjrd closed #3553
  • Jan 31 2019 15:33
    sjrd commented #2665
  • Jan 31 2019 15:30
    erikvanoosten commented #2665
  • Jan 31 2019 10:41
    sjrd review_requested #3554
  • Jan 31 2019 10:41
    sjrd opened #3554
Eric Peters
@er1c
@sjrd think I got the UnicodeBlock PR updated, but I'll let you review, thanks!
Eric Peters
@er1c
I tried to make the best out of a slight mess from the aliases the JVM has
Eric K Richardson
@ekrich
Ok, I think it was partly due to default Scala.js 0.6.x but I still get this [error] not found: https://repo1.maven.org/maven2/ch/epfl/lamp/dotty-library_sjs1_2.13/0.27.0-RC1/dotty-library_sjs1_2.13-0.27.0-RC1.pom
Eric K Richardson
@ekrich
Was trying to find a good reason to EOL 0.6.x. Thanks @sjrd. I think we found the problem in the Dotty channel. It may have to do with the order you mention in the code and only pertain to cross projects as the Scala.js plugin is not added explicitly.
Sébastien Doeraene
@sjrd
Hum indeed applying withDottyCompat on all dependencies won't work, since that also affects the dependency on the Scala.js version of the dotty library, for which that's not the right thing to do.
You should only apply it to the dependencies that you introduce.
Eric Peters
@er1c
@sjrd you made a comment about the test failure, so I'll fix that for the UnicodeBlock, but did the updated approach match what you were expecting?
Sébastien Doeraene
@sjrd
Yes, overall it seems to be the correct approach. I will do a detailed review later.
Eric Peters
@er1c
ok, just wanted to make sure the "guts" looked correct first
thank you!
I'll flag it again after CI is passing
Yeah! scala-js/scala-js#4175 got merged, and in half the time of my last PR, hopefully an indication of me learning :)
Thanks @gzm0 for the continued reviews and not getting too frustrated with me
Sébastien Doeraene
@sjrd
:)
Eric K Richardson
@ekrich
@sjrd If I do as you suggested, I run into this problem. [error] not found: https://repo1.maven.org/maven2/org/scala-js/scalajs-junit-test-runtime_0.27/1.2.0/scalajs-junit-test-runtime_0.27-1.2.0.pom
Sébastien Doeraene
@sjrd
For scalajs-junit-test-runtime you also need the withDottyCompat.
It's a "normal" dependency. Not a "core" dependency like dotty-library.
Eric K Richardson
@ekrich
That one comes with the .enablePlugins(ScalaJSJUnitPlugin) so not sure how to do that.
Tobias Schlatter
@gzm0

Thanks @gzm0 for the continued reviews and not getting too frustrated with me

Keep it up! Thank you for your contributions.

Sébastien Doeraene
@sjrd
Oh right.
I don't think ScalaJSJUnitPlugin is ready to deal to dotty.
You'll have to do its config by hand instead.
For dotty it's really just a matter of
libraryDependencies += "org.scala-js" %% "scalajs-junit-test-runtime" % scalaJSVersion  % "test" withDottyCompat()
Eric K Richardson
@ekrich
I think that is working - will there have to be the compiler plugin etc for Scala 2?
Sébastien Doeraene
@sjrd
Yes, for Scala 2 you need the compiler plugin.
In dotty I forcefully put the compiler plugin for JUnit inside the main compiler, because it was easier. But I'd like to pull it out when I get the chance.
Eric K Richardson
@ekrich
Ok, thanks. I'll let you know when I get it working.
Eric K Richardson
@ekrich
Any idea what this might mean? [error] Assignment to static member org.ekrich.config.ConfigSyntax.JSON not supported
It is an enum
Sébastien Doeraene
@sjrd
Probably a bug ;)
We haven't really tested enums with the JS support.
Feel free to file an issue on the lampepfl/dotty repo.
Eric K Richardson
@ekrich
Ok, I will thanks.
Eric K Richardson
@ekrich
Sébastien Doeraene
@sjrd
Thanks :)
Matt Hughes
@matthughes

My project is on 2.13.3 / scalajs 1.1.1. All I changed was scalajs version to 1.2.0 and sbt fails to load with:

[error] sbt.librarymanagement.ResolveException: Error downloading org.scala-js:sbt-scalajs;sbtVersion=1.0;scalaVersion=2.12:1.2.0

I don’t get where it’s getting 2.12 from.

Running SBT 1.3.13
Eric K Richardson
@ekrich
Sometimes that is sporactic - you might try again.
nafg
@nafg
Apologies if I've said this before, it would be nice if all of the amazing dead code elimination logic in scala.js could also be leveraged to tell me what in my codebase is dead code
Bonus points if that could be run on JVM code, but even if it was just logged from what scala.js is doing anyway
Nikita Gazarov
@raquo
@nafg not exactly what you're asking for, but the pointers here can indirectly give you some class usage info: scala-js/scala-js#3556
João Costa
@JD557

that might be the case, I'll try to run some local benchmarks later. Thanks :)

Update on this: Turns out that Firefox struggles a lot with multiple flatMaps and the ES 5.1 is indeed faster than the ES 2015 (in FF). Here's the code that I used, in case anyone wants to try to replicate the results: https://gist.github.com/JD557/3acf3d426c21f66fd9e8e25ab21813fe

Eric K Richardson
@ekrich
@sjrd I haven't been able to get the ScalaJSJUnitPlugin configured manually. Seth was trying to help me over in sbt/sbt. His suggestion with compilerPlugin adds the dependency but I am not sure what else is needed. I tried setting autoCompilerPlugins := true but that didn't help.
Eric Peters
@er1c
Eric Peters
@er1c
@sjrd did you have an opinion on adding the sbt scalastyle alias verses just using the one I created (scalastyleCheck) for https://github.com/scala-js/scala-js/pull/4169/files/9daaa5ca88bc9bdf9ef691659b9b555b70674478#diff-fdc3abdfd754eeb24090dbd90aeec2ce ?
my muscle memory is to type sbt scalastyle which is where that is coming from
Eric Peters
@er1c
:+1: thanks for responding, updated PR - just trying to push them through so I don't forget about em :)
Eric Peters
@er1c
@sjrd no issues with the scalastyleCheck after merge?
Alexis Hernandez
@AlexITC
what can anyone recommend for rendering charts with sjs? I have saw some wrappers over js libraries, but they are outdated, and there is no sjs 1.0.0 support