errikos on master
Fix runtime/tests with disabled… (compare)
sjrd on master
Update to Scala Native 0.4.0-M2… (compare)
modPowand this sort of things and each couple of hours dumps a new value.
re: Any milestone to release M3 [I'm asking to understand how many time have I got to finish biginteger]?
I am an individual contributor, not a ScalaCenter person, I think the answer would be "Reasonably correct is better than fast". The past few months, the scala-contributors Discourse has had updates from ScalaCenter and some brief discussion of futures. I find that quite useful.
Now that JUnit test support is in, there may be a request that you/I/we convert the BigIntegerSuite.scala to JUnit. I just took a look at it: recognized the fingerprints on some, did not run
git blame on rest (he says as he scurries for a fig leaf).
Would it be easier for you if I created a PR which just converted the existing tests to JUnit so that you could add your new tests using a model or are you more comfortable with the SN historical test idiom. My goal/intention is to ease your contribution (and save you time.)
git diff c6b075366b70 -- shared/src/main/scala/ky/korins/math | diffstat BigInteger.scala | 297 ++++++++++++++++++++++++---------- BitLevel.scala | 8 Conversion.scala | 27 +-- Division.scala | 445 +++++++++++++++++++++++++++++++++++++++++++-------- Elementary.scala | 2 Multiplication.scala | 82 ++++----- Primality.scala | 250 +++++++++++++++++++++------- 7 files changed, 842 insertions(+), 269 deletions(-)
Ah, that code is in shared/src/main. I don't think there is any need to 'move it back'. Sorry that I was not clear, I meant to be talking about test cases, especially for that number of changes (which is good to see). Currently unit-tests/mumble/BigInteger.scala provides a small set of test cases. That was written to the historical SN test Interface.
You mentioned having scalatest unit tests? Some or all of those are what you/I/we could port to a unit-tests/mumble/BigIntegerTest.scala (as JUnit). If they have to come out of scalatest, might as well go straight to Junit rather than pausing with the historical test idiom, IMHO.