Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 21:05
    LeeTibbert synchronize #2054
  • 17:52
    LeeTibbert edited #2056
  • 17:48
    LeeTibbert opened #2056
  • 15:15
    sjrd commented #2055
  • 14:46
    LeeTibbert opened #2055
  • 02:08
    LeeTibbert opened #2054
  • Dec 04 19:34
    WojciechMazur commented #1982
  • Dec 04 19:28
    WojciechMazur commented #1982
  • Dec 04 19:26
    WojciechMazur closed #1982
  • Dec 04 19:25
    WojciechMazur commented #1982
  • Dec 04 19:17
    WojciechMazur synchronize #1982
  • Dec 04 19:12
    WojciechMazur synchronize #1982
  • Dec 04 19:06
    WojciechMazur review_requested #1949
  • Dec 04 19:05
    WojciechMazur synchronize #1949
  • Dec 04 18:38
    WojciechMazur synchronize #1984
  • Dec 04 18:38

    WojciechMazur on 805_bring_main_into_scope_from_class

    Added responds field to ScopeIn… Reach.lookup would try to find … Generate.genMain uses method in… and 6 more (compare)

  • Dec 04 18:22
    WojciechMazur review_requested #2046
  • Dec 04 18:19
    WojciechMazur review_requested #2051
  • Dec 04 18:18
    WojciechMazur review_requested #2053
  • Dec 04 18:17
    WojciechMazur synchronize #2046
Kirill A. Korinsky
@catap
[sorry, I read it to 10.14.6]
Eric K Richardson
@ekrich
oh, yes the next version could be ok but the new one, there is no way
Kirill A. Korinsky
@catap
ok, let make it on this way
the next task to compile my application to this device :)
Eric K Richardson
@ekrich
So if we have the changes in the PR plus a way to set target triple that should be at least a start. then we can see what needs to be done next.
Kirill A. Korinsky
@catap
I do have only one idea: let make your PR as smaller as possibly
I saw this code and it is very complicated to don't start to improve it
Maybe finish it on e237c0f?

The next commit looks like a refactoring, and if you start doing so, I expect that it should also remove all IO.copy... and return from function a list of produced objects.

I did it at some point, but I defently can miss something.

Plus, as you said a few days ago => it is a bit overscope of this PR and such huge changes make everyone scary :)
Eric K Richardson
@ekrich
I think what you did is fine - I have worked extensively recently on the tools and the small changes passing the Path around is good - I'll push the latest so you can see.
I kept target triple and I will use the PR by Lorenzo as a guide.
You will like the partition I did.
Kirill A. Korinsky
@catap
yes, it is very similar to one of my branches :)
Eric K Richardson
@ekrich
I got scared off - we can change the plugin to targetTriple but everything starts with native so I will start with the way it is. Minimal is good but like I said, the changes you added to streamline are just too good to avoid and make the code much more readable.
I just got really scared off by removing targetTriple completely. I'll push the plugin stuff tomorrow and change from draft to get review.
Sorry I kind of took over.
João Costa
@JD557
a bit off-topic: What's the plan for the next release of scala-native? Will there be a 0.4.0-M3 or will it go straight to 0.4.0?
(I'm not sure if I asked this here before, I'm having a feeling of "deja vu"... sorry if this is a repeated question)
Wojciech Mazur
@WojciechMazur
Hey, probably it would be M3. There as still some things that should be included in 0.4.0, but I wish we could publish 2.12 and 2.13 support ASAP
João Costa
@JD557
:+1: that's exactly what I was expecting, thanks
Kirill A. Korinsky
@catap
@WojciechMazur any ETA?
Wojciech Mazur
@WojciechMazur
not really. It should be out before the end of the year. I don't want to give some fixed day right now
Kirill A. Korinsky
@catap
(checking calendar) before the end of the year it is very soon. Thanks!
Shubham Kamthania
@ikamthania
Hi I am trying to compile the latest master. Getting this error
/git/scala-native/scalalib/target/scalaSources/2.12.12/scala/collection/mutable/StringBuilder.scala:34:13: overriding method isEmpty in trait CharSequence of type ()Boolean;
[error]  method isEmpty in trait IndexedSeqOptimized of type => Boolean cannot override a concrete member without a third member that's overridden by both (this rule is designed to prevent ``accidental overrides'')
[error] final class StringBuilder(private val underlying: JavaStringBuilder)
[error]             ^
[error] one error found
[error] (scalalib / Compile / compileIncremental) Compilation failed
How can I get around this ?
Sébastien Doeraene
@sjrd
You're probably trying to build on JDK 15, which Scala 2.12.12 does not really support.
You'll need to downgrade to JDK 14 at most.
Shubham Kamthania
@ikamthania
oh ok. Thanks
Sébastien Doeraene
@sjrd
Our reference version is still JDK 8.
Shubham Kamthania
@ikamthania
:thumbsup:
Eric K Richardson
@ekrich
I am having problems with 2.12 on master, tests/test will not complete. I will try clean but just asking for now.
SHA 920bd845
Eric K Richardson
@ekrich
Seems ok after clean - still getting lack of completion on macOS.
Kirill A. Korinsky
@catap
A bit of offtopic but maybe @ekrich know. Do you know any library to serialize Map[String, Any] to json at scala native?
Any is String, Int, Map[String, Any] and maybe a few custom types that support toMap(): Map[String, Any]
Anton Sviridov
@keynmol
upickle works on scala native. You'll probably need to convince it to serialise Any by manually overriding an implicit, but it should work
Kirill A. Korinsky
@catap
@keynmol thanks!
Anton Sviridov
@keynmol

On 0.4.0-M2 I get linking errors relating to scala.Enumeration:

[info] Linking (1762 ms)
[error] missing symbols:
[error] * M15java.lang.ClassD10getMethodsLAL24java.lang.reflect.Method_E
[error]   - from M17scala.EnumerationD34scala$Enumeration$$populateNameMapuE
[error]   - from M54scala.Enumeration$$anonfun$scala$Enumeration$$nameOf$1D5applyL16java.lang.StringE
[error]   - from M54scala.Enumeration$$anonfun$scala$Enumeration$$nameOf$1D5applyL16java.lang.ObjectE
[error]   - from M17scala.EnumerationD25scala$Enumeration$$nameOfiL16java.lang.StringE
[error]   - from M21scala.Enumeration$ValD8toStringL16java.lang.StringE
[error]   - from M17scala.EnumerationD5ValueiL16java.lang.StringL23scala.Enumeration$ValueE
[error]   - from M35scala.math.BigDecimal$RoundingMode$RE
[error]   - from M20squants.market.MoneyD17toFormattedStringL16java.lang.StringE
[error]   - from M20squants.market.MoneyD17toFormattedStringL23squants.market.CurrencyL27squants.market.MoneyContextL16java.lang.StringE
[error]   - from M36squants.market.MoneySpec$$anonfun$53D5applyL34org.scalatest.compatible.AssertionE
[error]   - from M36squants.market.MoneySpec$$anonfun$53D5applyL16java.lang.ObjectE
[error]   - from M24squants.market.MoneySpecRE
[error]   - from M41scala.scalanative.testinterface.TestMain$RE

I couldn't find an issue on github, is this something that is merged but not released, or something that is a new problem?

Wojciech Mazur
@WojciechMazur
It's a bug and not yet fixed. Thank you for spotting this out. It would be fixed in next release!
Eric K Richardson
@ekrich
Are those methods going to be implemented?
Wojciech Mazur
@WojciechMazur
@ekrich not really, for some reason we have not overriden Enumeration like Scala.js did. Default Scala implementation used reflection (same as in overriden Arrays) resulting in mssing symbols
Anton Sviridov
@keynmol
So it's a matter of in-sourcing Scala.js's implementation? I think Lee has a script for that :D
Eric K Richardson
@ekrich
@WojciechMazur Thanks, I thought that was too much reflection - I'll take a look at the overrides to understand better.
Sébastien Doeraene
@sjrd
In Scala.js there is an override, but more importantly there is code in the compiler plugin to rewrite stuff not to use reflection. I don't recommend porting this at this stage. I did not implement it in the support of Scala.js in Scala 3.
Eric K Richardson
@ekrich
@keynmol Did you try? nativeLinkStubs := true
Eric K Richardson
@ekrich
If you are trying to port something that uses a few enums, you could try an approach like this seen in sharedScala2 and sharedScala3 and some stuff in the build so that it will work in JVM/JS/Native.
Eric K Richardson
@ekrich
FYI, scala-collection-compat now works and should be ready for update soon after release. This will come in handy for downstream projects now that we are cross build for Scala. scala/scala-collection-compat#387
Not green as it uses 0.4.0-SNAPSHOT