Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 02 21:46
    fthomas commented #2388
  • Dec 02 21:40
    daddykotex commented #2388
  • Dec 02 21:20
    fthomas commented #2388
  • Dec 02 07:53

    mergify[bot] on master

    Update sbt-github-actions to 0.… (compare)

  • Dec 02 07:53
    mergify[bot] closed #2393
  • Dec 02 07:51
    codecov[bot] commented #2393
  • Dec 02 07:51
    codecov[bot] commented #2393
  • Dec 02 07:51
    fthomas milestoned #2393
  • Dec 02 07:50
    codecov[bot] commented #2393
  • Dec 02 07:49
    codecov[bot] commented #2393
  • Dec 02 07:44
    mergify[bot] labeled #2393
  • Dec 02 07:44
    mergify[bot] assigned #2393
  • Dec 02 07:43
    scala-steward opened #2393
  • Dec 01 23:25
    fthomas milestoned #2391
  • Dec 01 23:24
    fthomas labeled #2392
  • Dec 01 23:24

    fthomas on master

    ci(Mergify): configuration upda… Merge pull request #2392 from s… (compare)

  • Dec 01 23:24
    fthomas closed #2392
  • Dec 01 23:18
    codecov[bot] commented #2392
  • Dec 01 23:07
    fthomas opened #2392
  • Dec 01 23:07

    fthomas on fthomas

    ci(Mergify): configuration upda… (compare)

KashpirRoman
@KomaRash
@fthomas Thant's work, thanks!
Kilic Ali-Firat
@alifirat
Hey @fthomas I have a question regarding a setup that I'm doing on a private repository. There is one argument that we should provide which is the workspace location. Is this workspace should be persist somehwere (on disk? on S3?). The way I'm doing the setup is to have a k8s cronjob that will run steward every week so between each run, should I persist the worskpace?
Frank Thomas
@fthomas
@alifirat I think this question is answered in the documentation.
1 reply
KashpirRoman
@KomaRash
Hello, @fthomas!
Why scala-steward bot doesn't have configuration with PR reviewer list?
This feature minor and look like very useful.
Denis Mikhaylov
@notxcain
Hi there! Is there some kind of dry run?
Frank Thomas
@fthomas
@notxcain Something like that: scala-steward-org/scala-steward#1828
Denis Mikhaylov
@notxcain
Thanks, that should work
KashpirRoman
@KomaRash
Hello, @fthomas!
Did you see my question? Please, give me feedback about this function. I would like write this feature if you agree with its.
Kilic Ali-Firat
@alifirat
Hey @fthomas small question : I have able to successfully run Steward on a private repository (and a different branch, such a nice feature!) but it created like 15 PRs : one by update. Is it a way to group the updates into a single PR ? Thanks!
4 replies
Kilic Ali-Firat
@alifirat

Hey @KomaRash I just notice a fun thing. I had the same issue than you : Steward was like doing nothing, like the repos.md file was empty but it wasn't the case. The issue was on my side about the format. Basically the repos file md was dynamically generated and instead to write :

  • owner/repo1
  • owner/repo2
    I had :
    -owner/repo1 (no space between owner and -)
    -owner/repo2 (same)

So the function parsing each repo was returning nothing and in case it's pretty evident that Steward has nothing to do. I don't know what do you think about that @fthomas ? Should we keep this behaviour (respecting the format) or changing the regex to authorize the cases like I've met during my setup ?

3 replies
Kilic Ali-Firat
@alifirat
Hey @fthomas just a small question about a PR open by Steward and closed by me. I've clean the workspace (starting with an empty) one but on the next run it still see that the PR for this update was closed so I have 2 questions :
1 - Is it way on the next run to avoid this behaviour (to not see the PR is already closed and reopen a new one).
2 - If I reopen the PR myself, is it going to work if I merge myself the PR for the next upgrades of the library mention in the PR (for example I open a PR for toto from 0.1 -> 0.2, I closed the PR and then reopened it to merge it and the next time there is the version 0.3 available it will work ?)
Frank Thomas
@fthomas
2) Yes. 1) If you can delete the fork your Scala Steward user created or delete the PR, then it will recreate it.
1 reply
Kilic Ali-Firat
@alifirat
hey @fthomas small question about the settings updates.limit = 5 is it a global for all the repos and limited by repo ?
Frank Thomas
@fthomas
It is local
Tamer Abdulradi
@tabdulradi
Hey all 👋 Did any one build an sbt plugin version of Scala Steward? Like sbt-updates but it also modifies build.sbt and applies any scalafix rules automatically so that all I have to do is git commit and push?
Frank Thomas
@fthomas
Hi @tabdulradi! Not that I'm aware of but we have a ticket about that: scala-steward-org/scala-steward#1078
Tamer Abdulradi
@tabdulradi
Thanks! Also thanks for the indirect link to scala-cli!
Frank Thomas
@fthomas
I'm not sure if it would include a local Scala Steward in the future. From what I've read in https://github.com/VirtusLab/scala-cli/discussions/279 it sounds to me that an update command is out-of-scope for scala-cli
martijn.hoekstra.zivver
@martijn.hoekstra.zivver:matrix.org
[m]
I'm trying to run scala steward, and it's giving an error "repo <reponame> has no parent". Does anyone know off-hand what parent it is talking about, or even how to fix?
Frank Thomas
@fthomas
@martijn.hoekstra.zivver:matrix.org Sounds to me that you need to run Scala Steward with --do-not-fork.
martijn.hoekstra.zivver
@martijn.hoekstra.zivver:matrix.org
[m]
I'll give that a go, thanks @fthomas
martijn.hoekstra.zivver
@martijn.hoekstra.zivver:matrix.org
[m]
yes, that was totally it, thanks
Johannes Rudolph
@jrudolph
It seems Scala steward stopped working for akka-http quite a while ago, the last PR seems to be from March. Can I debug somehow what's going on?
Frank Thomas
@fthomas
@jrudolph The logs are not public. There is an error when Scala Steward tries to load the build:
[info] loading settings for project akka-http-root from build.sbt ...
[info] resolving key references (32954 settings) ...
[info] Building Akka HTTP 10.2.7+0-df3dbfbb+20211104-0003-SNAPSHOT against Akka 2.5.32 on Scala 2.13.6
[info] set current project to akka-http-root (in build file:~/workspace/repos/akka/akka-http/)
java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters: ~/workspace/repos/akka/akka-http/akka-http-tests/lib/i have sp?ces.jar
  at java.base/sun.nio.fs.UnixPath.encode(UnixPath.java:145)
  at java.base/sun.nio.fs.UnixPath.<init>(UnixPath.java:69)
  at java.base/sun.nio.fs.UnixFileSystem.getPath(UnixFileSystem.java:279)
  at java.base/java.nio.file.Path.of(Path.java:147)
  at java.base/java.nio.file.Paths.get(Paths.java:69)
  at com.swoval.files.SimpleFileTreeView$Lister.impl(SimpleFileTreeView.java:168)
  at com.swoval.files.SimpleFileTreeView$Lister.fillResults(SimpleFileTreeView.java:140)
  at com.swoval.files.SimpleFileTreeView.list(SimpleFileTreeView.java:50)
  at com.swoval.files.CachedDirectoryImpl.init(CachedDirectoryImpl.java:568)
  at com.swoval.files.CachedDirectoryImpl.init(CachedDirectoryImpl.java:557)
  at com.swoval.files.CachedDirectoryImpl.init(CachedDirectoryImpl.java:580)
  at com.swoval.files.CachedDirectoryImpl.init(CachedDirectoryImpl.java:557)
  at com.swoval.files.CachedDirectoryImpl.addDirectory(CachedDirectoryImpl.java:295)
  at com.swoval.files.CachedDirectoryImpl.updateImpl(CachedDirectoryImpl.java:407)
  at com.swoval.files.CachedDirectoryImpl.update(CachedDirectoryImpl.java:242)
  at com.swoval.files.NioPathWatcher.update(NioPathWatcher.java:354)
  at com.swoval.files.NioPathWatcher.register(NioPathWatcher.java:201)
  at com.swoval.files.FileCacheDirectoryTree.register(FileCacheDirectoryTree.java:417)
  at com.swoval.files.FileCachePathWatcher.register(FileCachePathWatcher.java:24)
  at com.swoval.files.FileTreeRepositoryImpl.register(FileTreeRepositoryImpl.java:101)
  at sbt.internal.nio.FileTreeRepositoryImpl.register(FileTreeRepositoryImpl.scala:130)
  at sbt.internal.nio.CheckBuildSources.$anonfun$reset$3(CheckBuildSources.scala:78)
  at sbt.internal.nio.CheckBuildSources.$anonfun$reset$3$adapted(CheckBuildSources.scala:78)
  at scala.collection.immutable.List.foreach(List.scala:431)
  at sbt.internal.nio.CheckBuildSources.sbt$internal$nio$CheckBuildSources$$reset(CheckBuildSources.scala:78)
  at sbt.internal.nio.CheckBuildSources$.init(CheckBuildSources.scala:185)
  at sbt.BuiltinCommands$.doLoadProject(Main.scala:980)
  at sbt.BuiltinCommands$.$anonfun$loadProjectImpl$2(Main.scala:912)
  at sbt.Command$.$anonfun$applyEffect$4(Command.scala:150)
  at sbt.Command$.$anonfun$applyEffect$2(Command.scala:145)
  at sbt.Command$.process(Command.scala:189)
  at sbt.MainLoop$.$anonfun$processCommand$5(MainLoop.scala:245)
...
Johannes Rudolph
@jrudolph
ah, great our extended Unicode testing...
Is it running in an alpine Docker container?
Frank Thomas
@fthomas
No, it is plain Ubuntu machine.
Johannes Rudolph
@jrudolph
I once looked into that and it depends on the setting of the sun.jnu.encoding property whether paths are correctly decoded
However, it could also be that some component already messed up the path before Java is even run
maybe we should try to hide that file somewhere to make sure it's not tripping up dev machines
But anyway, thanks, @fthomas, I see if we can avoid that file.
ex0ns
@ex0ns
Hello ! I've added two repositories to the scala-steward list, but it seems that only one of them was updated properly, is there a way to see if something wrong happened with the other one ? (bot4s/zmatrix)
Frank Thomas
@fthomas

@ex0ns There was indeed an error while loading the build:

mill -i -p ~/workspace/repos/bot4s/zmatrix/scala-steward.sc show org.scalasteward.mill.plugin.StewardPlugin/extractDeps' exited with code 1
Preparing Java 11.0.10 runtime; this may take a minute or two ...
Compiling ~/workspace/repos/bot4s/zmatrix/scala-steward.sc
Compiling ~/workspace/repos/bot4s/zmatrix/build.sc
[1/1] show 
Exception in thread \"main\" java.lang.NoSuchMethodError: 'boolean mainargs.arg$.$lessinit$greater$default$5()'
  at org.scalasteward.mill.plugin.StewardPlugin$.$anonfun$millDiscover$1(StewardPlugin.scala:70)
  at org.scalasteward.mill.plugin.StewardPlugin$.millDiscover$lzycompute(StewardPlugin.scala:70)
  at org.scalasteward.mill.plugin.StewardPlugin$.millDiscover(StewardPlugin.scala:70)
  at mill.main.RunScript$.$anonfun$resolveTasks$4(RunScript.scala:145)
  at scala.util.Either.map(Either.scala:382)
  at mill.main.RunScript$.$anonfun$resolveTasks$3(RunScript.scala:134)
  at scala.collection.immutable.List.map(List.scala:246)
  at mill.main.RunScript$.$anonfun$resolveTasks$2(RunScript.scala:133)
  at scala.util.Either.flatMap(Either.scala:352)
  at mill.main.RunScript$.resolveTasks(RunScript.scala:130)
  at mill.main.RunScript$.evaluateTasks(RunScript.scala:187)
  at mill.main.MainModule$.evaluateTasks(MainModule.scala:20)
  at mill.main.MainModule.$anonfun$show$1(MainModule.scala:203)
  at mill.define.Applicative$Applyer.$anonfun$zipMap$1(Applicative.scala:35)
  at mill.define.Task$MappedDest.evaluate(Task.scala:391)
  at mill.eval.Evaluator.$anonfun$evaluateGroup$13(Evaluator.scala:491)
  at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
  at scala.Console$.withErr(Console.scala:193)
  at mill.eval.Evaluator.$anonfun$evaluateGroup$12(Evaluator.scala:491)
  at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
  at scala.Console$.withOut(Console.scala:164)
  at mill.eval.Evaluator.$anonfun$evaluateGroup$11(Evaluator.scala:490)
  at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
  at scala.Console$.withIn(Console.scala:227)
  at mill.eval.Evaluator.$anonfun$evaluateGroup$8(Evaluator.scala:489)
  at mill.eval.Evaluator.$anonfun$evaluateGroup$8$adapted(Evaluator.scala:441)
  at scala.collection.immutable.Vector.foreach(Vector.scala:1856)
  at mill.eval.Evaluator.evaluateGroup(Evaluator.scala:441)
  at mill.eval.Evaluator.$anonfun$evaluateGroupCached$13(Evaluator.scala:343)
  at scala.util.DynamicVariable.withValue(DynamicVariable.scala:59)
  at mill.eval.Evaluator.evaluateGroupCached(Evaluator.scala:334)
  at mill.eval.Evaluator.$anonfun$sequentialEvaluate$2(Evaluator.scala:117)
  at scala.collection.IterableOnceOps.foreach(IterableOnce.scala:553)
  at scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:551)
  at scala.collection.AbstractIterator.foreach(Iterator.scala:1279)
  at mill.eval.Evaluator.sequentialEvaluate(Evaluator.scala:94)
  at mill.eval.Evaluator.evaluate(Evaluator.scala:80)
  at mill.main.RunScript$.evaluate(RunScript.scala:202)
  at mill.main.RunScript$.$anonfun$evaluateTasks$1(RunScript.scala:188)
  at scala.util.Either.map(Either.scala:382)
  at mill.main.RunScript$.evaluateTasks(RunScript.scala:187)
  at mill.main.RunScript$.$anonfun$runScript$4(RunScript.scala:66)
  at ammonite.util.Res$Success.flatMap(Res.scala:62)
  at mill.main.RunScript$.runScript(RunScript.scala:65)
  at mill.main.MainRunner.$anonfun$runScript$1(MainRunner.scala:117)
  at mill.main.MainRunner.watchLoop2(MainRunner.scala:66)
  at mill.main.MainRunner.runScript(MainRunner.scala:92)
  at mill.MillMain$.main0(MillMain.scala:215)
  at mill.MillMain$.main(MillMain.scala:83)
  at mill.MillMain.main(MillMain.scala)

Looks like a problem with the mill support in Scala Steward to me but I'm not sure.

ex0ns
@ex0ns
i'll try to update mill on my side, thanks for the logs
1 reply
Frank Thomas
@fthomas
@lefou Would it be possible to have this code in the scala-steward.sc so that it does not need to be a published plugin? I'd prefer that over cross-publishing the Mill plugin for every 0.x version.
Tobias Roeser
@lefou
@fthomas Unfortunatelly not. You could place the whole logic as trait in a .sc file, but you (currently) can't create actual modules (the objects) in included files.
Maybe, it's possible with the concept of foreign module (https://com-lihaoyi.github.io/mill/mill/Modules.html#_foreign_modules), but I haven't tried that.
In that case, it must be named build.sc in a different directory. Maybe worth a try.
Tobias Roeser
@lefou
But I'm currently not sure, if you can reach targets of foreign modules from the cli.
Kilic Ali-Firat
@alifirat
Hey @fthomas I have a small question about the internal library hosted in a private artifactory (that ask for credentials). I see one run in which Steward tried to applied some rules to rewrite some code but it failed when trying to fetch the internal library. It's like it's not going to work in a such use case right ?
By the way, is it possible to setup Steward to also look on the versions of a private library or it should be available to the public like the classical libraries?
Frank Thomas
@fthomas
@alifirat Sounds like you need provide credentials for your private artifactory: https://github.com/scala-steward-org/scala-steward/blob/master/docs/running.md#credentials-using-environment-variables
Tobias Roeser
@lefou
@fthomas Could you please have a look if the log for https://github.com/com-lihaoyi/mill contains any errors? I was expecting a PRs from @scala-steward
Frank Thomas
@fthomas

@lefou There is indeed an error while creating a PR:

2021-11-23 14:16:10,530 INFO  Create branch update/bloop-config-1.4.11
2021-11-23 14:16:18,210 ERROR Steward com-lihaoyi/mill failed
git diff --name-only main update/bloop-config-1.4.11' exited with code 128
fatal: ambiguous argument 'main': both revision and filename
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Looks like a bug in Scala Steward.

Tobias Roeser
@lefou
@fthomas Thanks for checking.
Grigory
@pomadchin

hey folks, got scala steward set for the sbt-jni project scala-steward-org/repos#862 and hit some repos namings collision (example steward PR): sbt/sbt-jni#63

I looked a bit more into it and noticed that there is the steward repo https://github.com/scala-steward/sbt-jni which is forked from the sbt-jni fork and as the result it sends PRs from the unsynced fork

Is there any workaround to this issue? Or the only solution is to rm sbt/sbt-jni repo from the steward list?

cc @fthomas (to make it more visible)

Frank Thomas
@fthomas
@pomadchin Scala Steward can only keep one of the two repos up to date. I think the best option here is to remove the fork from the repo list and reset Scala Steward's fork. I'll do that later
Grigory
@pomadchin
@fthomas thank :+1:
1 reply
heksesang
@heksenlied:matrix.org
[m]
Is it possible to run Scala Steward using an ssh-key instead of passing a password by script?
Frank Thomas
@fthomas
@heksenlied:matrix.org No, not without code changes.