Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

scalacenter/bsp

People

Repo info

Activity

Julien Richard-Foy

@julienrf

Thanks @olafurpg for the link. The “inferred implicit parameters” request is missing from this list (it is Scala-specific). Do we have a place where we discuss about Scala-specific LSP extensions?

It would be nice to bring to all Scala IDEs this very useful feature, which is currently only available in IntelliJ (and which is not using the actual compiler).

(it shows a call graph of the chained implicit definitions that have been inferred by the compiler)

Julien Richard-Foy

@julienrf

What do you think?

Ólafur Páll Geirsson

@olafurpg

@julienrf that would be a reasonable feature request in the metals repo, where we already have several lsp extensions

Julien Richard-Foy

@julienrf

@olafurpg Done! (scalameta/metals-feature-requests#60) Thanks for your guidance :)

Oops, did I just create a duplicate of scalameta/metals-feature-requests#21 (well, the feature request I’ve created has a smaller scope than this one, I would say…)

Ólafur Páll Geirsson

@olafurpg

The new ticket is good because it has more details. Thanks! @julienrf

even if this was provided via bsp then it would require a fair amount of custom work to integrate it into IntelliJ.

I estimate it’s not too hard to implement in Metals with our existing decoration infrastructure

Need someone to pull up their sleeves and do the work however...

Tomasz Pasternak

@tpasternak

I can't figure out what's broken here https://travis-ci.org/build-server-protocol/build-server-protocol/builds/647315584?utm_source=github_status&utm_medium=notification I understand the test -z $(git ls-files --modified) command is to check whether bsp4j/xtend was called by the user before commit, but on my PC it returns success

so I need to add some debug logs to .travis.yml, please don't merge it for a moment

Tomasz Pasternak

@tpasternak

OK, rebase helped

Tomasz Pasternak

@tpasternak

It seems that the release fails due to expired/invalid key https://travis-ci.org/build-server-protocol/build-server-protocol/

Ólafur Páll Geirsson

@olafurpg

@tpasternak the release should be fixed now

Tomasz Pasternak

@tpasternak

thanks :thumbsup:

Tomasz Pasternak

@tpasternak

Hi, could you trigger https://travis-ci.org/build-server-protocol/build-server-protocol/builds/655697890 once more?

Tomasz Pasternak

@tpasternak

Hi, I opened a PR with jvmRunEnvironment, which was a follow up of our discussions on jvmRunEnvironment when we decided, we want to have these two environment endpoints separate. In case if you'd like to merge them to a sigle jvmEnvironment instead, please just let me know.

build-server-protocol/build-server-protocol#116

shaurya gupta

@sureyeaah

Hi everyone! I'm investigating how a build server can be useful for Clangd (c++ language server).
How does an LSP server interact with a BSP server? Do they talk directly or does the editor somehow act as a middle agent?

Ólafur Páll Geirsson

@olafurpg

Hi @sureyeaah ! That sounds exciting. We had had a lot of success using BSP in the JVM ecosystem for Scala and Java. It would be great to see BSP used in other contexts.

The language server talks directly to the build server in our setup.

It’s still possible to implement an editor client for BSP, it depends on what your goal is.

shaurya gupta

@sureyeaah

Okay that's what I guessed.

Thanks :)

Justin Kaeser

@jastice

@sureyeaah in the case on IntelliJ, it talks directly to the BSP server

Meai1

@Meai1

this is never going to get traction if you make the main repo a java repo

the repo should be a list of REST interfaces only and then the java thing is just one of many implementations

Julien Richard-Foy

@julienrf

I think this is for similarity with the language server protocol specification: https://microsoft.github.io/language-server-protocol/specifications/specification-current/ However, I must say that I would rather see TypeScript interfaces instead of Scala interfaces, because it is not clear how Scala interfaces should be translated to JSON.

Ólafur Páll Geirsson

@olafurpg

@julienrf the spec uses typescript interfaces https://build-server-protocol.github.io/docs/specification

there's no published npm package however

Julien Richard-Foy

@julienrf

@olafurpg oops indeed, I don’t know why I thought it was using Scala interfaces, sorry!

(ah, that was the case initially, that’s why I was confused! build-server-protocol/build-server-protocol@c0a91ef )

Ólafur Páll Geirsson

@olafurpg

Yeah, I agree it's better with TypeScript interfaces since it's more widely known and also maps closer to JSON

Justin Kaeser

@jastice

good point, what would we need to do to publish the interfaces as package?

Joan Goyeau

@joan38

Hey I'm trying to make BSP work for cross compiled projects in Mill

Do you know in that case what version of Scala should we give?

It seems that when we give all versions Idea is lost

Is it ok to give only the latest version of Scala in a cross compiled project?

Joan Goyeau

@joan38

I opened https://youtrack.jetbrains.com/issue/SCL-17551 this seems to be a bug on Intellij side

Joan Goyeau

@joan38

What is the way to specify the "Excluded Folders"?

The red folders

Ólafur Páll Geirsson

@olafurpg

@joan38 There's no way to specify that in BSP at the moment. See https://discordapp.com/channels/697002009336873011/697002154702929962/700316919936450571 for a related recent discussion

I think it would be nice to add this feature to BSP

Joan Goyeau

@joan38

Thanks @olafurpg

Joan Goyeau

@joan38

What's the point of ScalaBuildTarget ?

The std lib can be in via a dependency and in case of multi project which are on different Scala version I'm not sure what this is supposed to be