After updating from 2.5.0-RC3 to 2.5.0 using align.preset = most, I can't seem to understand the rules for vertical alignment on = after method bodies... it seems "if the method body contains a val or a for-comp then vertically align the method's ="?
def foo: Int = {
val x = ???
42
}
def bar: Int = {
for { x <- "hey" } yield x
42
}
def fooBig: Int = {
42
}
def fooBigger: Int = {
42
}Not sure if this is as-intended (particularly as the behaviour is so wildly different from 2.5.0-RC3).
val deleteSubscriptionsRequestInjection: ScroogeBufferInjection[
- thrift.DeleteSubscriptionsRequest] = new ScroogeBufferInjection(
+ thrift.DeleteSubscriptionsRequest
+ ] = new ScroogeBufferInjection(
thrift.DeleteSubscriptionsRequest
)
I’m seeing a change I haven’t figured out how to control yet going from scalafmt 2.4.2 to 2.5.1 where it now does what looks to me like a dangling bracket.
val deleteSubscriptionsRequestInjection: ScroogeBufferInjection[ - thrift.DeleteSubscriptionsRequest] = new ScroogeBufferInjection( + thrift.DeleteSubscriptionsRequest + ] = new ScroogeBufferInjection( thrift.DeleteSubscriptionsRequest )
@ShaneDelmore can you create an issue and post your config there?
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.3.2") but I'm getting unresolved dependency errors for it. It seems version 2.3.2 cannot be found. I tried 2.3.4 as well and no joy.
folks, I have a problem I cant solve. There's significant difference between 2.4.2 and 2.5.1 in terms of alignment
Code in 2.4.2:
case class CC(
field1: String,
fieldInt: Int,
fieldWithLongerName: String,
)
val x = CC(
field1 = "string",
fieldInt = 42,
fieldWithLongerName = "longerString",
)Code in 2.5.1:
case class CC(
field1: String,
fieldInt: Int,
fieldWithLongerName: String,
)
val x = CC(
field1 = "string",
fieldInt = 42,
fieldWithLongerName = "longerString",
)Basically, all code alignment at function call sites got ruined. And not sure how to fix it.
My conf looks like the following:
align = most
align.openParenCallSite = false
align.openParenDefnSite = false
align.tokens.add = [
"<-"
"="
//used to align comments
"//"
//used for aligning type definition
":"
//used when creating tuples
{code = "->", owner = "Term.ApplyInfix"},
//elided, since these are SBT specific
]Been using the same config since 1.5.1.
If anyone can point me to something I should try, I would greatly appreciate it
6 replies
"com.beachape" %% "enumeratum-circe" % "1.5.17",
"com.rabbitmq" % "amqp-client" % "5.6.0",Follow-up on my problem, @kitbellew . Can't seem to write code blocks in replies :sweat_smile:
Can I get the "<-" and "=" to align in for comprehensions? In 2.4.2 I managed to get this done :cry:
for {
_ <- IO("please move me")
value = IO("value")
_ <- IO("I meddle")
pleaseMoveMe = 42
imMoved = "dsflk;sdf"
soAmI = 42
_ <- IO("yup, so is this")
definitely <- IO("yey!")
} yield ()How do I get the <- to align with the = in that first code block?
My current config looks like the following:
align.tokens.add = [
{code = "<-", owner = "Enumerator.Generator"}
{code = "=", owner = "(Enumerator.Generator|Val|Defn.(Va(l|r)|Def|Type))|Term.Assign"}
]And looking at https://github.com/scalameta/scalafmt/blob/master/scalafmt-core/shared/src/main/scala/org/scalafmt/config/Align.scala#L113
The two token categories are already "grouped together" when align.most is selected :confused:
3 replies
1 reply
Hi all, I have this formatting problem:
scalacOptions ++= Seq(
"-Ymacro-annotations"
"-Wconf:any:warning-verbose",
),That's some extra indentation I don't want for function calls. I want that to look like this:
scalacOptions ++= Seq(
"-Ymacro-annotations"
"-Wconf:any:warning-verbose",
)What option controls this?
6 replies
2.5.2
Hello everyone! :) Setting up scalafmt for the company I am working at. I would like to know whether there is a rule that rewrites single-line parens .map and .filter calls etc. to lambdas with braces according to a "kotlin like" format:
.map { x =>
// using x
}If that is not possible at all, can I at least have
.map( x =>
// using x
)without completely avoiding to break the line after the opening parentheses of a method call? because if method invocations get large, we generally want
someMethod(
arg1,
arg2,
// ..
)
Hey all, I'm struggling with formatting options and was curios if it was possible to achieve this formatting:
case class Foo(
a: Boolean,
b: String,
c: String,
d: String,
) extends Bar with BazIt seems like I can't force the closing parenthesis on a newline without also forcing the extends to be on a newline. It also seems like with is always forced on a new line for some reason.
My settings are as follows:
version = 2.5.2
preset = IntelliJ
optIn.configStyleArguments = true
continuationIndent.extendSite = 0
continuationIndent.withSiteRelativeToExtends = 0
maxColumn = 160
docstrings = ScalaDoc
assumeStandardLibraryStripMargin = true
align.preset = some
spaces.inImportCurlyBraces = true
verticalMultiline.excludeDanglingParens = ["class", "trait"]
danglingParentheses.exclude = ["class", "trait"]
rewrite.rules = [AvoidInfix, SortModifiers, PreferCurlyFors]
I cannot see scalajs artifacts for scalafmt-core since version 2.0.0 https://mvnrepository.com/artifact/org.scalameta/scalafmt-core
Does scalajs support (I mean publish for use in scalajs code, not formatting scalajs sources) have been removed ?
2 replies
I can't figure out what controls the formatting of partial functions with case. If I start with the whole function on one line, it stays that way.
List((1, 'a'), (2, 'b')).map { case (i, c) => i.toString + c.toString }But if I have a break after =>, scalafmt moves the case to a new line. From:
List((1, 'a'), (2, 'b')).map { case (i, c) =>
i.toString + c.toString
}To:
List((1, 'a'), (2, 'b')).map {
case (i, c) =>
i.toString + c.toString
}I would like to maintain the first formatting. Conf contains only version = 2.5.3.
2 replies
case statements have newlines, then all subsequent ones should have newlines as well?:// OK (all one liners)
obj match {
case Option1(_) => line1
case Option2(_) => line2
case Option3(_) => line3
case Option4(_) => line4
}
// OK (all with newlines)
obj match {
case Option1(_) =>
line1
case Option2(_) =>
line2
case Option3(_) =>
line3
case Option4(_) =>
line4
}
// OK (top statements one-liners)
obj match {
case Option1(_) => line1
case Option2(_) => line2
case Option3(_) =>
line3
case Option4(_) =>
line4
}
// NOT OK, this offends me :-)
obj match {
case Option1(_) =>
line1
case Option2(_) =>
line2
case Option3(_) => line3
case Option4(_) => line4
}
getting the following error. am I missing something obvious?
[error] (testsJVM / Test / scalafmt) Type mismatch;
[error] found : Map[K, V] (value: {"style": "Asterisk", "oneline": "unfold"})
[error] expected : org.scalafmt.config.Docstrings: /Users/daniel/Development/Scala/cats-mtl/.scalafmt.confconfig fragment (basically straight from the documentation):
docstrings {
style = Asterisk
oneline = unfold
}
2 replies