Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jan Eglinger
    @imagejan
    @NicoKiaru I guess FileBatchService is accepting the batchService.run call because it gets your handler. I’m not sure how to solve it, need to dig a bit, but it might be a design flaw that we have no way of knowing the input type when we just extend AbstractHandlerService<BatchInput, BatchInputProvider<?>> without being able to specify File or SourceAndConverter...
    @ctrueden might be able to advise a good way to improve this, but I’m afraid it would also take him some time to remember how batch-processor is set up currently.
    Curtis Rueden
    @ctrueden
    I'm looking...
    Curtis Rueden
    @ctrueden
    Sorry, ran out of time for today. @NicoKiaru an MCVE would be helpful to dig more quickly.
    Nicolas Chiaruttini
    @NicoKiaru
    No pb. Thanks for looking, I'll make a minimal example next week
    Mark Kittisopikul
    @mkitti
    I'm catching up up on the jhdf5 19.04 saga from February 2021. Looks like there was a massive API change with this commit in updating the library to HDF5 1.10
    https://sissource.ethz.ch/sispub/jhdf5/-/commit/20212c5f7ff8b492761d51e6e9e7939809ff24c6
    Mark Kittisopikul
    @mkitti
    Most of the methods that were in individual classes (H5D.java) were migrated to a single H5.java
    https://sissource.ethz.ch/sispub/jhdf5/-/blob/19.04.0/source/java/hdf/hdf5lib/H5.java
    This seems to correspond to incorporation of the hdf.hdf5lib into the main HDF5 repository:
    https://github.com/HDFGroup/hdf5/blob/develop/java/src/hdf/hdf5lib/H5.java
    46 replies
    Curtis Rueden
    @ctrueden
    Interesting blog post on using .java sources with shebang as executable scripts: https://shekhargulati.com/2020/10/26/writing-scripts-in-java-11-and-beyond/
    8 replies
    Gabriel Selzer
    @gselzer
    @ctrueden I think as far as scijava packages rules go, it does probably make sense to move them into scijava-maven-plugin
    7 replies
    Unless you see someone wanting to use the rules without the rest of the stuff in that repo
    2 replies
    I don't know enough about that repo to make that call\
    Gabriel Selzer
    @gselzer
    @ctrueden my scijava-maven-plugin build is failing locally
    Curtis Rueden
    @ctrueden
    Failing build? Or failing tests?
    Gabriel Selzer
    @gselzer
    Failing integration test
    [INFO] [INFO] Compiling 1 source file to /mnt/c/Code/scijava/scijava-maven-plugin/target/it/populate-app/target/classes
    [INFO] [INFO] -------------------------------------------------------------
    [INFO] [ERROR] COMPILATION ERROR :
    [INFO] [INFO] -------------------------------------------------------------
    [INFO] [ERROR] Source option 5 is no longer supported. Use 6 or later.
    [INFO] [ERROR] Target option 1.5 is no longer supported. Use 1.6 or later.
    [INFO] [INFO] 2 errors
    [INFO] [INFO] -------------------------------------------------------------
    [INFO] [INFO] ------------------------------------------------------------------------
    [INFO] [INFO] BUILD FAILURE
    [INFO] [INFO] ------------------------------------------------------------------------
    [INFO] [INFO] Total time:  1.568 s
    [INFO] [INFO] Finished at: 2021-11-16T12:17:37-06:00
    [INFO] [INFO] ------------------------------------------------------------------------
    [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project Example_PlugIn: Compilation failure: Compilation failure:
    [INFO] [ERROR] Source option 5 is no longer supported. Use 6 or later.
    [INFO] [ERROR] Target option 1.5 is no longer supported. Use 1.6 or later.
    [INFO] [ERROR] -> [Help 1]
    Curtis Rueden
    @ctrueden
    Blech.
    You are building with a too-new version of Java. Use Java 8.
    Gabriel Selzer
    @gselzer
    Hmm, Java 8 supports Java 5 source/target?
    Curtis Rueden
    @ctrueden
    • 8: 1.2
    • 11: 6
    • 17: 7
    (Version: minimum source/target version)
    Gabriel Selzer
    @gselzer
    Aha
    Should we make an issue to update?
    Or maybe SciJava Maven Plugin2 can enter the incubator :sweat_smile:
    Curtis Rueden
    @ctrueden
    I don't understand....
    Gabriel Selzer
    @gselzer
    Do we not want to migrate all SciJava code to Java 11?
    Curtis Rueden
    @ctrueden
    Nope!
    Gabriel Selzer
    @gselzer
    What is your reasoning?
    Curtis Rueden
    @ctrueden
    scijava-maven-plugin is part of the current generation of libraries we support, and is built on java 8.
    It is weird that you get that error about 1.5.
    I don't see anywhere in the scijava-maven-plugin code where source or target of 1.5 is being passed!
    Gabriel Selzer
    @gselzer

    It is weird that you get that error about 1.5.

    Yeah, I couldn't find that either

    Curtis Rueden
    @ctrueden
    Ah, it's probably just because some IT doesn't extend pom-scijava.
    Gabriel Selzer
    @gselzer
    Building with Java 8 fixed it though
    Curtis Rueden
    @ctrueden
    The mvn default is 1.5.
    :+1:
    Gabriel Selzer
    @gselzer

    Ah, it's probably just because some IT doesn't extend pom-scijava.

    It's this fella

    Curtis Rueden
    @ctrueden
    Right, because it doesn't extend pom-scijava.
    Gabriel Selzer
    @gselzer
    I'll fix it and file a PR
    Curtis Rueden
    @ctrueden
    I don't think it needs fixing.
    Just use Java 8 for now.
    I don't feel strongly... we could have all the ITs extend pom-scijava... but I'm not sure!
    Gabriel Selzer
    @gselzer
    I don't feel strongly... we could have all the ITs extend pom-scijava... but I'm not sure!
    It seems strange that only one IT doesn't extend it
    Oh wait, many don't extend it
    I'm surprised only one failed...
    Jan Eglinger
    @imagejan
    @ctrueden @hinerm is there a chance we can get scijava/scijava-common#400 and scijava/scijava-ui-swing#51 merged and released soon? They’re relatively small changes, but I just stumbled again upon the non-working Enum script parameters (scijava/scijava-common#397) and those PRs should fix it in my view.
    9 replies
    Jan Eglinger
    @imagejan
    maven.scijava.org seems to be down again?
    and fine again.
    2 replies
    John Bogovic
    @bogovicj
    maven.scijava.org down again?
    Jan Eglinger
    @imagejan
    hm, yes, it seems so. @ctrueden?