Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Jeffry Lum
@j-lum
Added the gradle branch back onto duke.
Apparently opening a browser still relies on AWT and even so requires a lot of weird hacks to get it working reliably so I'll just err on the side of caution and remove the entire help command for now.
Damith C. Rajapakse
@damithc
Wait, help is an essential command. Even if we remove it, students will add it back, unless we show them a way to do it without adding a whole web broswer :-p
Jeffry Lum
@j-lum
I'll remove the old version and implement a text-based solution then
how about an overloaded help command that
  • help (no args) - lists all the commands
  • help (command) - lists the usage message for a particular command
Damith C. Rajapakse
@damithc
For the time being, just a dialog box with the URL of the help page? They won't be able to click it but they can copy-paste into the browser.
Jeffry Lum
@j-lum
anyway removing the dependency on webview reduces the jar to 16.4MB instead of the ~90MB with webview
Yeah the URL of the help page works too.
Damith C. Rajapakse
@damithc
It's waste to create a text version when students already has a proper UG somewhere else.
Paul Tan
@pyokagan
Hi, a new version of CIHR will be deployed over this weekend. Changes include:
  • Migrated to the GitHub Apps platform, allowing one-click install of CIHR via https://github.com/apps/canihasreview/installations/new/
  • A new dashboard has been implemented allowing users to enable/disable CIHR on any repo.
  • A new "repo settings" page has been implemented allowing users to modify per-repo CIHR settings.
  • Anyone with write access to a repository can now submit new iterations for any PR.
Damith C. Rajapakse
@damithc
Nice :+1:
Damith C. Rajapakse
@damithc
Guys, let's try to make some progress on the AB3 ongoing PRs this weekend.
Jeffry Lum
@j-lum
I have lessons on Sunday so I'll be a bit busy.
Damith C. Rajapakse
@damithc
Guys, is this relevant to the tutorial? nusCS2113-AY1920S1/forum#7
Jeffry Lum
@j-lum
If they follow the order specified in the textbook then it's not a problem, otherwise it's required for console apps
Damith C. Rajapakse
@damithc
Is it something we can add nevertheless (i.e., no harm adding)?
Note that some students will start using gradle from the very beginning of the project.
Jeffry Lum
@j-lum
Yeah, in fact if they don't thier stdin will be null.
Damith C. Rajapakse
@damithc
So we add it?
Damith C. Rajapakse
@damithc
Any help with this? nus-cs2103-AY1920S1/forum#30
Jeffry Lum
@j-lum

https://openjfx.io/javadoc/11/javafx.graphics/javafx/application/Application.html

Note that the start method is abstract and must be overridden. The init and stop methods have concrete implementations that do nothing.
The Application subclass must be declared public and must have a public no-argument constructor.

Damith C. Rajapakse
@damithc

Any help with this? nus-cs2103-AY1920S1/forum#30

help as in, reply to the issue :-)

Damith C. Rajapakse
@damithc
Thanks for the reply @j-lum do we need to update the tutorial?
Damith C. Rajapakse
@damithc
Guys, reminder to keep pushing the AB3 tutorials towards a merge.
Damith C. Rajapakse
@damithc
Guys, we must merge the AB3 tutorials within a few days so that I can include them in week 6 instructions.
Damith C. Rajapakse
@damithc
Guys, any idea if these instructions results in a cross-platform jar file? If not, how to make it so? A bit urgent.
WANG CHAO
@fzdy1914
Hi, there are some replies to the javafx & jar problem.
  1. To allow cross-platform, we are unable to use the javafx plugin provided by gradle. The reason is that the plugin will only download the platform specified dependency for javafx. However, to allow cross-platform, we need all dependency being packed in the jar file.
  2. If we want a cross-platform jar, the size of the jar file will have to be 80MB+ because of the packed dependency.
  3. To allow cross-plaform, we just need to remove the javafx plugin and add all the dependency one by one like in AB4. I have tried on one stundent's example, so it should works fines.
WANG CHAO
@fzdy1914
A success example can be found Oscar-B-Liang/duke#6
Damith C. Rajapakse
@damithc
This release is 13MB. Does it mean it will not work on multiple platforms? https://github.com/se-edu/addressbook-level3/releases
We need the app to be cross-platform because the testers might not be on the same platform as the developer.
Damith C. Rajapakse
@damithc
AB3 jar seems to work on both Win and Mac. Sure Duke jar will be 80Mb?
Paul Tan
@pyokagan

This release is 13MB. Does it mean it will not work on multiple platforms? https://github.com/se-edu/addressbook-level3/releases

se-edu/addressbook-level3@ebbb713 removed the Webkit dependencies so the JAR is smaller now.

Damith C. Rajapakse
@damithc

se-edu/addressbook-level3@ebbb713 removed the Webkit dependencies so the JAR is smaller now.

Yeah. @fzdy1914 is suggesting that this size might increase again if we package all javafx versions in to the jar

Paul Tan
@pyokagan
The AB3 JAR already packages all javafx platforms so 13MB should be a good gauge of the file size.
If students want to use the browser panel then they can add back the webkit dependencies which will bring it back up to the original 80MB+
WANG CHAO
@fzdy1914
I agree with Paul, if we do not include webkit dependencies, it will not be 80MB+.
Damith C. Rajapakse
@damithc

I agree with Paul, if we do not include webkit dependencies, it will not be 80MB+.

That's a relief. Thanks for looking into this @fzdy1914
@j-lum can update the duke Gradle tutorial accordingly?

Okkhoy
@junkkhoy
Folks, any particular reason to use shadowJar and not the default gradle Jar (with customization to include dependencies )?

In particular: this student also has queries about JavaFX dependencies.

nusCS2113-AY1920S1/forum#59

WANG CHAO
@fzdy1914
The issue is resolved.
Damith C. Rajapakse
@damithc
@j-lum see nusCS2113-AY1920S1/forum#59
Do we need to update any duke tutorials to incorporate this solution?
Okkhoy
@junkkhoy
@fzdy1914 Yes, I noticed! The way I understood, nothing really incorrect with the shadow plugin; the student missed specifying the entry point, isn't it? Did I miss anything?
WANG CHAO
@fzdy1914
Correct, he accidentally deleted his entry point.
Okkhoy
@junkkhoy
:+1:
Jeffry Lum
@j-lum

Yeah, I opened a PR to for a fix in the tutorial. se-edu/duke#16
As for why we're using shadow instead of the normal jar task, I figure it saves the students from having to configure their own manifest file. Maybe a maintainer who has been around longer can chime in?

We should investigate if changing AB-3 to be modular is a good idea since support for non-modular apps past Java 9 seems to be a bit shaky.

Okkhoy
@junkkhoy
Hi all, I have a student who has issues with gradle erroring out. Can one of you please help to take a look:
nusCS2113-AY1920S1/forum#77
Damith C. Rajapakse
@damithc
Guys, any idea about this? Did we encounter something similar in AB4? nus-cs2103-AY1920S1/forum#141
Jeffry Lum
@j-lum
Both problems are a bit weird...
Damith C. Rajapakse
@damithc
Any help with this? nus-cs2103-AY1920S1/forum#167