Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 06:20
    sebastianbergmann closed #3867
  • 06:20
    sebastianbergmann commented #3867
  • 06:12
    ndench labeled #3867
  • 06:12
    ndench labeled #3867
  • 06:12
    ndench opened #3867
  • Sep 14 09:14

    sebastianbergmann on master

    Prepare release Merge branch '7.5' into 8.3 Prepare release and 1 more (compare)

  • Sep 14 09:12

    sebastianbergmann on 8.3.5

    (compare)

  • Sep 14 09:12

    sebastianbergmann on 8.3

    Prepare release Merge branch '7.5' into 8.3 Prepare release (compare)

  • Sep 14 09:09

    sebastianbergmann on 7.5.16

    (compare)

  • Sep 14 09:09

    sebastianbergmann on 7.5

    Prepare release (compare)

  • Sep 14 09:03

    sebastianbergmann on 3.1.2

    (compare)

  • Sep 14 09:03

    sebastianbergmann on master

    Prepare release (compare)

  • Sep 12 17:17
    Arkemlar edited #3866
  • Sep 12 17:13
    Arkemlar commented #3866
  • Sep 12 17:12
    Arkemlar commented #3866
  • Sep 12 17:11
    Arkemlar commented #3866
  • Sep 12 17:07
    Arkemlar commented #3866
  • Sep 12 17:07
    Arkemlar commented #3866
  • Sep 12 17:06
    Arkemlar edited #3866
  • Sep 12 17:05
    Arkemlar edited #3866
Andreas Möller
@localheinz
@sebastianbergmann @Ocramius https://github.com/actions/stale
Daniel Ruf
@DanielRuf
I'm currently working on sebastianbergmann/phpunit#3793
Ewout Pieter den Ouden
@epdenouden
I've updated the issue labels to show what is being worked on: https://github.com/sebastianbergmann/phpunit/labels/code-sprint-september-2019
Ewout Pieter den Ouden
@epdenouden
image.png
was this the early alpha release of VSCode
Marco Pivetta
@Ocramius
GTKPHP?
Ewout Pieter den Ouden
@epdenouden
@Ocramius I was secretly hoping for a crossover between VB and PHP3
Sebastian Bergmann
@sebastianbergmann
PHP-GTK was a thing, once upon a time, with a PHP IDE written in PHP, for instance.
Ewout Pieter den Ouden
@epdenouden
[screams in TCL/TK]
Marco Pivetta
@Ocramius
    /**
     * @psalm-return array{
     *   __OFFSET: array<string, int>&array{__FILE: string},
     *   setting?: array<string, string>,
     *   extension_versions?: array<string, array{version: string, operator: string}>
     * }&array<
     *   string,
     *   string|array{version: string, operator: string}|array{constraint: string}|array<int|string, string>
     * >
     */
https://66.media.tumblr.com/8a8494980084a17ba8e791e49928a478/tumblr_ny4yexbOsJ1ukmr73o1_400.gif
Stephan Hochdörfer
@shochdoerfer
I'd like to order food in ~20min or so. Send me what you want to order from here: https://www.pizzeria-da-dina.de (food is sponsored by bitExpert). An keep the CoC in mind - no Pizza Hawaii :P
Marco Pivetta
@Ocramius
btw, that raised vimeo/psalm#2105
Daniel Ruf
@DanielRuf
@epdenouden not sure how we can get the classname and methodname for a testsuite (as these are multiple). Did you already started working on sebastianbergmann/phpunit#3730
Claudio Zizza
@SenseException
@sebastianbergmann sebastianbergmann/exporter#27
Marco Pivetta
@Ocramius
Florian Engelhardt
@flow-control
:thumbsup:
Andreas Heigl
@heiglandreas
I've prepared a PoC that allows creating Tests that do not inherit from TestCase. It might not be the right way but it could be a base of discussion: The code is at https://github.com/heiglandreas/phpunitstub
Ewout Pieter den Ouden
@epdenouden
@DanielRuf no, I wasn't able to start on that yet :( feel free to pick it up! shall I assign it to you?
Marco Pivetta
@Ocramius
@oliverklee
diff --git a/src/Framework/TestSuite.php b/src/Framework/TestSuite.php
index 2fca3b8dd..2e8f82338 100644
--- a/src/Framework/TestSuite.php
+++ b/src/Framework/TestSuite.php
@@ -617,7 +617,7 @@ public function testAt(int $index)
     /**
      * Returns the tests as an enumeration.
      *
-     * @return Test[]
+     * @return TestCase[]
      */
     public function tests(): array
     {
@@ -627,7 +627,7 @@ public function tests(): array
     /**
      * Set tests of the test suite
      *
-     * @param Test[] $tests
+     * @param TestCase[] $tests
      */
     public function setTests(array $tests): void
     {
diff --git a/src/Runner/TestSuiteSorter.php b/src/Runner/TestSuiteSorter.php
index fda662ac7..1a28f5e54 100644
--- a/src/Runner/TestSuiteSorter.php
+++ b/src/Runner/TestSuiteSorter.php
@@ -358,6 +358,10 @@ private function cmpSize(Test $a, Test $b): int
      * @param array<DataProviderTestSuite|TestCase> $tests
      *
      * @return array<DataProviderTestSuite|TestCase>
+     *
+     * @psalm-template T of array<DataProviderTestSuite|TestCase>
+     * @psalm-param T $tests
+     * @psalm-return T
      */
     private function resolveDependencies(array $tests): array
     {
Ewout Pieter den Ouden
@epdenouden
@DanielRuf I'll fix up #3730 this week, it is related to TestDox which I had been working on
getting the TestSuite name isn't that hard, however I'll have to go over the edge cases
having said that, feel free to hurt yourself, if you really want to ;-)
Stephan Hochdörfer
@shochdoerfer
Food order done!
Marco Pivetta
@Ocramius
need a review and a performance analysis (from whoever worked on kcachegrind yesterday) at sebastianbergmann/phpunit#3836
Daniel Ruf
@DanielRuf

@DanielRuf I'll fix up #3730 this week, it is related to TestDox which I had been working on

I'm not so deep into it yet. Might make more sense if you take it up as you msay have a better overview of (possible) edge cases =)

Andreas Möller
@localheinz
This message was deleted
11EDC2BC-30CB-42D1-87C1-7F80E2B65850
@sebastianbergmann The error message regarding git when running psalm disappears with sebastianbergmann/phpunit#3838. However, the psalm error remains. Taking a look!
Andreas Möller
@localheinz
@sebastianbergmann @flow-control Global State
Ewout Pieter den Ouden
@epdenouden
@localheinz $_CARPET
Andreas Möller
@localheinz
@epdenouden wat
Ewout Pieter den Ouden
@epdenouden
Stephan Hochdörfer
@shochdoerfer
Food ETA 13:25
Ewout Pieter den Ouden
@epdenouden
@DanielRuf okidoki! I'll treat myself to another round of CliTestDoxPrinter :cherries:
Andreas Heigl
@heiglandreas
I'm digging nito XSLT now....
Michel Hartmann
@MichelHartmann
$foo = $this->createMock(Foo::class);
        $foo->method('doSomething')
            ->after($id); // <- what's the expected behaviour of this method?
Daniel Ruf
@DanielRuf
Marco Pivetta
@Ocramius
Ewout Pieter den Ouden
@epdenouden
for those that don't feel confident fiddling around with Test|TestCase|TestSuite|DataProviderTestSuite...
image.png
Marco Pivetta
@Ocramius
@SenseException Ocramius:chore/annotations-refactoring
@SenseException git@github.com:Ocramius/phpunit.git
Florian Engelhardt
@flow-control
Michel Hartmann
@MichelHartmann
@flow-control seems save to delete them.
Ewout Pieter den Ouden
@epdenouden
Sebastian Bergmann
@sebastianbergmann
@localheinz https://github.com/sebastianbergmann/docker-amiga-gcc/blob/master/Dockerfile ist das einzige Dockerfile, mit dem ich bislang regelmäßig arbeite ;-)
Ewout Pieter den Ouden
@epdenouden
@localheinz I've put the power adapter of your laptop is in Stephan's office your hands
Marco Pivetta
@Ocramius
@sebastianbergmann sebastianbergmann/phpunit#3836 nao green @_@
Oliver Klee
@oliverklee
./tools/psalm --config=.psalm/config.xml