Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 00:35
    CJDennis commented #3159
  • Oct 15 23:54
    CJDennis commented #3159
  • Oct 15 22:01
    markwatney2016 commented #3900
  • Oct 15 21:59
    markwatney2016 commented #3900
  • Oct 15 20:51
    faliure edited #167
  • Oct 15 20:42
    faliure opened #167
  • Oct 15 17:50
    epdenouden commented #3900
  • Oct 15 16:12
    mfn commented #3902
  • Oct 15 16:02
    mfn commented #3891
  • Oct 15 16:00
    epdenouden labeled #3900
  • Oct 15 15:26
    codecov[bot] commented #3897
  • Oct 15 15:25
    codecov[bot] commented #3897
  • Oct 15 15:25
    codecov[bot] commented #3897
  • Oct 15 15:25
    codecov[bot] commented #3897
  • Oct 15 15:23
    codecov[bot] commented #3897
  • Oct 15 15:22
    codecov[bot] commented #3897
  • Oct 15 15:21
    codecov[bot] commented #3897
  • Oct 15 15:21
    codecov[bot] commented #3897
  • Oct 15 15:20
    codecov[bot] commented #3897
  • Oct 15 15:20
    codecov[bot] commented #3897
Ewout Pieter den Ouden
@epdenouden
"it's fine" :fire: :fire: :fire: :fire: :fire: :fire: :fire:
Yoanndp
@Yoanndp
Hello, someone is there?
Yoanndp
@Yoanndp
Nevermind, I fixed it :) Have a nice day
Ghost
@ghost~5d6f7af9d73408ce4fc9f5f7
Hi there, how is it possible to mock several methods on one stub? I tried with several calls to ->method(), but I get the error 'Method name matcher is already defined, cannot redefine'
Nicolas Hohm
@nickel715
@bezin Usually you do it like this https://github.com/sebastianbergmann/phpunit/blob/master/tests/unit/Framework/TestBuilderTest.php#L28-L38
If you need further help please provide some example code.
Ghost
@ghost~5d6f7af9d73408ce4fc9f5f7
@nickel715 Thanks for your hint, I found out about that a couple of hours after my question. I chained all my calls, but did not separate them per method :thumbsup:
Sebastian Bergmann
@sebastianbergmann
Andreas Möller
@localheinz
@epdenouden https://bear.app
re: eval-stdin security risk
Ewout Pieter den Ouden
@epdenouden
also, kein Code Sprint chat? :)
ich werde die '@depends on class' mal fixen 🛠
Marco Pivetta
@Ocramius

Mine: sebastianbergmann/phpunit#3120

Feel free to come over and tells me your strong opinions if I'm supposed to do something specific :P

Marco Pivetta
@Ocramius
@epdenouden can you assign the above to the sprint, please?
Ewout Pieter den Ouden
@epdenouden
@Ocramius done!
Marco Pivetta
@Ocramius
thx
Matthias Schobner
@schobner
i try this issue: Class name of expected function call #3676
sebastianbergmann/phpunit#3676
Sebastian Bergmann
@sebastianbergmann
This might be interested for someone in to performance profiling: sebastianbergmann/phpunit#3745
Daniel Ruf
@DanielRuf
gave feedback on sebastianbergmann/php-code-coverage#694 which should be fixed with the UMD version of Popper
Oliver Klee
@oliverklee
In PhpStorm, the .yml schema validation complains about this line: https://github.com/sebastianbergmann/phpunit/blob/master/.travis.yml#L55
env: php-cs-fixer
It expects the environment variable having a value. Would it make sense to give it a value (e.g., 1) to get rid of this validation warning?
Sebastian Bergmann
@sebastianbergmann
As I understand it, "env: php-cs-fixer" defines an environment named php-cs-fixer. I would ignore this warning since Travis CI works fine with the configuration.
Daniel Ruf
@DanielRuf
@epdenouden do you know what we have to change / fix there? sebastianbergmann/phpunit#3693
Ewout Pieter den Ouden
@epdenouden
@DanielRuf moment...
ahja! ich vermute: RegEx Elend
the whole @annotation parsing could use a nice cleanup
Sebastian Bergmann
@sebastianbergmann
Starting to wrap my head around sebastianbergmann/phpunit#3803
Ewout Pieter den Ouden
@epdenouden
but this is just a weird one, I think it's just a strip/trim/regex thingy
Sebastian Bergmann
@sebastianbergmann
the whole @annotation parsing could use a nice cleanup
Indeed.
Ewout Pieter den Ouden
@epdenouden
The annotations are high on my private $wishlist as it can be refactored to use much fewer resources
while digging around @dataProvider I found some lookups being done twice, for example
Marco Pivetta
@Ocramius
@epdenouden do we haz issue for annotations? I can look into it.
Ewout Pieter den Ouden
@epdenouden
@Ocramius I am not sure; it gets touched on by bugs like the one @DanielRuf just mentioned
it's one of those older parts that 'just kinda works'
Marco Pivetta
@Ocramius
Yeah, so it would be chore work only
Ewout Pieter den Ouden
@epdenouden
yup
Marco Pivetta
@Ocramius
good way to produce more bugs :P
Ewout Pieter den Ouden
@epdenouden
oh yes
work with a rather high "initial : bugfix" pull request ratio
Sebastian Bergmann
@sebastianbergmann
@Ocramius Most of the annotation processing happens in https://github.com/sebastianbergmann/phpunit/blob/master/src/Util/Test.php
Ewout Pieter den Ouden
@epdenouden
ahhh one of my fave files
I'm fiddling around with @depends anyway at the moment
Marco Pivetta
@Ocramius
biutifuru
Ewout Pieter den Ouden
@epdenouden
I can have a look later today or tomorrow; it needs some work for the whole lazy loading data providers anyway
bofalke
@bofalke
Should the methods 'expectWarning' and 'expectNotice' be added?
sebastianbergmann/phpunit#3758
Marco Pivetta
@Ocramius
Poking again: need review on sebastianbergmann/phpunit#3810 - it has one discussion point, but otherwise done-ish
@bofalke seems like a bad idea: can expect one of PHPUnit's converted exception types