Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 08:47

    sebastianbergmann on 4.2.3

    (compare)

  • 08:47
    sebastianbergmann closed #49
  • 08:47

    sebastianbergmann on master

    Closes #49 Update ChangeLog Prepare release (compare)

  • 08:37
    sebastianbergmann closed #51
  • 08:37
    sebastianbergmann commented #51
  • 08:35
    sebastianbergmann closed #50
  • 08:35

    sebastianbergmann on master

    Windows improvements to console… (compare)

  • 08:13
    sebastianbergmann unlabeled #3948
  • 08:13
    sebastianbergmann closed #3948
  • 08:13
    sebastianbergmann commented #3948
  • 08:11
    pjordaan labeled #3948
  • 08:11
    pjordaan opened #3948
  • 00:16
    mfn edited #3737
  • Nov 19 17:50

    sebastianbergmann on master

    Fix CS/WS issues Improve warning message for inv… (compare)

  • Nov 19 07:17
    christeredvartsen opened #3947
  • Nov 19 07:17
    christeredvartsen labeled #3947
  • Nov 18 19:33
    sebastianbergmann commented #174
  • Nov 18 19:32
    sebastianbergmann edited #174
  • Nov 18 19:32
    sebastianbergmann transferred #3928
  • Nov 18 19:32
    BackEndTea opened #174
Ewout Pieter den Ouden
@epdenouden
Marco Pivetta
@Ocramius

Mine: sebastianbergmann/phpunit#3120

Feel free to come over and tells me your strong opinions if I'm supposed to do something specific :P

Marco Pivetta
@Ocramius
@epdenouden can you assign the above to the sprint, please?
Ewout Pieter den Ouden
@epdenouden
@Ocramius done!
Marco Pivetta
@Ocramius
thx
Matthias Schobner
@schobner
i try this issue: Class name of expected function call #3676
sebastianbergmann/phpunit#3676
Sebastian Bergmann
@sebastianbergmann
This might be interested for someone in to performance profiling: sebastianbergmann/phpunit#3745
Daniel Ruf
@DanielRuf
gave feedback on sebastianbergmann/php-code-coverage#694 which should be fixed with the UMD version of Popper
Oliver Klee
@oliverklee
In PhpStorm, the .yml schema validation complains about this line: https://github.com/sebastianbergmann/phpunit/blob/master/.travis.yml#L55
env: php-cs-fixer
It expects the environment variable having a value. Would it make sense to give it a value (e.g., 1) to get rid of this validation warning?
Sebastian Bergmann
@sebastianbergmann
As I understand it, "env: php-cs-fixer" defines an environment named php-cs-fixer. I would ignore this warning since Travis CI works fine with the configuration.
Daniel Ruf
@DanielRuf
@epdenouden do you know what we have to change / fix there? sebastianbergmann/phpunit#3693
Ewout Pieter den Ouden
@epdenouden
@DanielRuf moment...
ahja! ich vermute: RegEx Elend
the whole @annotation parsing could use a nice cleanup
Sebastian Bergmann
@sebastianbergmann
Starting to wrap my head around sebastianbergmann/phpunit#3803
Ewout Pieter den Ouden
@epdenouden
but this is just a weird one, I think it's just a strip/trim/regex thingy
Sebastian Bergmann
@sebastianbergmann
the whole @annotation parsing could use a nice cleanup
Indeed.
Ewout Pieter den Ouden
@epdenouden
The annotations are high on my private $wishlist as it can be refactored to use much fewer resources
while digging around @dataProvider I found some lookups being done twice, for example
Marco Pivetta
@Ocramius
@epdenouden do we haz issue for annotations? I can look into it.
Ewout Pieter den Ouden
@epdenouden
@Ocramius I am not sure; it gets touched on by bugs like the one @DanielRuf just mentioned
it's one of those older parts that 'just kinda works'
Marco Pivetta
@Ocramius
Yeah, so it would be chore work only
Ewout Pieter den Ouden
@epdenouden
yup
Marco Pivetta
@Ocramius
good way to produce more bugs :P
Ewout Pieter den Ouden
@epdenouden
oh yes
work with a rather high "initial : bugfix" pull request ratio
Sebastian Bergmann
@sebastianbergmann
@Ocramius Most of the annotation processing happens in https://github.com/sebastianbergmann/phpunit/blob/master/src/Util/Test.php
Ewout Pieter den Ouden
@epdenouden
ahhh one of my fave files
I'm fiddling around with @depends anyway at the moment
Marco Pivetta
@Ocramius
biutifuru
Ewout Pieter den Ouden
@epdenouden
I can have a look later today or tomorrow; it needs some work for the whole lazy loading data providers anyway
bofalke
@bofalke
Should the methods 'expectWarning' and 'expectNotice' be added?
sebastianbergmann/phpunit#3758
Marco Pivetta
@Ocramius
Poking again: need review on sebastianbergmann/phpunit#3810 - it has one discussion point, but otherwise done-ish
@bofalke seems like a bad idea: can expect one of PHPUnit's converted exception types
->expectException(\PHPUnit\yaddayadda\WarningThingy) works just fine
Sebastian Bergmann
@sebastianbergmann
@Ocramius Will be with you shortly.
bofalke
@bofalke
@Ocramius ok thx
Sebastian Bergmann
@sebastianbergmann
I just commented, too. And closed it.
Florian Engelhardt
@flow-control
honest-work.jpg
Marco Pivetta
@Ocramius
@epdenouden got a second to discuss annotations?
Daniel Ruf
@DanielRuf
@SebastianKull see https://www.php.net/manual/en/language.types.float.php so it makes sense in the validation of equality (precision depends on the system, use bcmath, gmp)
Sebastian Bergmann
@sebastianbergmann
Oliver Klee
@oliverklee
Anyone else having problems running the basic tests? sebastianbergmann/phpunit#3815
Marco Pivetta
@Ocramius
Same failures
Sebastian Bergmann
@sebastianbergmann
@Ocramius @oliverklee Those tests are "special" and have their own README. @epdenouden can explain :)