Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 15:30
    codecov[bot] commented #3936
  • 15:30
    codecov[bot] commented #3936
  • 15:30
    epdenouden synchronize #3936
  • 15:26
    MehdiZox commented #4125
  • 14:57
    codecov[bot] commented #3936
  • 14:57
    codecov[bot] commented #3936
  • 14:55
    epdenouden synchronize #3936
  • 14:11
    sebastianbergmann closed #4125
  • 14:11
    sebastianbergmann commented #4125
  • 14:04
    MehdiZox opened #4125
  • 13:51
    epdenouden labeled #3567
  • 13:51
    epdenouden commented #3567
  • 13:24
    BafS commented #3567
  • 13:23

    sebastianbergmann on master

    Update baseline (compare)

  • 13:22

    sebastianbergmann on master

    Update baseline (compare)

  • 13:15

    sebastianbergmann on master

    Update tools (compare)

  • 13:15

    sebastianbergmann on master

    Update tools (compare)

  • 13:15

    sebastianbergmann on master

    Update tools (compare)

  • 13:15

    sebastianbergmann on master

    Update tools (compare)

  • 13:15

    sebastianbergmann on master

    Update tools (compare)

Daniel Ruf
@DanielRuf
gave feedback on sebastianbergmann/php-code-coverage#694 which should be fixed with the UMD version of Popper
Oliver Klee
@oliverklee
In PhpStorm, the .yml schema validation complains about this line: https://github.com/sebastianbergmann/phpunit/blob/master/.travis.yml#L55
env: php-cs-fixer
It expects the environment variable having a value. Would it make sense to give it a value (e.g., 1) to get rid of this validation warning?
Sebastian Bergmann
@sebastianbergmann
As I understand it, "env: php-cs-fixer" defines an environment named php-cs-fixer. I would ignore this warning since Travis CI works fine with the configuration.
Daniel Ruf
@DanielRuf
@epdenouden do you know what we have to change / fix there? sebastianbergmann/phpunit#3693
Ewout Pieter den Ouden
@epdenouden
@DanielRuf moment...
ahja! ich vermute: RegEx Elend
the whole @annotation parsing could use a nice cleanup
Sebastian Bergmann
@sebastianbergmann
Starting to wrap my head around sebastianbergmann/phpunit#3803
Ewout Pieter den Ouden
@epdenouden
but this is just a weird one, I think it's just a strip/trim/regex thingy
Sebastian Bergmann
@sebastianbergmann
the whole @annotation parsing could use a nice cleanup
Indeed.
Ewout Pieter den Ouden
@epdenouden
The annotations are high on my private $wishlist as it can be refactored to use much fewer resources
while digging around @dataProvider I found some lookups being done twice, for example
Marco Pivetta
@Ocramius
@epdenouden do we haz issue for annotations? I can look into it.
Ewout Pieter den Ouden
@epdenouden
@Ocramius I am not sure; it gets touched on by bugs like the one @DanielRuf just mentioned
it's one of those older parts that 'just kinda works'
Marco Pivetta
@Ocramius
Yeah, so it would be chore work only
Ewout Pieter den Ouden
@epdenouden
yup
Marco Pivetta
@Ocramius
good way to produce more bugs :P
Ewout Pieter den Ouden
@epdenouden
oh yes
work with a rather high "initial : bugfix" pull request ratio
Sebastian Bergmann
@sebastianbergmann
@Ocramius Most of the annotation processing happens in https://github.com/sebastianbergmann/phpunit/blob/master/src/Util/Test.php
Ewout Pieter den Ouden
@epdenouden
ahhh one of my fave files
I'm fiddling around with @depends anyway at the moment
Marco Pivetta
@Ocramius
biutifuru
Ewout Pieter den Ouden
@epdenouden
I can have a look later today or tomorrow; it needs some work for the whole lazy loading data providers anyway
bofalke
@bofalke
Should the methods 'expectWarning' and 'expectNotice' be added?
sebastianbergmann/phpunit#3758
Marco Pivetta
@Ocramius
Poking again: need review on sebastianbergmann/phpunit#3810 - it has one discussion point, but otherwise done-ish
@bofalke seems like a bad idea: can expect one of PHPUnit's converted exception types
->expectException(\PHPUnit\yaddayadda\WarningThingy) works just fine
Sebastian Bergmann
@sebastianbergmann
@Ocramius Will be with you shortly.
bofalke
@bofalke
@Ocramius ok thx
Sebastian Bergmann
@sebastianbergmann
I just commented, too. And closed it.
Florian Engelhardt
@flow-control
honest-work.jpg
Marco Pivetta
@Ocramius
@epdenouden got a second to discuss annotations?
Daniel Ruf
@DanielRuf
@SebastianKull see https://www.php.net/manual/en/language.types.float.php so it makes sense in the validation of equality (precision depends on the system, use bcmath, gmp)
Sebastian Bergmann
@sebastianbergmann
Oliver Klee
@oliverklee
Anyone else having problems running the basic tests? sebastianbergmann/phpunit#3815
Marco Pivetta
@Ocramius
Same failures
Sebastian Bergmann
@sebastianbergmann
@Ocramius @oliverklee Those tests are "special" and have their own README. @epdenouden can explain :)
Marco Pivetta
@Ocramius
@sebastianbergmann sebastianbergmann/phpunit#3810 mergeable
Ewout Pieter den Ouden
@epdenouden
@oliverklee ups! README.md werde ich updaten
Oliver Klee
@oliverklee
Danke! :heart:
Oliver Klee
@oliverklee
Has anyone already gotten the end-to-end tests to run in PhpStorm (only the end-to-end tests, not all tests)?
Sebastian Kull
@SebastianKull
@sebastianbergmann can you please give feedback on sebastianbergmann/phpunit#3817 ?
Sebastian Bergmann
@sebastianbergmann
@oliverklee Sorry, I do not run tests in PhpStorm. They are in a separate testsuite named end-to-end. So on the CLI it can be filtered with "--testsuite end-to-end". That should also be possible, somehow, through PhpStorm's UI.