Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 18:41
    Fedcomp commented #3960
  • 18:26
    autaut03 commented #3960
  • 18:25
    autaut03 commented #3960
  • 18:03
    sebastianbergmann commented #3960
  • 13:37
    Fedcomp commented #3937
  • 13:36
    Fedcomp commented #3937
  • 13:35
    Fedcomp commented #3960
  • 13:11
    sebastianbergmann closed #4028
  • 13:11
    sebastianbergmann commented #4028
  • 13:11
    sebastianbergmann unlabeled #4028
  • 13:10

    sebastianbergmann on master

    Remove call by class name from … Update example to use filename (compare)

  • 13:10
    sebastianbergmann closed #178
  • 12:11
    flow-control synchronize #178
  • 12:09
    flow-control opened #178
  • 12:02
    lifeblood edited #4028
  • 12:01
    lifeblood edited #4028
  • 12:00
    lifeblood labeled #4028
  • 12:00
    lifeblood opened #4028
  • Jan 28 17:33
    ratatatKE commented #1494
  • Jan 27 12:01

    sebastianbergmann on master

    Rename method Fix (compare)

Ewout Pieter den Ouden
@epdenouden
it's one of those older parts that 'just kinda works'
Marco Pivetta
@Ocramius
Yeah, so it would be chore work only
Ewout Pieter den Ouden
@epdenouden
yup
Marco Pivetta
@Ocramius
good way to produce more bugs :P
Ewout Pieter den Ouden
@epdenouden
oh yes
work with a rather high "initial : bugfix" pull request ratio
Sebastian Bergmann
@sebastianbergmann
@Ocramius Most of the annotation processing happens in https://github.com/sebastianbergmann/phpunit/blob/master/src/Util/Test.php
Ewout Pieter den Ouden
@epdenouden
ahhh one of my fave files
I'm fiddling around with @depends anyway at the moment
Marco Pivetta
@Ocramius
biutifuru
Ewout Pieter den Ouden
@epdenouden
I can have a look later today or tomorrow; it needs some work for the whole lazy loading data providers anyway
bofalke
@bofalke
Should the methods 'expectWarning' and 'expectNotice' be added?
sebastianbergmann/phpunit#3758
Marco Pivetta
@Ocramius
Poking again: need review on sebastianbergmann/phpunit#3810 - it has one discussion point, but otherwise done-ish
@bofalke seems like a bad idea: can expect one of PHPUnit's converted exception types
->expectException(\PHPUnit\yaddayadda\WarningThingy) works just fine
Sebastian Bergmann
@sebastianbergmann
@Ocramius Will be with you shortly.
bofalke
@bofalke
@Ocramius ok thx
Sebastian Bergmann
@sebastianbergmann
I just commented, too. And closed it.
Florian Engelhardt
@flow-control
honest-work.jpg
Marco Pivetta
@Ocramius
@epdenouden got a second to discuss annotations?
Daniel Ruf
@DanielRuf
@SebastianKull see https://www.php.net/manual/en/language.types.float.php so it makes sense in the validation of equality (precision depends on the system, use bcmath, gmp)
Sebastian Bergmann
@sebastianbergmann
Oliver Klee
@oliverklee
Anyone else having problems running the basic tests? sebastianbergmann/phpunit#3815
Marco Pivetta
@Ocramius
Same failures
Sebastian Bergmann
@sebastianbergmann
@Ocramius @oliverklee Those tests are "special" and have their own README. @epdenouden can explain :)
Marco Pivetta
@Ocramius
@sebastianbergmann sebastianbergmann/phpunit#3810 mergeable
Ewout Pieter den Ouden
@epdenouden
@oliverklee ups! README.md werde ich updaten
Oliver Klee
@oliverklee
Danke! :heart:
Oliver Klee
@oliverklee
Has anyone already gotten the end-to-end tests to run in PhpStorm (only the end-to-end tests, not all tests)?
Sebastian Kull
@SebastianKull
@sebastianbergmann can you please give feedback on sebastianbergmann/phpunit#3817 ?
Sebastian Bergmann
@sebastianbergmann
@oliverklee Sorry, I do not run tests in PhpStorm. They are in a separate testsuite named end-to-end. So on the CLI it can be filtered with "--testsuite end-to-end". That should also be possible, somehow, through PhpStorm's UI.
Sebastian Bergmann
@sebastianbergmann
@SebastianKull Other than "floats are hard" I cannot provide feedback right now, sorry.
Florian Engelhardt
@flow-control
If it's ok for everyone, i will start looking into sebastianbergmann/phpunit#2253 anyone already into this?
Andreas Möller
@localheinz
@sebastianbergmann What do you think about giving sebastianbergmann/phpunit#3809 a try? We could still revert if it doesn’t work as expected.
Marco Pivetta
@Ocramius
pardon the wording, but is there an un-fucked version of array_merge_recursive()? This is borked^2: https://3v4l.org/Wm2O6
Sebastian Bergmann
@sebastianbergmann
We break for lunch in ~ 5 minutes.
Marco Pivetta
@Ocramius
DON'T BREAK THE LUNCH!
Andreas Möller
@localheinz
@sebastianbergmann vimeo/psalm laeuft nun auch auf GitHub actions: https://github.com/sebastianbergmann/phpunit/pull/3820!
Ewout Pieter den Ouden
@epdenouden
🥁
Daniel Ruf
@DanielRuf
@epdenouden if you have time, can you review sebastianbergmann/phpunit#3822 Would be great =) I guess it should not be a greedy selector.
Ewout Pieter den Ouden
@epdenouden
thx! saw the alert
are you familiar enough with PHPT to guard the change with a test?
Marco Pivetta
@Ocramius

\PHPUnit\Util\Test::resolveElementToReflectionObjects

What...?!

Ewout Pieter den Ouden
@epdenouden
my brain is starting to skip tests
Sebastian Bergmann
@sebastianbergmann
Pending reservation: "Little Saigon", Seckenheimer Str. 81, 68165 Mannheim
Marco Pivetta
@Ocramius
PHP Fatal error:  Uncaught Error: Internal error: Failed to retrieve the reflection object in /home/ocramius/Documents/sebastianbergmann/phpunit/src/Annotation/DocBlock.php:273
GRRRRRR