Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 19:42
    Pherserk commented #4123
  • 19:39
    Pherserk commented #4123
  • 18:50
    mfn commented #4121
  • 18:42
    sebastianbergmann commented #4123
  • 18:41
    sebastianbergmann closed #4124
  • 18:41
    sebastianbergmann commented #4124
  • 17:21
    Pherserk edited #4124
  • 17:20
    Pherserk synchronize #4124
  • 17:15
    Pherserk synchronize #4124
  • 17:12
    Pherserk synchronize #4124
  • 16:48
    Pherserk synchronize #4124
  • 16:40
    Pherserk commented #4123
  • 16:40
    Pherserk commented #4123
  • 16:39
    Pherserk opened #4124
  • 16:27
    Pherserk edited #4123
  • 16:27
    Pherserk edited #4123
  • 16:26
    Pherserk edited #4123
  • 16:26
    Pherserk edited #4123
  • 16:25
    sebastianbergmann commented #4123
  • 16:25
    Pherserk edited #4123
Florian Engelhardt
@flow-control
honest-work.jpg
Marco Pivetta
@Ocramius
@epdenouden got a second to discuss annotations?
Daniel Ruf
@DanielRuf
@SebastianKull see https://www.php.net/manual/en/language.types.float.php so it makes sense in the validation of equality (precision depends on the system, use bcmath, gmp)
Sebastian Bergmann
@sebastianbergmann
Oliver Klee
@oliverklee
Anyone else having problems running the basic tests? sebastianbergmann/phpunit#3815
Marco Pivetta
@Ocramius
Same failures
Sebastian Bergmann
@sebastianbergmann
@Ocramius @oliverklee Those tests are "special" and have their own README. @epdenouden can explain :)
Marco Pivetta
@Ocramius
@sebastianbergmann sebastianbergmann/phpunit#3810 mergeable
Ewout Pieter den Ouden
@epdenouden
@oliverklee ups! README.md werde ich updaten
Oliver Klee
@oliverklee
Danke! :heart:
Oliver Klee
@oliverklee
Has anyone already gotten the end-to-end tests to run in PhpStorm (only the end-to-end tests, not all tests)?
Sebastian Kull
@SebastianKull
@sebastianbergmann can you please give feedback on sebastianbergmann/phpunit#3817 ?
Sebastian Bergmann
@sebastianbergmann
@oliverklee Sorry, I do not run tests in PhpStorm. They are in a separate testsuite named end-to-end. So on the CLI it can be filtered with "--testsuite end-to-end". That should also be possible, somehow, through PhpStorm's UI.
Sebastian Bergmann
@sebastianbergmann
@SebastianKull Other than "floats are hard" I cannot provide feedback right now, sorry.
Florian Engelhardt
@flow-control
If it's ok for everyone, i will start looking into sebastianbergmann/phpunit#2253 anyone already into this?
Andreas Möller
@localheinz
@sebastianbergmann What do you think about giving sebastianbergmann/phpunit#3809 a try? We could still revert if it doesn’t work as expected.
Marco Pivetta
@Ocramius
pardon the wording, but is there an un-fucked version of array_merge_recursive()? This is borked^2: https://3v4l.org/Wm2O6
Sebastian Bergmann
@sebastianbergmann
We break for lunch in ~ 5 minutes.
Marco Pivetta
@Ocramius
DON'T BREAK THE LUNCH!
Andreas Möller
@localheinz
@sebastianbergmann vimeo/psalm laeuft nun auch auf GitHub actions: https://github.com/sebastianbergmann/phpunit/pull/3820!
Ewout Pieter den Ouden
@epdenouden
🥁
Daniel Ruf
@DanielRuf
@epdenouden if you have time, can you review sebastianbergmann/phpunit#3822 Would be great =) I guess it should not be a greedy selector.
Ewout Pieter den Ouden
@epdenouden
thx! saw the alert
are you familiar enough with PHPT to guard the change with a test?
Marco Pivetta
@Ocramius

\PHPUnit\Util\Test::resolveElementToReflectionObjects

What...?!

Ewout Pieter den Ouden
@epdenouden
my brain is starting to skip tests
Sebastian Bergmann
@sebastianbergmann
Pending reservation: "Little Saigon", Seckenheimer Str. 81, 68165 Mannheim
Marco Pivetta
@Ocramius
PHP Fatal error:  Uncaught Error: Internal error: Failed to retrieve the reflection object in /home/ocramius/Documents/sebastianbergmann/phpunit/src/Annotation/DocBlock.php:273
GRRRRRR
Sebastian Bergmann
@sebastianbergmann
Dinner at 20:00 at "Little Saigon", Seckenheimer Str. 81, 68165 Mannheim
Ewout Pieter den Ouden
@epdenouden
@Ocramius are you trying to MockBlock?!
Marco Pivetta
@Ocramius
$this->reflector->getTraits() :S
I hate traits.
Ewout Pieter den Ouden
@epdenouden
gg no re
Sebastian Bergmann
@sebastianbergmann
That hate is a trait you should work on ;)
Marco Pivetta
@Ocramius
>.<
Oliver Klee
@oliverklee
While trying to fix some types, I discovered some bugs in TestSuiteIterator and discovered that it did not have any tests at all. So here they are: sebastianbergmann/phpunit#3825
Sebastian Bergmann
@sebastianbergmann
@oliverklee vimeo/psalm#1979
Karsten Frohwein
@kfrohwein
Hi Channel
Claudio Zizza
@SenseException
Andreas Möller
@localheinz
Sebastian Bergmann
@sebastianbergmann
Will look at it ASAP, was busy writing words: sebastianbergmann/phpunit#3799
Andreas Möller
@localheinz
@sebastianbergmann @Ocramius https://github.com/actions/stale
Daniel Ruf
@DanielRuf
I'm currently working on sebastianbergmann/phpunit#3793
Ewout Pieter den Ouden
@epdenouden
I've updated the issue labels to show what is being worked on: https://github.com/sebastianbergmann/phpunit/labels/code-sprint-september-2019
Ewout Pieter den Ouden
@epdenouden
image.png
was this the early alpha release of VSCode