Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Apr 08 15:10

    sebastianbergmann on master

    Announce new trainings (compare)

  • Apr 08 12:55
    kubawerlos commented #66
  • Apr 08 12:37
    sebastianbergmann commented #66
  • Apr 08 12:33
    kubawerlos commented #66
  • Apr 08 12:03
    sebastianbergmann closed #4170
  • Apr 08 12:03
    sebastianbergmann commented #4170
  • Apr 08 12:02
    sebastianbergmann unlabeled #4171
  • Apr 08 12:02
    sebastianbergmann closed #4171
  • Apr 08 12:02
    sebastianbergmann commented #4171
  • Apr 08 11:52
    viksts labeled #4171
  • Apr 08 11:52
    viksts opened #4171
  • Apr 08 11:49
    sebastianbergmann labeled #4170
  • Apr 08 11:46
    sveneld commented #4170
  • Apr 08 11:42
    sebastianbergmann commented #4170
  • Apr 08 11:41
    sebastianbergmann commented #66
  • Apr 08 11:41
    sveneld edited #4170
  • Apr 08 11:40
    sveneld labeled #4170
  • Apr 08 11:40
    sveneld opened #4170
  • Apr 08 10:03
    kubawerlos commented #66
  • Apr 08 10:03
    kubawerlos commented #66
Sebastian Bergmann
@sebastianbergmann
@SebastianKull Other than "floats are hard" I cannot provide feedback right now, sorry.
Florian Engelhardt
@flow-control
If it's ok for everyone, i will start looking into sebastianbergmann/phpunit#2253 anyone already into this?
Andreas Möller
@localheinz
@sebastianbergmann What do you think about giving sebastianbergmann/phpunit#3809 a try? We could still revert if it doesn’t work as expected.
Marco Pivetta
@Ocramius
pardon the wording, but is there an un-fucked version of array_merge_recursive()? This is borked^2: https://3v4l.org/Wm2O6
Sebastian Bergmann
@sebastianbergmann
We break for lunch in ~ 5 minutes.
Marco Pivetta
@Ocramius
DON'T BREAK THE LUNCH!
Andreas Möller
@localheinz
@sebastianbergmann vimeo/psalm laeuft nun auch auf GitHub actions: https://github.com/sebastianbergmann/phpunit/pull/3820!
Ewout Pieter den Ouden
@epdenouden
🥁
Daniel Ruf
@DanielRuf
@epdenouden if you have time, can you review sebastianbergmann/phpunit#3822 Would be great =) I guess it should not be a greedy selector.
Ewout Pieter den Ouden
@epdenouden
thx! saw the alert
are you familiar enough with PHPT to guard the change with a test?
Marco Pivetta
@Ocramius

\PHPUnit\Util\Test::resolveElementToReflectionObjects

What...?!

Ewout Pieter den Ouden
@epdenouden
my brain is starting to skip tests
Sebastian Bergmann
@sebastianbergmann
Pending reservation: "Little Saigon", Seckenheimer Str. 81, 68165 Mannheim
Marco Pivetta
@Ocramius
PHP Fatal error:  Uncaught Error: Internal error: Failed to retrieve the reflection object in /home/ocramius/Documents/sebastianbergmann/phpunit/src/Annotation/DocBlock.php:273
GRRRRRR
Sebastian Bergmann
@sebastianbergmann
Dinner at 20:00 at "Little Saigon", Seckenheimer Str. 81, 68165 Mannheim
Ewout Pieter den Ouden
@epdenouden
@Ocramius are you trying to MockBlock?!
Marco Pivetta
@Ocramius
$this->reflector->getTraits() :S
I hate traits.
Ewout Pieter den Ouden
@epdenouden
gg no re
Sebastian Bergmann
@sebastianbergmann
That hate is a trait you should work on ;)
Marco Pivetta
@Ocramius
>.<
Oliver Klee
@oliverklee
While trying to fix some types, I discovered some bugs in TestSuiteIterator and discovered that it did not have any tests at all. So here they are: sebastianbergmann/phpunit#3825
Sebastian Bergmann
@sebastianbergmann
@oliverklee vimeo/psalm#1979
Karsten Frohwein
@kfrohwein
Hi Channel
Claudio Zizza
@SenseException
Andreas Möller
@localheinz
Sebastian Bergmann
@sebastianbergmann
Will look at it ASAP, was busy writing words: sebastianbergmann/phpunit#3799
Andreas Möller
@localheinz
@sebastianbergmann @Ocramius https://github.com/actions/stale
Daniel Ruf
@DanielRuf
I'm currently working on sebastianbergmann/phpunit#3793
Ewout Pieter den Ouden
@epdenouden
I've updated the issue labels to show what is being worked on: https://github.com/sebastianbergmann/phpunit/labels/code-sprint-september-2019
Ewout Pieter den Ouden
@epdenouden
image.png
was this the early alpha release of VSCode
Marco Pivetta
@Ocramius
GTKPHP?
Ewout Pieter den Ouden
@epdenouden
@Ocramius I was secretly hoping for a crossover between VB and PHP3
Sebastian Bergmann
@sebastianbergmann
PHP-GTK was a thing, once upon a time, with a PHP IDE written in PHP, for instance.
Ewout Pieter den Ouden
@epdenouden
[screams in TCL/TK]
Marco Pivetta
@Ocramius
    /**
     * @psalm-return array{
     *   __OFFSET: array<string, int>&array{__FILE: string},
     *   setting?: array<string, string>,
     *   extension_versions?: array<string, array{version: string, operator: string}>
     * }&array<
     *   string,
     *   string|array{version: string, operator: string}|array{constraint: string}|array<int|string, string>
     * >
     */
https://66.media.tumblr.com/8a8494980084a17ba8e791e49928a478/tumblr_ny4yexbOsJ1ukmr73o1_400.gif
Stephan Hochdörfer
@shochdoerfer
I'd like to order food in ~20min or so. Send me what you want to order from here: https://www.pizzeria-da-dina.de (food is sponsored by bitExpert). An keep the CoC in mind - no Pizza Hawaii :P
Marco Pivetta
@Ocramius
btw, that raised vimeo/psalm#2105
Daniel Ruf
@DanielRuf
@epdenouden not sure how we can get the classname and methodname for a testsuite (as these are multiple). Did you already started working on sebastianbergmann/phpunit#3730
Claudio Zizza
@SenseException
@sebastianbergmann sebastianbergmann/exporter#27
Marco Pivetta
@Ocramius
Florian Engelhardt
@flow-control
:thumbsup:
Andreas Heigl
@heiglandreas
I've prepared a PoC that allows creating Tests that do not inherit from TestCase. It might not be the right way but it could be a base of discussion: The code is at https://github.com/heiglandreas/phpunitstub
Ewout Pieter den Ouden
@epdenouden
@DanielRuf no, I wasn't able to start on that yet :( feel free to pick it up! shall I assign it to you?
Marco Pivetta
@Ocramius
@oliverklee
diff --git a/src/Framework/TestSuite.php b/src/Framework/TestSuite.php
index 2fca3b8dd..2e8f82338 100644
--- a/src/Framework/TestSuite.php
+++ b/src/Framework/TestSuite.php
@@ -617,7 +617,7 @@ public function testAt(int $index)
     /**
      * Returns the tests as an enumeration.
      *
-     * @return Test[]
+     * @return TestCase[]
      */
     public function tests(): array
     {
@@ -627,7 +627,7 @@ public function tests(): array
     /**
      * Set tests of the test suite
      *
-     * @param Test[] $tests
+     * @param TestCase[] $tests
      */
     public function setTests(array $tests): void
     {
diff --git a/src/Runner/TestSuiteSorter.php b/src/Runner/TestSuiteSorter.php
index fda662ac7..1a28f5e54 100644
--- a/src/Runner/TestSuiteSorter.php
+++ b/src/Runner/TestSuiteSorter.php
@@ -358,6 +358,10 @@ private function cmpSize(Test $a, Test $b): int
      * @param array<DataProviderTestSuite|TestCase> $tests
      *
      * @return array<DataProviderTestSuite|TestCase>
+     *
+     * @psalm-template T of array<DataProviderTestSuite|TestCase>
+     * @psalm-param T $tests
+     * @psalm-return T
      */
     private function resolveDependencies(array $tests): array
     {