Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 10:00
    localheinz synchronize #4153
  • 10:00
    sebastianbergmann commented #4155
  • 09:59
    localheinz edited #4153
  • 09:59
    localheinz labeled #4155
  • 09:59
    localheinz review_requested #4155
  • 09:59
    localheinz assigned #4155
  • 09:59
    localheinz opened #4155
  • 09:57

    sebastianbergmann on 9.0

    Fix json diff failure issues Update ChangeLog Merge branch '8.5' into 9.0 and 1 more (compare)

  • 09:57

    sebastianbergmann on 8.5

    Update ChangeLog (compare)

  • 09:57

    sebastianbergmann on master

    Fix json diff failure issues Update ChangeLog Merge branch '8.5' into 9.0 and 2 more (compare)

  • 09:55
    sebastianbergmann commented #4153
  • 09:54
    sebastianbergmann closed #4144
  • 09:53
    sebastianbergmann edited #4144
  • 09:52
    localheinz commented #4154
  • 09:52

    sebastianbergmann on 8.5

    Fix json diff failure issues (compare)

  • 09:52
    sebastianbergmann closed #4145
  • 09:51
    sebastianbergmann closed #4147
  • 09:51
    sebastianbergmann commented #4147
  • 09:51
    sebastianbergmann closed #4146
  • 09:51
    sebastianbergmann commented #4146
Ewout Pieter den Ouden
@epdenouden
are you familiar enough with PHPT to guard the change with a test?
Marco Pivetta
@Ocramius

\PHPUnit\Util\Test::resolveElementToReflectionObjects

What...?!

Ewout Pieter den Ouden
@epdenouden
my brain is starting to skip tests
Sebastian Bergmann
@sebastianbergmann
Pending reservation: "Little Saigon", Seckenheimer Str. 81, 68165 Mannheim
Marco Pivetta
@Ocramius
PHP Fatal error:  Uncaught Error: Internal error: Failed to retrieve the reflection object in /home/ocramius/Documents/sebastianbergmann/phpunit/src/Annotation/DocBlock.php:273
GRRRRRR
Sebastian Bergmann
@sebastianbergmann
Dinner at 20:00 at "Little Saigon", Seckenheimer Str. 81, 68165 Mannheim
Ewout Pieter den Ouden
@epdenouden
@Ocramius are you trying to MockBlock?!
Marco Pivetta
@Ocramius
$this->reflector->getTraits() :S
I hate traits.
Ewout Pieter den Ouden
@epdenouden
gg no re
Sebastian Bergmann
@sebastianbergmann
That hate is a trait you should work on ;)
Marco Pivetta
@Ocramius
>.<
Oliver Klee
@oliverklee
While trying to fix some types, I discovered some bugs in TestSuiteIterator and discovered that it did not have any tests at all. So here they are: sebastianbergmann/phpunit#3825
Sebastian Bergmann
@sebastianbergmann
@oliverklee vimeo/psalm#1979
Karsten Frohwein
@kfrohwein
Hi Channel
Claudio Zizza
@SenseException
Andreas Möller
@localheinz
Sebastian Bergmann
@sebastianbergmann
Will look at it ASAP, was busy writing words: sebastianbergmann/phpunit#3799
Andreas Möller
@localheinz
@sebastianbergmann @Ocramius https://github.com/actions/stale
Daniel Ruf
@DanielRuf
I'm currently working on sebastianbergmann/phpunit#3793
Ewout Pieter den Ouden
@epdenouden
I've updated the issue labels to show what is being worked on: https://github.com/sebastianbergmann/phpunit/labels/code-sprint-september-2019
Ewout Pieter den Ouden
@epdenouden
image.png
was this the early alpha release of VSCode
Marco Pivetta
@Ocramius
GTKPHP?
Ewout Pieter den Ouden
@epdenouden
@Ocramius I was secretly hoping for a crossover between VB and PHP3
Sebastian Bergmann
@sebastianbergmann
PHP-GTK was a thing, once upon a time, with a PHP IDE written in PHP, for instance.
Ewout Pieter den Ouden
@epdenouden
[screams in TCL/TK]
Marco Pivetta
@Ocramius
    /**
     * @psalm-return array{
     *   __OFFSET: array<string, int>&array{__FILE: string},
     *   setting?: array<string, string>,
     *   extension_versions?: array<string, array{version: string, operator: string}>
     * }&array<
     *   string,
     *   string|array{version: string, operator: string}|array{constraint: string}|array<int|string, string>
     * >
     */
https://66.media.tumblr.com/8a8494980084a17ba8e791e49928a478/tumblr_ny4yexbOsJ1ukmr73o1_400.gif
Stephan Hochdörfer
@shochdoerfer
I'd like to order food in ~20min or so. Send me what you want to order from here: https://www.pizzeria-da-dina.de (food is sponsored by bitExpert). An keep the CoC in mind - no Pizza Hawaii :P
Marco Pivetta
@Ocramius
btw, that raised vimeo/psalm#2105
Daniel Ruf
@DanielRuf
@epdenouden not sure how we can get the classname and methodname for a testsuite (as these are multiple). Did you already started working on sebastianbergmann/phpunit#3730
Claudio Zizza
@SenseException
@sebastianbergmann sebastianbergmann/exporter#27
Marco Pivetta
@Ocramius
Florian Engelhardt
@flow-control
:thumbsup:
Andreas Heigl
@heiglandreas
I've prepared a PoC that allows creating Tests that do not inherit from TestCase. It might not be the right way but it could be a base of discussion: The code is at https://github.com/heiglandreas/phpunitstub
Ewout Pieter den Ouden
@epdenouden
@DanielRuf no, I wasn't able to start on that yet :( feel free to pick it up! shall I assign it to you?
Marco Pivetta
@Ocramius
@oliverklee
diff --git a/src/Framework/TestSuite.php b/src/Framework/TestSuite.php
index 2fca3b8dd..2e8f82338 100644
--- a/src/Framework/TestSuite.php
+++ b/src/Framework/TestSuite.php
@@ -617,7 +617,7 @@ public function testAt(int $index)
     /**
      * Returns the tests as an enumeration.
      *
-     * @return Test[]
+     * @return TestCase[]
      */
     public function tests(): array
     {
@@ -627,7 +627,7 @@ public function tests(): array
     /**
      * Set tests of the test suite
      *
-     * @param Test[] $tests
+     * @param TestCase[] $tests
      */
     public function setTests(array $tests): void
     {
diff --git a/src/Runner/TestSuiteSorter.php b/src/Runner/TestSuiteSorter.php
index fda662ac7..1a28f5e54 100644
--- a/src/Runner/TestSuiteSorter.php
+++ b/src/Runner/TestSuiteSorter.php
@@ -358,6 +358,10 @@ private function cmpSize(Test $a, Test $b): int
      * @param array<DataProviderTestSuite|TestCase> $tests
      *
      * @return array<DataProviderTestSuite|TestCase>
+     *
+     * @psalm-template T of array<DataProviderTestSuite|TestCase>
+     * @psalm-param T $tests
+     * @psalm-return T
      */
     private function resolveDependencies(array $tests): array
     {
Ewout Pieter den Ouden
@epdenouden
@DanielRuf I'll fix up #3730 this week, it is related to TestDox which I had been working on
getting the TestSuite name isn't that hard, however I'll have to go over the edge cases
having said that, feel free to hurt yourself, if you really want to ;-)
Stephan Hochdörfer
@shochdoerfer
Food order done!
Marco Pivetta
@Ocramius
need a review and a performance analysis (from whoever worked on kcachegrind yesterday) at sebastianbergmann/phpunit#3836
Daniel Ruf
@DanielRuf

@DanielRuf I'll fix up #3730 this week, it is related to TestDox which I had been working on

I'm not so deep into it yet. Might make more sense if you take it up as you msay have a better overview of (possible) edge cases =)

Andreas Möller
@localheinz
This message was deleted
11EDC2BC-30CB-42D1-87C1-7F80E2B65850
@sebastianbergmann The error message regarding git when running psalm disappears with sebastianbergmann/phpunit#3838. However, the psalm error remains. Taking a look!
Andreas Möller
@localheinz
@sebastianbergmann @flow-control Global State
Ewout Pieter den Ouden
@epdenouden
@localheinz $_CARPET
Andreas Möller
@localheinz
@epdenouden wat