Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jan Molak
    @jan-molak
    it could be really cool, actually
    to have a top-level module doing the lookups and perhaps helping you set up your project
    npx serenity-js new
    
    What are you testing?
    - web
    - apis
    - mobile
    
    Which integration tool would you like?
    - playwright
    - webdriverio
    - protractor
    - selenium 4
    
    Would you like to use typescript?
    - yes
    - hell yes
    ;-)
    Nikita Chursin
    @nchursin
    perfect :D
    Jan Molak
    @jan-molak
    I've been looking for an excuse to introduce a command-line tool you'd invoke with npx serenity now ;-)
    Jan Molak
    @jan-molak
    @nchursin - have a look at serenity-js/serenity-js#989 when you have a chance; so far I've migrated frame switching-related APIs from @serenity-js/protractor to @serenity-js/web, but we'll need to check if those could work for Playwright?
    @viper3400 I've added Select for you so it will land as part of 3.0.0
    1 reply
    Nikita Chursin
    @nchursin
    I think there were some differences, as I started doing it the same way, but changed it afterwards AFAIR... I'll double check and ping you in the PR
    Jan Molak
    @jan-molak
    @viper3400 - Scroll is there too 😉
    Jan Molak
    @jan-molak

    @nchursin - check out https://github.com/serenity-js/serenity-js/tree/features/web where I made a couple of changes you might be interested in in the context of your work on Playwright integration:

    In particular:

    There's a couple of things still missing, like support for switching tabs/windows, managing cookies and so on, but the core pattern is reasonably stable I think.

    Any new integration module, like @serenity-js/playwright, will need to provide an appropriate implementation of BrowseTheWeb - example for WebdriverIO - https://github.com/serenity-js/serenity-js/blob/features/web/packages/webdriverio/src/screenplay/abilities/BrowseTheWebWithWebdriverIO.ts
    as well as integration tool-specific implementations of:

    3 replies
    Nikita Chursin
    @nchursin
    I took a brief look, seems good to me. I''ll bring my work on the playwright-test adapter to some logical ending and then will merge the serenity-js/web to my branch and will start migrating to the new approach. Shouldn't be hard
    Jan Molak
    @jan-molak
    Sounds great! Give me a shout when you have some spare cycles and we could look into window/frame handling
    viper3400
    @viper3400
    This message was deleted
    viper3400
    @viper3400

    Ahh, sorry guys. I had to delete my last posts, as they were just half of the truth and became misleading.

    With PR #987 some issues are fixed, but I still had have troubles in web-protractor-runner and web-webdriver-io. This is not about NodeJS version or numeric separators, as I thought yesterday. Turned out, that this is still about parallelism. @jan-molak turned this off for ci (https://github.com/serenity-js/serenity-js/blob/bce390d9c5e4658d53d6bccf8e396271ad398572/integration/web-protractor-runner/src/protractor.conf.ts#L13). But my local machine is not able to run the integration tests in parallel either. So turning of parallel executions brought me a step further.

    23 replies
    Jan Molak
    @jan-molak

    Hey folks, I managed to optimise the main CI/CD pipeline on master so that it takes ~20 minutes in total instead of ~33 minutes.
    The main difference is that it's now much more efficient with using lerna bootstrap command, which turned out to be the slowest part, especially on Windows builds.
    Here are the changes - https://github.com/serenity-js/serenity-js/pull/1006/files

    The way it affects other contributors is that lerna bootstrap is no longer linked from the postinstall script in root package.json, so when running the build locally instead of npm ci please run make install.
    I've updated the contributing guide to reflect that.

    @viper3400 -I'll get your fixes to timeouts merged tomorrow, thanks!
    @nchursin - features/web is ready for you to rebase against

    If you spot any issues - please let me know

    Manuel Fidalgo Sicilia
    @manuelfidalgo

    Hi all!
    has anybody using serenity-protractor experienced StaleElementReferenceException issues?
    After trying different 'spells', the only thing that fixed the issue was to use https://www.npmjs.com/package/ts-retry-promise to retry problematic interactions. For instance, for getting text of an element I have the following method:

    static async getTextWithRetry(webElement: ElementFinder): Promise<string> {
        let text: string
        await retry(
          async () => {
            text = await webElement.getText()
          },
          { retries: 3 }
        )
        return text
      }

    Would it make sense to add this kind of retry thing to the protractor module? It could have a specific config where you set number of retries/timeout

    9 replies
    Lokesh Babu Mani
    @lokezhbabuofficial

    @jan-molak is there any issue on the latest serenity-rest lib. I'm getting the following error upon setting the axiosInstance.

    error TS2345: Argument of type 'import("/app/node_modules/axios/index").AxiosInstance' is not assignable to parameter of type 'import("/app/node_modules/@serenity-js/rest/node_modules/axios/index").AxiosInstance'.
    The types of 'interceptors.response.use' are incompatible between these types.
        Types of parameters 'onFulfilled' and 'onFulfilled' are incompatible.
          Type 'T | Promise<T>' is not assignable to type 'AxiosResponse<any> | Promise<AxiosResponse<any>>'.
            Type 'T' is not assignable to type 'AxiosResponse<any> | Promise<AxiosResponse<any>>'.
              Type 'T' is not assignable to type 'Promise<AxiosResponse<any>>'.ts(2345)

    Version details:

    "@serenity-js/rest": {
          "version": "2.32.2"
    }
    
    "axios": {
          "version": "0.21.1"
    }
    5 replies
    viper3400
    @viper3400

    Hi @jan-molak,
    I got some minutes and updated my features/web branch. When I look at the current tests and at the GitHub actions, it looks like you have given up to run the integration-web tests at Windows at all? :D

    Anyway, with your latest tweaks I'm able to run the tests now at Windows locally without the flakiness which was seeded by the parallelization.

    But there is one thing left: I spotted this earlier (and probably each time when running the tests), but postponed to analyse it deeper, because of the other problems:
    https://github.com/serenity-js/serenity-js/blob/b322acde4d5b7c0c4c8cb47f0f61aa2b5ee0d101/integration-web/web/spec/screenplay/interactions/Press.spec.ts#L50

    This step won't run with Protractor in Windows for me. Seems like the SHIFT modifier key is not pressed any more when the Arrow Left keys are pressed. The input is not marked and then not deleted when the Backspace key is pressed.

    Find the failing Protractor Press spec in this report: https://drive.google.com/file/d/18gGbDfT6tOh9hJ18QLNkhyJYZXo6mt05/view?usp=sharing

    WDIO seems to handle this, but there are no screenshots attached in the report, so I can't control what is happening there.

    I'm also not sure if you release pipelines are really "green" as there are still errors in the logs. Are you aware of this?
    https://github.com/serenity-js/serenity-js/runs/3784611368?check_suite_focus=true

    19 replies
    Jan Molak
    @jan-molak
    Screenshot 2021-10-13 at 15.28.44.png
    d'oh, gitter uploads images to the main thread; oh well
    if there's an integration test failure, a Serenity BDD report can be downloaded from the summary page (the link at the bottom)
    75 replies
    Manuel Fidalgo Sicilia
    @manuelfidalgo
    Hi all,
    I have created a github action that executes serenityjs tests, store the results in Netlify and send a Slack notification:
    https://github.com/metis-ai/acceptance-tests-action
    You can use it or adapt it for your own needs
    1 reply
    Jan Molak
    @jan-molak
    @/all - 3.0.0-rc.0 is now available on npm, anyone fancy taking it for a spin? :-)
    4 replies
    Nikita Chursin
    @nchursin

    @jan-molak hey mate, I finally got to re-writing the playwright integration, and actually about half-way through it.

    The new approach is amazing - much easier to add a new implementation than it was!

    I have a couple of questions though:

    1. What do you use to int-test the whole thing? I have some unit-tests but wanted to double check the flow
    2. How the BrowseTheWeb.sendKeys supposed to work? Are there any tests for it I can look at? I want to understand the outcome of inputs like [ 'Shift', 'h', 'i' ] or [ 'Ctrl', 'a' ] - do I suppose to join the pairs like 'Shift+h' or should I hold 'Shift', so it's like [ 'Shift+h', 'Shift+a' ]?
    20 replies
    Nikita Chursin
    @nchursin

    I'm trying to implement the executeScript, but struggling with this error: '[arg: Unboxed<InnerArguments>]' is assignable to the constraint of y: any) => actualKeys.push({ 295 type 'InnerArguments', but 'InnerArguments' could be instantiated with a d: 'down', 296 allPages(): Promise<SerenityPage[]> { different subtype of constraint 'any[]'. Have you had anything like this for other implementation? I'm realy not sure this is coming from

    Here's the method from pw i'm using: https://playwright.dev/docs/api/class-page#page-evaluate

    here's the code:

    async executeScript<Result, InnerArguments extends any[]>(
        script: string | ((...parameters: InnerArguments) => Result),
        ...args: InnerArguments
    ): Promise<Result> {
        const nativeArguments = await Promise.all(
            args.map(
                arg => arg instanceof PlaywrightPageElement ? arg.nativeElement() : arg
            )
        ) as InnerArguments;
    
        const page =  await this.page();
        return page.evaluate<Result, InnerArguments>(script, nativeArguments);
    }
    19 replies
    Jan Molak
    @jan-molak
    👍
    Nikita Chursin
    @nchursin
    I'm working on the PlaywrightPage and TBH it feels like the closeOthersmethod should not belong to the Page class itself. I think a page should not be aware of the other pages. What do you think?
    1 reply
    Jan Molak
    @jan-molak
    Yeah, I've been thinking about it too. The reason I put it on Page is because if it was externalised, we'd have to provide Page as argument, e.g. Switch.to(Page.called(...)), Close.pagesOtherThan(Page.called(...)), but those interactions would still have to call methods either on the Page itself (so we end up in the same place), or on BrowseTheWeb, which then makes some page-specific methods to live on Page and some on BrowseTheWeb, which felt a bit messy
    Happy to change my mind though if we can come up with something more appropriate
    Nikita Chursin
    @nchursin

    But we can make them actually generic on the BrowseTheWebLevel, at least the close methods. Also, we have other switchTo kinda methods there, e.g. switchToFrame, so it has some logic behind moving switchToPage there.

    I don't think it's a big deal BrowseTheWeb has interactions with Page - it's dependent on it anyway, cause needs to return pages (methods page, allPages). But closeOthers on a page may be a trouble, cause we actually have to expose the whole browser context to a page... I don't like this, feels wrong

    There's what i suggest

    closePage(page: SerenityPage): Promise<void> {
        // generic implementation stored in abstract BrowseTheWeb
        // so no specifics need to be made for Pw/Wdio/Protractor
        return page.close();
    }
    async closeOtherPages(page: SerenityPage): Promise<void> {
        // generic implementation stored in abstract BrowseTheWeb
        // so no specifics need to be made for Pw/Wdio/Protractor
        const allPages = await this.allPages();
        return Promise.all(allPages
            .filter((pageToCheck) => page.handle === pageToCheck.handle)
            .map((pageToClose) => pageToClose.close()));
    }
    switchToPage(page: SerenityPage): Promise<void> {
        // new method in BrowseTheWeb
        // Implementation specific logic goes here based on page.handle()
    }
    switchToFrame(targetOrIndex: string | number | PageElement<any, any>): Promise<void> {
        // exsiting method in BrowseTheWeb
    }
    Though there might be a better approach than exposing handle
    Jan Molak
    @jan-molak
    RC3 is now available on npm
    And the latest changes are on main
    viper3400
    @viper3400

    Hi @jan-molak

    I went on with migration to Serenity/JS 3 but now I struggle with the following pattern I used in Serenity/JS 2:

    const InputContainers = () =>
        PageElements.located(By.css('.input-container')).describedAs('input containers');
    
    const Labels = () =>
        PageElements.located(By.css('label')).describedAs('label');
    
    const InputContainerForLabelWithText = (text: string) =>
         InputContainers().where(Text.ofAll(Labels()), contain(text)).first();

    I have parent cotainers which contain labels. I want to locate the first container, where it's label contains the given text.

    This pattern worked before, but now I assume it does not work with the Text.ofAll within the .where()?

    Error message is:

    Argument of type 'Question<Promise<string[]>> & Adapter<string[]>' is not assignable to parameter of type 'MetaQuestion<PageElement<unknown>, string[] | Promise<string[]>>'.
      Property 'of' is missing in type 'Question<Promise<string[]>> & Adapter<string[]>' but required in type 'MetaQuestion<PageElement<unknown>, string[] | Promise<string[]>>'.ts(2345)
    MetaQuestion.d.ts(29, 5): 'of' is declared here.

    Do you have an idea?

    39 replies
    viper3400
    @viper3400

    @jan-molak, a strange thing while migrating to 3.0:
    Though my test runs (login to app, navigate to some feautre a simple Wait.for(Duration.ofSeconds(10)) throws this error:

      User in role administrator navigates to feature
        User in role administrator navigates to the episode feature: xxx
          User in role administrator checks whether <<feature link for xxx>>.of(<<feature navigation bar>>.of(<<selected page>>)) does become visible
            User in role administrator hovers the mouse over <<arrow icon which reveals more features>>.of(<<feature navigation bar>>.of(<<selected  page>>)) (206ms)
            User in role administrator clicks on <<arrow icon which reveals more features>>.of(<<feature navigation bar>>.of(<<selected  page>>)) (85ms)
            User in role administrator hovers the mouse over <<expanded menu>>.of(<<feature navigation bar>>.of(<<selected  page>>)) (191ms)
            User in role administrator clicks on <<feature link for xxx>>.of(<<expanded menu>>.of(<<feature navigation bar>>.of(<<selected  page>>))) (153ms)
            User in role administrator waits for 10s (0ms)
              ConfigurationError: User in role administrator can't BrowseTheWeb yet. Did you give them the ability to do so?
                Execution failed with error (6s 908ms)
    
      ConfigurationError: User in role administrator can't BrowseTheWeb yet. Did you give them the ability to do so?
          at Actor.abilityTo (C:\dev\git\xxx\e2e-serenityjs\node_modules\@serenity-js\core\src\screenplay\actor\Actor.ts:47:19)
          at Function.as (C:\dev\git\xxx\e2e-serenityjs\node_modules\@serenity-js\web\src\screenplay\abilities\BrowseTheWeb.ts:18:22)
          at C:\dev\git\xxx\e2e-serenityjs\node_modules\@serenity-js\web\src\screenplay\interactions\Wait.ts:184:44

    I think my actor has the ability, how else the rest of the test shall run?

    Jan Molak
    @jan-molak
    Hmm, that's interesting, would you be able to reproduce it with any of the template projects?
    40 replies
    Nikita Chursin
    @nchursin
    @jan-molak is this Page's handle thing is used anyhow except for toString method? I see it's protected, so probably not, but wanted to double-check
    13 replies
    Nikita Chursin
    @nchursin
    @jan-molak I see you marked switchToFrame and so on as todo: remove in wdio implementation. Do I need to bother implementing those?
    7 replies
    Nikita Chursin
    @nchursin
    @jan-molak there's an issue with the dialog concept in pw: https://playwright.dev/docs/api/class-page#page-event-dialog
    Basically, you ca only interact with a dialog in the listener for page.on('dialog'), otherwise it just hangs. Dialogs are dismissed by default
    Not sure how to handle this in the current framewok
    8 replies
    viper3400
    @viper3400

    Hi @jan-molak, me again with some testing result of Serenity/JS 3.x and back with my 'dialog' pattern :D

    Remember that?

    class Targets {
        Dialogs = () => PageElements.located(By.css('.ui-dialog')).describedAs('visible modal dialogs');
        DialogTitle = () => PageElement.located(By.css('.ui-dialog-title')).describedAs(`dialog title`);
    
        DialogWithTitle = (dialogTitle: string) =>
            this.Dialogs()
             .where(Text.of(this.DialogTitle()), includes(dialogTitle))
             .first();
    }

    Now, I wan't to check, whether there is a dialog with a special title and if so, click a button.

    Check.whether(DiaglogWithTitle('DISCARD'), isVisible())
            .andIfSo( Click.on(...))

    This worked perfect with Serenity/JS 2.x (with Jasmine & Protractor & the targets) but now in 3.x (using mocha, wdio, devtools & page elements) I get:

    LogicError: Can't retrieve the first item from a list with 0 items: [ ]

    Why it makes sense logicaly, it introduces more logic into my tests: As workaround I now first check, if there are any dialogs at all ...

    Check.whether(this.Dialogs().count(), isGreaterThan(0)).andIfSo(
          Check.whether(DiaglogWithTitle('DISCARD'), isVisible()).andIfSo(
             Click.on(...)
                    )
                )

    It's okay for me and just wanted you to know, just another point on my migration list...

    59 replies
    Jan Molak
    @jan-molak
    OK, I've removed colors from 3.0 RC; 3.0.0-rc.6 coming right up
    1 reply
    Jan Molak
    @jan-molak
    Hey folks, so I've started to work on adding better support for shadow DOM (serenity-js/serenity-js#1085), and that made me think about the selectors we use in our automated tests. What do you think, should Serenity/JS mirror the selectors UI automation tools provide (e.g. by CSS, by XPath, by link text and so on), which has the advantage of making the framework feel familiar, or should we try to simplify / improve / re-think how we selectors are used in general?
    6 replies
    Jan Molak
    @jan-molak
    @nchursin - have you ever tried rendering individual UI components in Playwright?
    viper3400
    @viper3400
    @jan-molak I have an issue since I've started migration to wdio using devtools. This is, that all our custom css overlay dropdowns will open above the search box instead of beneath the box. If I turn of Photographer.whoWill(TakePhotosOfInteractions) in my config all is fine. With this setting, there is a lot of visible "flickering" each time a screenshot is taken (when not running in headless) mode.
    52 replies
    viper3400
    @viper3400
    grafik.png
    grafik.png
    Wu, Yun
    @yunwu-cn
    @jan-molak I've raised one issue that I've recently noticed while using serenity-js. serenity-js/serenity-js#1181 One proposed solution is using if (config[key] !== null && config[key] !== undefined ) for line 62. However, I have some issue when doing make install of the repo in local.
    3 replies
    Anand Alok
    @iamanandalok_twitter
    image.png
    Hi Everyone, does anyone have a sample code to read and store the web table data dynamically? For example on the basis of table header I want to store in List of dto structure to access through java classes. Table size is dynamic .