Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jan Molak
    @jan-molak
    Hi folks! Quite a few people have spoken to me recently on various channels expressing their interest in contributing new features/documentation improvements/bug fixes to Serenity/JS, so I thought I'd start a dedicated channel for us to talk about your ideas :-)
    Nikita Chursin
    @nchursin
    Hey guys
    Do you think it makes sense to add a CONTRIBUTING.md file to the root folder with a link to the site page? Or add a link to the readme? I only managed to find the guidelines by searching through the repo... Probably it's only my problem though :)
    16 replies
    Jan Molak
    @jan-molak
    Hey @nchursin! Thanks again for your work on @serenity-js/playwright! I've reviewed the module and added some suggestions under #911
    1 reply
    Jan Molak
    @jan-molak
    Fab, thank you!
    Jan Molak
    @jan-molak
    @nchursin - I see you've requested access to Snyk, you should have an invitation in your inbox
    2 replies
    Nikita Chursin
    @nchursin
    @jan-molak I’m looking at the locators.ts in webdriverIO implementation. And I don’t fully understand the reasoning behind passing locateOne and locateAll functions as parameters. Could you please elaborate on that? To me it just seems simpler to do this logic in the Locator class itself, instead of in each and every Locators method
    4 replies
    Jan Molak
    @jan-molak
    @nchursin what would the alternative look like, please?
    Nikita Chursin
    @nchursin
    I was thinking about something like this. I removed the comments in the proposal to make it easier to read
    Nikita Chursin
    @nchursin
    Also, this could be almost entirely re-used by playwright. If we change
    BrowseTheWeb.as(actor).browser.$(this.selector)
    to
    BrowseTheWeb.as(actor).$(this.selector)
    this will be entirely re-usable
    11 replies
    Still need to change the return type to ElementHandle though
    Jan Molak
    @jan-molak
    @nchursin - I've merged in serenity-js/serenity-js#923 and a bunch of other minor dependency updates, thanks!
    Nikita Chursin
    @nchursin
    Hey @jan-molak - what do you use as an IDE? I use vscode but mocha plugins I have are killing me - it takes several sec per test to run, hangs sometimes and a bunch of other issues. I wonder if you can advise something else to use?
    1 reply
    Jan Molak
    @jan-molak
    I use IntelliJ Idea
    Jest is cool, maybe we should write an adapter one day :-)
    Although Mocha shouldn't be that slow
    Can you run the tests from the command line and compare performance?
    Nikita Chursin
    @nchursin
    yeah, it’s plugin that slows things down
    I created a script to run watch on uncommitted files, so I’m fine now
    Jan Molak
    @jan-molak
    👍