These are chat archives for shaarli/Shaarli

1st
Feb 2018
ArthurHoaro
@ArthurHoaro
Feb 01 19:05
Sorry, I don't understand your answer. Once the vendor/ folder is included in the release, everything works out of the box, so shouldn't these file be export-ignore in .gitattributes? The underlying question here is should I ignore package.json and yarn.lock?
VirtualTam
@virtualtam
Feb 01 20:40
we provide two types of archives:
  1. archives generated from source code by Github, using the git-archive command
  2. release archives we generate locally, using the git-archive command and Composer
for the first archives to be of any use, they must contain dependency management config files, hence these should not be excluded by .gitattributes
as a consequence, release archives we provide also contain those config files, though they are of limited use in this context
for these not to be part of release archives, we would have to add removal commands to Make targets
VirtualTam
@virtualtam
Feb 01 20:46
this requires extra work, but could be done if we want to provide release archives that exclusively contain resources used to run Shaarli
ArthurHoaro
@ArthurHoaro
Feb 01 22:45
Oh ok, thanks for the explanation, I didn't know that it was affecting the archives auto-generated by Github
VirtualTam
@virtualtam
Feb 01 22:51
yep, if I remember correctly we had to revert one of my commits at some point, that added composer resources to export-ignore and prevented Docker images from building :D