These are chat archives for shipitjs/shipit

23rd
Jun 2015
Fabian Becker
@halfdan
Jun 23 2015 10:48
@cognitom very cool
@neoziro you around?
Fabian Becker
@halfdan
Jun 23 2015 11:00
@neoziro I'm working on shipitjs/shipit#75 and would like your input. I'm thinking of dropping the -- to just have shipit init, shipit plugin etc. - this would make those words reserved keywords (cannot be used as environment names)
Greg Bergé
@neoziro
Jun 23 2015 11:53
@cognitom very cool
@halfdan I am not sure
@halfdan it can be confusing to have reserved words
Fabian Becker
@halfdan
Jun 23 2015 11:56
true, I however don't see them conflicting with environments
Greg Bergé
@neoziro
Jun 23 2015 11:56
@halfdan yes but it's not "coherent"
Fabian Becker
@halfdan
Jun 23 2015 11:56
and the cli call would look a bit nicer
true
Greg Bergé
@neoziro
Jun 23 2015 11:57
I think that in v2.0.0 we can do
shipit run [env] [task..]
shipit init
shipit plugin
Fabian Becker
@halfdan
Jun 23 2015 11:58
that'd be sweet
so what's the roadmap to v2.0.0?
for now
but it's the occasion to make some breaking changes
Fabian Becker
@halfdan
Jun 23 2015 11:58
for sure
well I PR'd the default task thing
do you want to make another 1.x release?
or can I hack away on the above?
Greg Bergé
@neoziro
Jun 23 2015 11:59
hmm
I tagged default task for v2
but I think it's not a breaking change because the command shipit [env] didn't work before
Fabian Becker
@halfdan
Jun 23 2015 12:00
yup
Greg Bergé
@neoziro
Jun 23 2015 12:03
@halfdan about jshint I don't want to add it, because everyone has different coding style, and it's not very important. I prefer to encourage people to contribute, and jshint can be a problem.
Fabian Becker
@halfdan
Jun 23 2015 12:03
the rules aren't very strict
and it helps to have a clear coding style - we're using it at ghost
and people never complained about it
Greg Bergé
@neoziro
Jun 23 2015 12:04
I use it too, on my project, etc.. But for an open source project, I prefer to not have it. I can fix all coding style every month for an example, it's very easy.
Fabian Becker
@halfdan
Jun 23 2015 12:06
ok - I can remove the jshint call on npm test then - but would you agree to not have braceless ifs?
Greg Bergé
@neoziro
Jun 23 2015 12:06
yeah, I use braceless if in my code, I think it's not a problem
Fabian Becker
@halfdan
Jun 23 2015 12:07
it's pretty bad to read
Greg Bergé
@neoziro
Jun 23 2015 12:07
just a question of point of view, that's why I don't want to restrict rules
Fabian Becker
@halfdan
Jun 23 2015 12:08
well you said you can fix all coding style every month..
hence the question of whether you'd be willing to not do braceless ifs
Greg Bergé
@neoziro
Jun 23 2015 12:09
I use braceless ifs yes
Fabian Becker
@halfdan
Jun 23 2015 12:09
oO
it's my eslintrc
Fabian Becker
@halfdan
Jun 23 2015 12:13
and you don't want curly: [2, "all"]?
Fabian Becker
@halfdan
Jun 23 2015 12:25
@neoziro Are you working on anything currently?
Can I start refactoring/rewriting for v2.0.0?
Tim Kelty
@timkelty
Jun 23 2015 12:30
Another option for 2.x would be to pass env as an -arg (shipit run deploy -e production)
Fabian Becker
@halfdan
Jun 23 2015 12:30
that would be in line with ember-cli
Tim Kelty
@timkelty
Jun 23 2015 12:30
I guess its just preference but it makes sense to me
Fabian Becker
@halfdan
Jun 23 2015 12:31
ember deploy —environment=production
Tim Kelty
@timkelty
Jun 23 2015 12:31
You can use Yargs or something similar to easily alias --environment, -e, etc.
Tim Kelty
@timkelty
Jun 23 2015 12:39
seems like a good move to me as those are truly "variable"
Fabian Becker
@halfdan
Jun 23 2015 12:39
:+1:
@timkelty could even have a default environment (development) that could be configurable in config
so you can just shipit run deploy and it defaults to -e development
Tim Kelty
@timkelty
Jun 23 2015 12:43
yep!
In fact....shipitjs/shipit#38
speak up there, maybe it can be re-evaluated for 2.x
Fabian Becker
@halfdan
Jun 23 2015 12:51
@timkelty just did
the biggest benefit is that lazy people like me don’t have to remember to type -e foobar all the time
Tim Kelty
@timkelty
Jun 23 2015 13:01
:)
And for me, I like to set a default based on a git branch. A default config option would allow me to hook that up myself
Fabian Becker
@halfdan
Jun 23 2015 13:03
yup sounds reasonable
it should at least be supported
Tsutomu Kawamura
@cognitom
Jun 23 2015 13:21
:+1: for default env
sounds nice