@caseyjenks
just gotta get past npm, acting funky on me this morning
@alexlafroscia I made a shepherd-1.0 branch, we need to figure out how to make all that work sometime soon. I tried simply updating, and it gave me some errors
Are you still thinking about making an Ember-Specific tour addon?
We are still using ember-shepherd at work
We have to use an instanceInitializer now
I’m not familiar with intanceInitializers, are you @alexlafroscia?
I should have some time this weekend
Older versions don't support instance initializers, though, so we will need to make sure we tag the release before switching to them for people that can't use them
@alexlafroscia I spoke with some people on the Ember Slack and they said we should be able to do something like this:
export function initialize(registry, application) {
application.inject('service:tour', 'controller', 'controller:application');
application.inject('route', 'tour', 'service:tour');
application.inject('controller', 'tour', 'service:tour');
}
export default {
name: 'tour',
initialize: initialize
};
They also said injecting controllers into non-controllers can no longer be done
There is apparently a new router service now, something like
service:-router
Should be able to get currentPath using that, and we wouldn’t need to inject the application controller
Like maybe a particular dependency version that doesn't support them yet or something?
I've contributed to
ember-redirect as well, and that addon uses instance initializers. I can't tell what's different that makes it not work for ember-shepherd
I noticed that the tests aren't passing but haven't looked into why yet