Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 01 10:29
    dependabot[bot] edited #1230
  • Dec 01 10:28
    dependabot[bot] edited #1230
  • Dec 01 10:28
    dependabot[bot] synchronize #1230
  • Dec 01 10:27

    dependabot[bot] on npm_and_yarn

    Bump ember-data from 4.1.0 to 4… (compare)

  • Dec 01 10:27
    dependabot[bot] edited #1230
  • Dec 01 10:26
    dependabot[bot] edited #1230
  • Dec 01 10:26

    dependabot[bot] on npm_and_yarn

    (compare)

  • Dec 01 10:25

    github-actions[bot] on main

    Bump eslint-plugin-ember from 1… (compare)

  • Dec 01 10:25
    github-actions[bot] closed #1250
  • Dec 01 10:19
    dependabot[bot] labeled #1250
  • Dec 01 10:19

    dependabot[bot] on npm_and_yarn

    Bump eslint-plugin-ember from 1… (compare)

  • Dec 01 10:19
    dependabot[bot] opened #1250
  • Dec 01 03:13
    dependabot[bot] synchronize #1230
  • Dec 01 03:13

    dependabot[bot] on npm_and_yarn

    Bump ember-data from 4.1.0 to 4… (compare)

  • Dec 01 03:13
    dependabot[bot] edited #1230
  • Dec 01 03:10
    dependabot[bot] synchronize #1230
  • Dec 01 03:10
    dependabot[bot] edited #1230
  • Dec 01 03:10

    dependabot[bot] on npm_and_yarn

    Bump ember-data from 4.1.0 to 4… (compare)

  • Dec 01 03:10
    dependabot[bot] edited #1230
  • Dec 01 03:10

    rwwagner90 on gh-pages

    Deployed e177fbe (compare)

Robert Wagner
@rwwagner90
npm is always giving me trouble
Emílio Faria
@ecfaria
@rwwagner90 , I'm sorry, I forgot to come here and thanks you! I used your code to make a custom component, and it worked! Tks a lot!
Robert Wagner
@rwwagner90
@ecfaria great! Glad it worked for you. Feel free to star the repo if you like it :smiley:
Emílio Faria
@ecfaria
@rwwagner90 yeah! for sure!
Robert Wagner
@rwwagner90
@ecfaria feel free to let us know any shortcomings or features you’d like to see in the future as well
Casey Jenks
@caseyjenks
@rwwagner90 Working beautifully, thanks!
Robert Wagner
@rwwagner90
@caseyjenks glad to hear it. Let me know if you have any further issues, and feel free to throw a star our way if you don’t mind :smiley:
Casey Jenks
@caseyjenks
done! thanks for the help
Robert Wagner
@rwwagner90
You’re quite welcome. Good catch there. Impossible to catch unless you do a fresh install of ember-shepherd, which we should obviously try to do more haha
@alexlafroscia I made a shepherd-1.0 branch, we need to figure out how to make all that work sometime soon. I tried simply updating, and it gave me some errors
Robert Wagner
@rwwagner90
@alexlafroscia I will probably get the shepherd 1.0 stuff done this weekend or next week. Then we can build off of that to get ember-shepherd 1.0 and switch gears to writing our own tour library as well.
Alex LaFroscia
@alexlafroscia
@rwwagner90 sounds like a good plan to me!
Robert Wagner
@rwwagner90
@alexlafroscia just wanted to update you. I’ve been insanely busy and just now finally have some free time. Planning to button all this up this weekend, I hope.
Alex LaFroscia
@alexlafroscia
@rwwagner90 no worries man, I'm been really busy too. I don't know what I'll be able to do this weekend, and then I'm going to Wicked Good Ember next week
Are you still thinking about making an Ember-Specific tour addon?
Robert Wagner
@rwwagner90
Nice. Wicked Good Ember should be cool. Yeah, I think we should. I’m inclined to let Ember 2.0 arrive and settle a bit first though
Robert Wagner
@rwwagner90
@alexlafroscia how was Wicked Good Ember? I finally got around to making ember-shepherd work with the new tether-shepherd. I think now we should just wait until Ember 2.0 and fix any deprecations and such, then call this 1.0 and move on. Sound good?
Robert Wagner
@rwwagner90
@alexlafroscia are you still using ember-shepherd at work?
Robert Wagner
@rwwagner90
@alexlafroscia you there?
Alex LaFroscia
@alexlafroscia
Hey! WickedGood was great, learned some really cool stuff. I think that sounds like a good plan
We are still using ember-shepherd at work
Robert Wagner
@rwwagner90
Okay, cool. We do have a deprecation or two to figure out, involving initializers.
We have to use an instanceInitializer now
I’m not familiar with intanceInitializers, are you @alexlafroscia?
Alex LaFroscia
@alexlafroscia
I am, and I've fixed those issues before for other things. I'll figure it out
I should have some time this weekend
Older versions don't support instance initializers, though, so we will need to make sure we tag the release before switching to them for people that can't use them
Robert Wagner
@rwwagner90
@alexlafroscia I spoke with some people on the Ember Slack and they said we should be able to do something like this:
export function initialize(registry, application) {
  application.inject('service:tour', 'controller', 'controller:application');
  application.inject('route', 'tour', 'service:tour');
  application.inject('controller', 'tour', 'service:tour');
}

export default {
  name: 'tour',
  initialize: initialize
};
They also said injecting controllers into non-controllers can no longer be done
There is apparently a new router service now, something like service:-router
Should be able to get currentPath using that, and we wouldn’t need to inject the application controller
Alex LaFroscia
@alexlafroscia
Alright, I'll look into that, too
Robert Wagner
@rwwagner90
:+1:
Alex LaFroscia
@alexlafroscia
Hey, I've been trying to migrate to using instance initializers but haven't been able to get them working with the addon. Do you know if there's something weird with instance initializers in addons?
Like maybe a particular dependency version that doesn't support them yet or something?
I've contributed to ember-redirect as well, and that addon uses instance initializers. I can't tell what's different that makes it not work for ember-shepherd
Alex LaFroscia
@alexlafroscia
Nevermind, we just had a bunch of dependencies that needed to be updated
Robert Wagner
@rwwagner90
@alexlafroscia sorry, I didn’t see this until now. Did you get it figured out?
Alex LaFroscia
@alexlafroscia
Yeah, I figured out why they weren't working. I think we had an outdated version of the load-initializers dependency. Updating a lot of outdated deps were part of the PR I submitted
I noticed that the tests aren't passing but haven't looked into why yet
Robert Wagner
@rwwagner90
Okay, gotcha.
Robert Wagner
@rwwagner90
@alexlafroscia I'm stepping away from Ember for awhile. I started a new job using Angular. With that in mind, I'd love to get my other addons whipped into shape and to 1.0, then just leave them in maintenance mode, unless there is a huge surge in demand for some reason. Would you like to help out with that?
Alex LaFroscia
@alexlafroscia
I dunno, I have my own projects that I'm taking on and if I'm not using those packages, I can't see myself maintaining them
Robert Wagner
@rwwagner90
@alexlafroscia I didn't mean you would maintain them, I meant you would just help get them to 1.0 with me, but if you're busy, no worries at all. Just thought I would ask!
Alex LaFroscia
@alexlafroscia
Do they have tests written already? If so, I can take a look and see what they need.
Robert Wagner
@rwwagner90
@alexlafroscia I don't think so, but I will write them and try to wrap them up. Just need a second set of eyes to look at it and help out
Alex LaFroscia
@alexlafroscia
Alright, I could do that