Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 10:31

    dependabot[bot] on npm_and_yarn

    (compare)

  • 10:31

    github-actions[bot] on main

    Bump ember-auto-import from 2.4… (compare)

  • 10:31
    github-actions[bot] closed #1248
  • 10:30

    dependabot[bot] on npm_and_yarn

    (compare)

  • 10:30
    github-actions[bot] closed #1249
  • 10:30

    github-actions[bot] on main

    Bump eslint-plugin-qunit from 7… (compare)

  • 10:25
    dependabot[bot] labeled #1249
  • 10:25
    dependabot[bot] opened #1249
  • 10:25

    dependabot[bot] on npm_and_yarn

    Bump eslint-plugin-qunit from 7… (compare)

  • 10:24
    dependabot[bot] labeled #1248
  • 10:24
    dependabot[bot] opened #1248
  • 10:24

    dependabot[bot] on npm_and_yarn

    Bump ember-auto-import from 2.4… (compare)

  • Nov 29 10:33

    dependabot[bot] on npm_and_yarn

    (compare)

  • Nov 29 10:33

    github-actions[bot] on main

    Bump ember-source from 4.8.2 to… (compare)

  • Nov 29 10:33
    github-actions[bot] closed #1247
  • Nov 29 10:32

    dependabot[bot] on npm_and_yarn

    (compare)

  • Nov 29 10:32
    themorya starred rwwagner90/ember-shepherd
  • Nov 29 10:32

    github-actions[bot] on main

    Bump ember-template-lint from 5… (compare)

  • Nov 29 10:32
    github-actions[bot] closed #1245
  • Nov 29 10:31

    dependabot[bot] on npm_and_yarn

    (compare)

Robert Wagner
@rwwagner90
@alexlafroscia how was Wicked Good Ember? I finally got around to making ember-shepherd work with the new tether-shepherd. I think now we should just wait until Ember 2.0 and fix any deprecations and such, then call this 1.0 and move on. Sound good?
Robert Wagner
@rwwagner90
@alexlafroscia are you still using ember-shepherd at work?
Robert Wagner
@rwwagner90
@alexlafroscia you there?
Alex LaFroscia
@alexlafroscia
Hey! WickedGood was great, learned some really cool stuff. I think that sounds like a good plan
We are still using ember-shepherd at work
Robert Wagner
@rwwagner90
Okay, cool. We do have a deprecation or two to figure out, involving initializers.
We have to use an instanceInitializer now
I’m not familiar with intanceInitializers, are you @alexlafroscia?
Alex LaFroscia
@alexlafroscia
I am, and I've fixed those issues before for other things. I'll figure it out
I should have some time this weekend
Older versions don't support instance initializers, though, so we will need to make sure we tag the release before switching to them for people that can't use them
Robert Wagner
@rwwagner90
@alexlafroscia I spoke with some people on the Ember Slack and they said we should be able to do something like this:
export function initialize(registry, application) {
  application.inject('service:tour', 'controller', 'controller:application');
  application.inject('route', 'tour', 'service:tour');
  application.inject('controller', 'tour', 'service:tour');
}

export default {
  name: 'tour',
  initialize: initialize
};
They also said injecting controllers into non-controllers can no longer be done
There is apparently a new router service now, something like service:-router
Should be able to get currentPath using that, and we wouldn’t need to inject the application controller
Alex LaFroscia
@alexlafroscia
Alright, I'll look into that, too
Robert Wagner
@rwwagner90
:+1:
Alex LaFroscia
@alexlafroscia
Hey, I've been trying to migrate to using instance initializers but haven't been able to get them working with the addon. Do you know if there's something weird with instance initializers in addons?
Like maybe a particular dependency version that doesn't support them yet or something?
I've contributed to ember-redirect as well, and that addon uses instance initializers. I can't tell what's different that makes it not work for ember-shepherd
Alex LaFroscia
@alexlafroscia
Nevermind, we just had a bunch of dependencies that needed to be updated
Robert Wagner
@rwwagner90
@alexlafroscia sorry, I didn’t see this until now. Did you get it figured out?
Alex LaFroscia
@alexlafroscia
Yeah, I figured out why they weren't working. I think we had an outdated version of the load-initializers dependency. Updating a lot of outdated deps were part of the PR I submitted
I noticed that the tests aren't passing but haven't looked into why yet
Robert Wagner
@rwwagner90
Okay, gotcha.
Robert Wagner
@rwwagner90
@alexlafroscia I'm stepping away from Ember for awhile. I started a new job using Angular. With that in mind, I'd love to get my other addons whipped into shape and to 1.0, then just leave them in maintenance mode, unless there is a huge surge in demand for some reason. Would you like to help out with that?
Alex LaFroscia
@alexlafroscia
I dunno, I have my own projects that I'm taking on and if I'm not using those packages, I can't see myself maintaining them
Robert Wagner
@rwwagner90
@alexlafroscia I didn't mean you would maintain them, I meant you would just help get them to 1.0 with me, but if you're busy, no worries at all. Just thought I would ask!
Alex LaFroscia
@alexlafroscia
Do they have tests written already? If so, I can take a look and see what they need.
Robert Wagner
@rwwagner90
@alexlafroscia I don't think so, but I will write them and try to wrap them up. Just need a second set of eyes to look at it and help out
Alex LaFroscia
@alexlafroscia
Alright, I could do that
Robert Wagner
@rwwagner90
@alexlafroscia okay, awesome. What projects are you working on now? I’d be glad to help you out, if you need it as well. You’ve helped a lot with ember-shepherd
Alex LaFroscia
@alexlafroscia
My Ember vim plugin, and I'm going to be adding a feature to the CLI itself starting today. Not really stuff I need help with necessarily, but I appreciate it!
Chris Miller
@chrismllr
Hey @rwwagner90 , I'm getting a certain error on ember serve, ENOENT, no such file or directory '/Users/etc/etc/tmp/concat_with_maps-input_base_path-cOIMPVzR.tmp/0/bower_components/tether/js/utils.js'
It would appear its looking in the wrong place for the tether utils.js file. Looking in bower components, its inside tether/src/js/utils.js
Oh no, I actually just realized I am using ember-tether as well. It seems to be in their code. They are including an older version of Tether in their build, and the new version you include in ember-shepherd is structured differently. Sorry for the confusion!
Robert Wagner
@rwwagner90
@chrismllr no worries! How do you like ember-shepherd?
Chris Miller
@chrismllr
@rwwagner90 I do really like it. Having callbacks for every event for each step is Very helpful :D
Robert Wagner
@rwwagner90
@chrismllr glad you’re enjoying it! We’re always looking for more contributors, if you have any ideas and would like to help out.
Robert Wagner
@rwwagner90
@/all does anyone want to help contribute to this and keep it up to date with Ember and such? I’ve switched to the dark side and use Angular now, so I don’t have as much Ember knowledge anymore.
Robert Wagner
@rwwagner90
@bekzod do you use gitter?
bek
@bekzod
now I am using :)
Robert Wagner
@rwwagner90
Okay cool :)
bek
@bekzod
thanks for sharing
Robert Wagner
@rwwagner90
Just thought it might be good to chat here
bek
@bekzod
this is awesome, does this get appended as commend in github ?
Robert Wagner
@rwwagner90
I’m not sure how it’s stored. It’s tied to the repo, but I think it’s separate