Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 26 10:07

    dependabot[bot] on npm_and_yarn

    (compare)

  • Sep 26 10:07
    dependabot[bot] closed #1179
  • Sep 26 10:07
    dependabot[bot] commented #1179
  • Sep 26 10:07
    dependabot[bot] labeled #1187
  • Sep 26 10:07

    dependabot[bot] on npm_and_yarn

    Bump eslint from 7.32.0 to 8.24… (compare)

  • Sep 26 10:07
    dependabot[bot] opened #1187
  • Sep 22 10:19

    dependabot[bot] on npm_and_yarn

    (compare)

  • Sep 22 10:19

    github-actions[bot] on main

    Bump mout from 1.2.3 to 1.2.4 (… (compare)

  • Sep 22 10:19
    github-actions[bot] closed #1186
  • Sep 22 10:13
    dependabot[bot] labeled #1186
  • Sep 22 10:13
    dependabot[bot] opened #1186
  • Sep 22 10:13

    dependabot[bot] on npm_and_yarn

    Bump mout from 1.2.3 to 1.2.4 … (compare)

  • Sep 22 10:13

    dependabot[bot] on npm_and_yarn

    (compare)

  • Sep 22 10:13

    dependabot[bot] on npm_and_yarn

    (compare)

  • Sep 22 10:13

    github-actions[bot] on main

    Bump stylelint from 14.12.0 to … (compare)

  • Sep 22 10:13
    github-actions[bot] closed #1184
  • Sep 22 10:12

    github-actions[bot] on main

    Bump sass from 1.54.9 to 1.55.0… (compare)

  • Sep 22 10:12
    github-actions[bot] closed #1185
  • Sep 22 10:07
    dependabot[bot] labeled #1185
  • Sep 22 10:06

    dependabot[bot] on npm_and_yarn

    Bump sass from 1.54.9 to 1.55.0… (compare)

Robert Wagner
@rwwagner90
@chrismllr no worries! How do you like ember-shepherd?
Chris Miller
@chrismllr
@rwwagner90 I do really like it. Having callbacks for every event for each step is Very helpful :D
Robert Wagner
@rwwagner90
@chrismllr glad you’re enjoying it! We’re always looking for more contributors, if you have any ideas and would like to help out.
Robert Wagner
@rwwagner90
@/all does anyone want to help contribute to this and keep it up to date with Ember and such? I’ve switched to the dark side and use Angular now, so I don’t have as much Ember knowledge anymore.
Robert Wagner
@rwwagner90
@bekzod do you use gitter?
bek
@bekzod
now I am using :)
Robert Wagner
@rwwagner90
Okay cool :)
bek
@bekzod
thanks for sharing
Robert Wagner
@rwwagner90
Just thought it might be good to chat here
bek
@bekzod
this is awesome, does this get appended as commend in github ?
Robert Wagner
@rwwagner90
I’m not sure how it’s stored. It’s tied to the repo, but I think it’s separate
bek
@bekzod
cool cool
Robert Wagner
@rwwagner90
You can ping me here whenever via @rwwagner90
bek
@bekzod
cool thanks :+1:
Robert Wagner
@rwwagner90
@bekzod did you want to address the issue with the cancel event stuff? Our discussion kind of died after switching over to gitter
bek
@bekzod
@rwwagner90 yes I do, I have actually implemente it with that way, just need to correct tests or write tests from begining, it is in branch refactor
so instead of triggering events you just call method like .trigger(’start’) => .start() while tour service instelf emmits all events like back, start, cancel, complete .etcc
Robert Wagner
@rwwagner90
@bekzod sounds good to me. Just as long as it works with all possible shepherd event listeners, and you write some tests, I’m good with all that :+1:
Perhaps we could support both ways though?
Allow trigger(‘start’) and just .start() that way people who upgrade don’t need to change the way they use it, if they don’t want to. Maybe we should force it to be cleaner though, and throw a deprecation error for the old way
bek
@bekzod
yeah depricating old way, and removing it on new major release (sorry for delayed reply I don’t get any emails/alerts from gitter)
:+1: cool thanks
Robert Wagner
@rwwagner90
@bekzod I get emails when I'm mentioned in gitter, so it must be a setting somewhere.
Robert Wagner
@rwwagner90
@jskeate are you guys still using ember-shepherd?
Jonathan Skeate
@skeate
As far as I know
Robert Wagner
@rwwagner90
@skeate okay, I was just wondering if you guys had any suggestions for the library or had any bugs or anything I should try to fix. Working on 2.0-beta right now
Patrick Berkeley
@patrickberkeley
Is it expected the tour is still visible when using the browsers back button to navigate to a route that does not have the tour?
If so, what approach do others take for clearing it out?
Robert Wagner
@rwwagner90
Hi @patrickberkeley. I would say that is a bug. Is there any chance you could create a small example app and/or post an issue with your code?
However, off the top of my head, you could manually close the tour on route change too probably. I’m not sure what the default should be, since I would think it would be possible to have a tour that spans mutiple routes
kulinichdenis
@kulinichdenis
This message was deleted
Primož Kerin
@primoz-k
Hi! I would like to know in which file do I put the configuration?
and the steps...