Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 19 16:30

    greenkeeper[bot] on eslint-plugin-ember-6.10.0

    chore(package): update eslint-p… (compare)

  • Aug 17 03:29
    greenkeeper[bot] closed #334
  • Aug 17 03:29

    greenkeeper[bot] on ember-source-3.12.0

    (compare)

  • Aug 17 03:29
    greenkeeper[bot] closed #335
  • Aug 17 03:29

    greenkeeper[bot] on ember-cli-3.12.0

    (compare)

  • Aug 17 03:29

    rwwagner90 on master

    Ember 3.12 (compare)

  • Aug 16 21:18

    greenkeeper[bot] on sass-1.22.10

    chore(package): update sass to … (compare)

  • Aug 16 08:59
    greenkeeper[bot] labeled #335
  • Aug 16 08:59
    greenkeeper[bot] opened #335
  • Aug 16 08:59

    greenkeeper[bot] on ember-cli-3.12.0

    chore(package): update ember-cl… (compare)

  • Aug 14 16:51

    greenkeeper[bot] on eslint-plugin-ember-6.9.1

    chore(package): update eslint-p… (compare)

  • Aug 12 20:28

    greenkeeper[bot] on eslint-plugin-ember-6.9.0

    chore(package): update eslint-p… (compare)

  • Aug 09 22:19

    greenkeeper[bot] on shepherd.js-4.6.0

    chore(package): update shepherd… (compare)

  • Aug 09 08:42

    greenkeeper[bot] on shepherd.js-4.5.0

    chore(package): update shepherd… (compare)

  • Aug 09 08:22

    greenkeeper[bot] on eslint-plugin-ember-6.8.2

    chore(package): update eslint-p… (compare)

  • Aug 08 05:11

    greenkeeper[bot] on shepherd.js-4.4.1

    chore(package): update shepherd… (compare)

  • Aug 06 01:11
    greenkeeper[bot] labeled #334
  • Aug 06 01:11
    greenkeeper[bot] opened #334
  • Aug 06 01:11

    greenkeeper[bot] on ember-source-3.12.0

    chore(package): update ember-so… (compare)

  • Aug 05 14:18

    greenkeeper[bot] on shepherd.js-4.4.0

    chore(package): update shepherd… (compare)

Robert Wagner
@rwwagner90
@alexlafroscia sorry, I didn’t see this until now. Did you get it figured out?
Alex LaFroscia
@alexlafroscia
Yeah, I figured out why they weren't working. I think we had an outdated version of the load-initializers dependency. Updating a lot of outdated deps were part of the PR I submitted
I noticed that the tests aren't passing but haven't looked into why yet
Robert Wagner
@rwwagner90
Okay, gotcha.
Robert Wagner
@rwwagner90
@alexlafroscia I'm stepping away from Ember for awhile. I started a new job using Angular. With that in mind, I'd love to get my other addons whipped into shape and to 1.0, then just leave them in maintenance mode, unless there is a huge surge in demand for some reason. Would you like to help out with that?
Alex LaFroscia
@alexlafroscia
I dunno, I have my own projects that I'm taking on and if I'm not using those packages, I can't see myself maintaining them
Robert Wagner
@rwwagner90
@alexlafroscia I didn't mean you would maintain them, I meant you would just help get them to 1.0 with me, but if you're busy, no worries at all. Just thought I would ask!
Alex LaFroscia
@alexlafroscia
Do they have tests written already? If so, I can take a look and see what they need.
Robert Wagner
@rwwagner90
@alexlafroscia I don't think so, but I will write them and try to wrap them up. Just need a second set of eyes to look at it and help out
Alex LaFroscia
@alexlafroscia
Alright, I could do that
Robert Wagner
@rwwagner90
@alexlafroscia okay, awesome. What projects are you working on now? I’d be glad to help you out, if you need it as well. You’ve helped a lot with ember-shepherd
Alex LaFroscia
@alexlafroscia
My Ember vim plugin, and I'm going to be adding a feature to the CLI itself starting today. Not really stuff I need help with necessarily, but I appreciate it!
Chris Miller
@chrismllr
Hey @rwwagner90 , I'm getting a certain error on ember serve, ENOENT, no such file or directory '/Users/etc/etc/tmp/concat_with_maps-input_base_path-cOIMPVzR.tmp/0/bower_components/tether/js/utils.js'
It would appear its looking in the wrong place for the tether utils.js file. Looking in bower components, its inside tether/src/js/utils.js
Oh no, I actually just realized I am using ember-tether as well. It seems to be in their code. They are including an older version of Tether in their build, and the new version you include in ember-shepherd is structured differently. Sorry for the confusion!
Robert Wagner
@rwwagner90
@chrismllr no worries! How do you like ember-shepherd?
Chris Miller
@chrismllr
@rwwagner90 I do really like it. Having callbacks for every event for each step is Very helpful :D
Robert Wagner
@rwwagner90
@chrismllr glad you’re enjoying it! We’re always looking for more contributors, if you have any ideas and would like to help out.
Robert Wagner
@rwwagner90
@/all does anyone want to help contribute to this and keep it up to date with Ember and such? I’ve switched to the dark side and use Angular now, so I don’t have as much Ember knowledge anymore.
Robert Wagner
@rwwagner90
@bekzod do you use gitter?
bek
@bekzod
now I am using :)
Robert Wagner
@rwwagner90
Okay cool :)
bek
@bekzod
thanks for sharing
Robert Wagner
@rwwagner90
Just thought it might be good to chat here
bek
@bekzod
this is awesome, does this get appended as commend in github ?
Robert Wagner
@rwwagner90
I’m not sure how it’s stored. It’s tied to the repo, but I think it’s separate
bek
@bekzod
cool cool
Robert Wagner
@rwwagner90
You can ping me here whenever via @rwwagner90
bek
@bekzod
cool thanks :+1:
Robert Wagner
@rwwagner90
@bekzod did you want to address the issue with the cancel event stuff? Our discussion kind of died after switching over to gitter
bek
@bekzod
@rwwagner90 yes I do, I have actually implemente it with that way, just need to correct tests or write tests from begining, it is in branch refactor
so instead of triggering events you just call method like .trigger(’start’) => .start() while tour service instelf emmits all events like back, start, cancel, complete .etcc
Robert Wagner
@rwwagner90
@bekzod sounds good to me. Just as long as it works with all possible shepherd event listeners, and you write some tests, I’m good with all that :+1:
Perhaps we could support both ways though?
Allow trigger(‘start’) and just .start() that way people who upgrade don’t need to change the way they use it, if they don’t want to. Maybe we should force it to be cleaner though, and throw a deprecation error for the old way
bek
@bekzod
yeah depricating old way, and removing it on new major release (sorry for delayed reply I don’t get any emails/alerts from gitter)
:+1: cool thanks
Robert Wagner
@rwwagner90
@bekzod I get emails when I'm mentioned in gitter, so it must be a setting somewhere.
Robert Wagner
@rwwagner90
@jskeate are you guys still using ember-shepherd?
Jonathan Skeate
@skeate
As far as I know
Robert Wagner
@rwwagner90
@skeate okay, I was just wondering if you guys had any suggestions for the library or had any bugs or anything I should try to fix. Working on 2.0-beta right now
Patrick Berkeley
@patrickberkeley
Is it expected the tour is still visible when using the browsers back button to navigate to a route that does not have the tour?
If so, what approach do others take for clearing it out?
Robert Wagner
@rwwagner90
Hi @patrickberkeley. I would say that is a bug. Is there any chance you could create a small example app and/or post an issue with your code?
However, off the top of my head, you could manually close the tour on route change too probably. I’m not sure what the default should be, since I would think it would be possible to have a tour that spans mutiple routes
kulinichdenis
@kulinichdenis
This message was deleted
Primož Kerin
@primoz-k
Hi! I would like to know in which file do I put the configuration?
and the steps...