Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

silverstripe/silverstripe-omnipay

SilverStripe integration with omnipay PHP payments library.

People

Repo info

Activity

Jan 17 20:05

EEKimS opened #238
Jun 06 2022 09:42

kinglozzer on 3

[CVE-2022-29254] Add extra vali… Update unit tests to use Guzzle… Add test to capture payments re… and 1 more (compare)
Jun 06 2022 09:41

kinglozzer on 3.2.1

(compare)
Jun 06 2022 09:41

kinglozzer on 3.2

[CVE-2022-29254] Add extra vali… (compare)
Jun 06 2022 09:41

kinglozzer on 3.1.4

(compare)
Jun 06 2022 09:41

kinglozzer on 3.1

[CVE-2022-29254] Add extra vali… (compare)
Jun 06 2022 09:41

kinglozzer on 3.0.2

(compare)
Jun 06 2022 09:41

kinglozzer on 3.0

[CVE-2022-29254] Add extra vali… (compare)
Jun 06 2022 09:40

kinglozzer on 2.5.2

(compare)
Jun 06 2022 09:40

kinglozzer on 2

[CVE-2022-29254] Add extra vali… Merge pull request #2 from silv… (compare)
May 11 2022 09:24

jinjie closed #237
May 11 2022 09:24

jinjie commented #237
May 11 2022 08:29

dhensby commented #237
May 11 2022 08:08

jinjie opened #237
Apr 05 2022 07:58

kinglozzer deleted #211
Apr 04 2022 12:10

kinglozzer commented #211
Apr 04 2022 12:05

tahlialouisa deleted #236
Mar 30 2022 10:10

kinglozzer edited #236
Mar 28 2022 16:16

kinglozzer commented #211
Mar 28 2022 16:15

kinglozzer commented #236

Morven Lewis-Everley

@mlewis-everley

is that even documented anywhere?

Roman Schmid

@bummzack

yeah, should be in the routing docs

https://docs.silverstripe.org/en/3/developer_guides/controllers/routing/#url-patterns

Morven Lewis-Everley

@mlewis-everley

OK, I have read that page so many times and never even acknowledged the URL Patterns

Morven Lewis-Everley

@mlewis-everley

Ugh, I am not sure I can implement this static routing on the module

There are 2 main issues

The one @bummzack mentioned (that the variance is quite great on responses)

No where is the payment ID sent to the payment server

Roman Schmid

@bummzack

I understand the first issue, but not the second.

You'd also have to give implementors control over the HTTPResponse

So that they can send back an appropriately formatted http response

This is going to vary for every payment provider as well…

It's similar to the omnipay notification problem…

Morven Lewis-Everley

@mlewis-everley

Well at the moment you set the payment identifier as a URL param and then retrieve the URL from that

the payment identifier is never sent to the payment gateway

so therefore they never send it back

so you have no payment identifier to retrieve

Roman Schmid

@bummzack

I know. But you'd establish a transaction ID with the payment provider first

Morven Lewis-Everley

@mlewis-everley

if you did that, you would remove the developers ability to add their own transaction ID

for example, on my ecommerce system, we generate an order ID and the payment is linked to the order

then we send the order ID to the payment gateway

Roman Schmid

@bummzack

no… it doesn't matter what the transaction ID is, as long as you can retrieve a payment from that ID

But normally, payment providers supply their own ID, which is the TransactionReference

don't you get that with the barclays gateway?

Morven Lewis-Everley

@mlewis-everley

You can only pass them an OrderID

Roman Schmid

@bummzack

yeah, but you're never able to pass the TransactionReference yourself

you should get that from the payment provider

eg. the omnipay response should contain that

Morven Lewis-Everley

@mlewis-everley

They send you back a PAYID

But that is the reference to the Barclays transaction

so I am not sure how you could use that to identify the omnipay payment

Roman Schmid

@bummzack

yeah, that's the transaction reference https://github.com/digitickets/omnipay-barclays-epdq/blob/ee90e438ce7cb46ef8c1001d102b5711872dabae/src/Omnipay/BarclaysEpdq/Message/EssentialCompletePurchaseResponse.php#L83

but I guess this won't be established prior to the server-server callback, right?

Either way… with your order ID, you should be able to look up the payment. Right?

Morven Lewis-Everley

@mlewis-everley

Yea I can do it that way, but I would essentially have to write some form of custom handler to retrieve the order and find the payment

which was why I meant I am not sure what I can do on this module

Roman Schmid

@bummzack

Yes. Finding the payment based on the payload from the payment provider has to be customisable…

Morven Lewis-Everley

@mlewis-everley

The only sensible thing I can think of is to create some sort of ResponseFactory

then you can write your own custom PaymentResponse class

and the controller would have to hand over taking payments to that class

sorry, I mean the controller would hand over completing the process

Roman Schmid

@bummzack

I mean, you could also make this part of your ecommerce module instead of the omnipay module… since it's very specific.

Morven Lewis-Everley

@mlewis-everley

Well, I may make it part of this specific project

Roman Schmid

@bummzack

I don't think the architecture has to be that complicated. There's response customisations for notifications in place already

Morven Lewis-Everley

@mlewis-everley

I don't generally work with Barclays :-)

Roman Schmid

@bummzack

for that we just pass the response to extensions which can customise the response for the gateway

I mean, you've done that too in this extension: https://github.com/silverstripe/silverstripe-omnipay/blob/2/code/extensions/WorldPayResponseExtension.php

Morven Lewis-Everley

@mlewis-everley

Yea, I can write an extension like that once I have the payment (which I can do in my own project using the OrderID)

Morven Lewis-Everley

@mlewis-everley

Right, trying to run unit tests and I get an error

ERROR [User Error]: Uncaught Error: Call to undefined method Mock_PxPayCompleteAuthorizeRequest_5b5460cb::send()
IN GET /ss-3/dev
Line 105 in /home/morven/Projects/ss-3/omnipay/code/Service/AuthorizeService.php

Chat via Matrix