Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 06 09:42

    kinglozzer on 3

    [CVE-2022-29254] Add extra vali… Update unit tests to use Guzzle… Add test to capture payments re… and 1 more (compare)

  • Jun 06 09:41

    kinglozzer on 3.2.1

    (compare)

  • Jun 06 09:41

    kinglozzer on 3.2

    [CVE-2022-29254] Add extra vali… (compare)

  • Jun 06 09:41

    kinglozzer on 3.1.4

    (compare)

  • Jun 06 09:41

    kinglozzer on 3.1

    [CVE-2022-29254] Add extra vali… (compare)

  • Jun 06 09:41

    kinglozzer on 3.0.2

    (compare)

  • Jun 06 09:41

    kinglozzer on 3.0

    [CVE-2022-29254] Add extra vali… (compare)

  • Jun 06 09:40

    kinglozzer on 2.5.2

    (compare)

  • Jun 06 09:40

    kinglozzer on 2

    [CVE-2022-29254] Add extra vali… Merge pull request #2 from silv… (compare)

  • May 11 09:24
    jinjie closed #237
  • May 11 09:24
    jinjie commented #237
  • May 11 08:29
    dhensby commented #237
  • May 11 08:08
    jinjie opened #237
  • Apr 05 07:58
    kinglozzer deleted #211
  • Apr 04 12:10
    kinglozzer commented #211
  • Apr 04 12:05
    tahlialouisa deleted #236
  • Mar 30 10:10
    kinglozzer edited #236
  • Mar 28 16:16
    kinglozzer commented #211
  • Mar 28 16:15
    kinglozzer commented #236
  • Mar 28 16:05
    kinglozzer opened #236
Morven Lewis-Everley
@mlewis-everley
Well, I may make it part of this specific project
Roman Schmid
@bummzack
I don't think the architecture has to be that complicated. There's response customisations for notifications in place already
Morven Lewis-Everley
@mlewis-everley
I don't generally work with Barclays :-)
Roman Schmid
@bummzack
for that we just pass the response to extensions which can customise the response for the gateway
Morven Lewis-Everley
@mlewis-everley
Yea, I can write an extension like that once I have the payment (which I can do in my own project using the OrderID)
Morven Lewis-Everley
@mlewis-everley
Right, trying to run unit tests and I get an error
ERROR [User Error]: Uncaught Error: Call to undefined method Mock_PxPayCompleteAuthorizeRequest_5b5460cb::send() IN GET /ss-3/dev Line 105 in /home/morven/Projects/ss-3/omnipay/code/Service/AuthorizeService.php
Trace
=====
SilverStripe\Omnipay\Service\AuthorizeService->complete()
BasePurchaseServiceTest.php:424

BasePurchaseServiceTest->testGatewayCompleteMethodFailure()

ReflectionMethod->invokeArgs(AuthorizeServiceTest,Array)
TestCase.php:987

PHPUnit_Framework_TestCase->runTest()
TestCase.php:838

PHPUnit_Framework_TestCase->runBare()
TestResult.php:648

PHPUnit_Framework_TestResult->run(AuthorizeServiceTest)
TestCase.php:783

PHPUnit_Framework_TestCase->run(PHPUnit_Framework_TestResult)
TestSuite.php:779

PHPUnit_Framework_TestSuite->runTest(AuthorizeServiceTest,PHPUnit_Framework_TestResult)
TestSuite.php:749

PHPUnit_Framework_TestSuite->run(PHPUnit_Framework_TestResult,,Array,Array,)
TestSuite.php:708

PHPUnit_Framework_TestSuite->run(PHPUnit_Framework_TestResult,,Array,Array,)
TestRunner.php:349

PHPUnit_TextUI_TestRunner->doRun(PHPUnit_Framework_TestSuite,Array)
Command.php:176

PHPUnit_TextUI_Command->run(Array,1)
Command.php:129

PHPUnit_TextUI_Command::main()
phpunit:63
I don't think this is related to anything I have done
Roman Schmid
@bummzack
how do you run the tests?
Morven Lewis-Everley
@mlewis-everley
I have php unit installed via composer
added orders/tests to phpunit.xml
I am also using the sqlite db
I am only running the tests on omnipay directly though
IE: # ./phpunit orders/tests '' db=sqlite3
Sorry, I mean # ./phpunit omnipay/tests '' db=sqlite3
Roman Schmid
@bummzack
have you tried ./vendor/bin/phpunit ./omnipay '' db=sqlite3?
Are you using PHPStorm btw?
tests complete normally if I run it this way…
Morven Lewis-Everley
@mlewis-everley
PHPStorm IDE?
Roman Schmid
@bummzack
yeah
Morven Lewis-Everley
@mlewis-everley
I use VS Code and the terminal
Roman Schmid
@bummzack
ah ok
just because it's rather comfortable/easy to run tests from within PHPStorm. But no biggie
Morven Lewis-Everley
@mlewis-everley
They have PHPunit integration in VSCode
I have just never bothered to set it up
:-)
using ./vendor/bin/phpunit ./omnipay '' db=sqlite3 generates the same error :-s
Roman Schmid
@bummzack
wtf?
Morven Lewis-Everley
@mlewis-everley
This is for the 2.0 branch
Roman Schmid
@bummzack
Don't use the 2.0 branch, it's outdated
use 2
Morven Lewis-Everley
@mlewis-everley
Ugh, right ok
Roman Schmid
@bummzack
or something like this in your composer json: "silverstripe/silverstripe-omnipay": "2.x-dev as 2.2"
if you also have "prefer-source": true in the composer.json, you'll get a git repo you can work on
Morven Lewis-Everley
@mlewis-everley
Well I have written some modifications to PaymentController (and PaymentService) based on our conversations, was going to post them into the GitHub issue to get some feedback
I will try and merge the changes into the 2 branch
Roman Schmid
@bummzack
ok
Morven Lewis-Everley
@mlewis-everley
I think I have just about had enough of Barclays and their payment gateway!
Tobias Oetiker
@oetiker
stripe is really cool!
Roman Schmid
@bummzack
;)
oetiker @oetiker loves stripe
Morven Lewis-Everley
@mlewis-everley
I know, unfortunately this client is already using Barclays and doesn't like change!
I would prefer stripe
to be honest, I would prefer WorldPay over this!
Quick question, can I change the omipay request callback via config?
Roman Schmid
@bummzack
not sure… if it's exposed as a param on the gateway?
you might try callbackMethod: 'GET' in your params config