Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 06 09:42

    kinglozzer on 3

    [CVE-2022-29254] Add extra vali… Update unit tests to use Guzzle… Add test to capture payments re… and 1 more (compare)

  • Jun 06 09:41

    kinglozzer on 3.2.1

    (compare)

  • Jun 06 09:41

    kinglozzer on 3.2

    [CVE-2022-29254] Add extra vali… (compare)

  • Jun 06 09:41

    kinglozzer on 3.1.4

    (compare)

  • Jun 06 09:41

    kinglozzer on 3.1

    [CVE-2022-29254] Add extra vali… (compare)

  • Jun 06 09:41

    kinglozzer on 3.0.2

    (compare)

  • Jun 06 09:41

    kinglozzer on 3.0

    [CVE-2022-29254] Add extra vali… (compare)

  • Jun 06 09:40

    kinglozzer on 2.5.2

    (compare)

  • Jun 06 09:40

    kinglozzer on 2

    [CVE-2022-29254] Add extra vali… Merge pull request #2 from silv… (compare)

  • May 11 09:24
    jinjie closed #237
  • May 11 09:24
    jinjie commented #237
  • May 11 08:29
    dhensby commented #237
  • May 11 08:08
    jinjie opened #237
  • Apr 05 07:58
    kinglozzer deleted #211
  • Apr 04 12:10
    kinglozzer commented #211
  • Apr 04 12:05
    tahlialouisa deleted #236
  • Mar 30 10:10
    kinglozzer edited #236
  • Mar 28 16:16
    kinglozzer commented #211
  • Mar 28 16:15
    kinglozzer commented #236
  • Mar 28 16:05
    kinglozzer opened #236
Roman Schmid
@bummzack
Don't use the 2.0 branch, it's outdated
use 2
Morven Lewis-Everley
@mlewis-everley
Ugh, right ok
Roman Schmid
@bummzack
or something like this in your composer json: "silverstripe/silverstripe-omnipay": "2.x-dev as 2.2"
if you also have "prefer-source": true in the composer.json, you'll get a git repo you can work on
Morven Lewis-Everley
@mlewis-everley
Well I have written some modifications to PaymentController (and PaymentService) based on our conversations, was going to post them into the GitHub issue to get some feedback
I will try and merge the changes into the 2 branch
Roman Schmid
@bummzack
ok
Morven Lewis-Everley
@mlewis-everley
I think I have just about had enough of Barclays and their payment gateway!
Tobias Oetiker
@oetiker
stripe is really cool!
Roman Schmid
@bummzack
;)
oetiker @oetiker loves stripe
Morven Lewis-Everley
@mlewis-everley
I know, unfortunately this client is already using Barclays and doesn't like change!
I would prefer stripe
to be honest, I would prefer WorldPay over this!
Quick question, can I change the omipay request callback via config?
Roman Schmid
@bummzack
not sure… if it's exposed as a param on the gateway?
you might try callbackMethod: 'GET' in your params config
Morven Lewis-Everley
@mlewis-everley
OK, it appears to be
in this instance?
Roman Schmid
@bummzack
pretty much, yes
Morven Lewis-Everley
@mlewis-everley
(I am guessing all Omnipay gateways expose similar paramaters)
OK, cool
Roman Schmid
@bummzack
they do
i think testMode is pretty much everywhere
Morven Lewis-Everley
@mlewis-everley
OK, I have added what I have done so far to a pull request
silverstripe/silverstripe-omnipay#177
and referenced it in the issue you flagged yesterday @bummzack
Don't really know if it is what you were thinking, but I have managed to get get it to work with Barclays pretty easily
I am not sure how much more I can do with it for now, without the risk of going postal!
Morven Lewis-Everley
@mlewis-everley
I am still getting the error ERROR [User Error]: Uncaught Error: Call to undefined method Mock_PxPayCompleteAuthorizeRequest_d2899b8d::send()
when I try and run unit tests
I notice that under require-dev you include "omnipay/paymentexpress": "~2.1"
does payment express need configuring at all?
Roman Schmid
@bummzack
no
Including actual gateways in the tests is a bit of a legacy code thing… ideally we would move everything to mock based tests
you'd have to require --dev the omnipay dev dependencies as well in your project
dev requirements aren't automatically installed from third party packages
Morven Lewis-Everley
@mlewis-everley
Oh hang on
I think I just realised something
I may have done something stupid!
Morven Lewis-Everley
@mlewis-everley
I am still getting the same error trying to run phpunit
I have just done a fresh install
phpunit works on unit tests I have written
but most of them aren't particularly complicated
out of curiosity @bummzack what version of phpunit are you using? And could you paste up your phpunit.xml?
Roman Schmid
@bummzack
phpunit 3.7.38
Morven Lewis-Everley
@mlewis-everley
OK, that is the same as mine