Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 04 2021 12:45
    kinglozzer closed #63
  • Nov 04 2021 12:43
    kinglozzer closed #171
  • Nov 04 2021 12:43
    kinglozzer commented #171
  • Nov 04 2021 12:41
    kinglozzer closed #233
  • Nov 04 2021 12:41
    kinglozzer commented #233
  • Nov 04 2021 12:37

    kinglozzer on 3

    Fix travis builds Merge pull request #235 from bi… (compare)

  • Nov 04 2021 12:37
    kinglozzer closed #235
  • Nov 04 2021 10:59
    kinglozzer synchronize #235
  • Nov 04 2021 10:10
    kinglozzer synchronize #235
  • Nov 04 2021 10:01
    kinglozzer synchronize #235
  • Nov 04 2021 09:58
    kinglozzer opened #235
  • Nov 04 2021 09:57
    kinglozzer converted_to_draft #233
  • Nov 04 2021 09:43
    kinglozzer edited #233
  • Nov 04 2021 09:38

    kinglozzer on master

    Update branch alias to 4.x-dev (compare)

  • Nov 04 2021 09:32

    kinglozzer on 3

    (compare)

  • Nov 03 2021 17:37
    kinglozzer commented #233
  • Nov 03 2021 17:36
    kinglozzer synchronize #233
  • Nov 03 2021 17:23
    kinglozzer synchronize #233
  • Nov 03 2021 16:23
    kinglozzer synchronize #233
  • Nov 03 2021 15:50
    kinglozzer synchronize #233
Roman Schmid
@bummzack
Including actual gateways in the tests is a bit of a legacy code thing… ideally we would move everything to mock based tests
you'd have to require --dev the omnipay dev dependencies as well in your project
dev requirements aren't automatically installed from third party packages
Morven Lewis-Everley
@mlewis-everley
Oh hang on
I think I just realised something
I may have done something stupid!
Morven Lewis-Everley
@mlewis-everley
I am still getting the same error trying to run phpunit
I have just done a fresh install
phpunit works on unit tests I have written
but most of them aren't particularly complicated
out of curiosity @bummzack what version of phpunit are you using? And could you paste up your phpunit.xml?
Roman Schmid
@bummzack
phpunit 3.7.38
Morven Lewis-Everley
@mlewis-everley
OK, that is the same as mine
Roman Schmid
@bummzack
My phpunit file looks like this… nothing special, I think the main thing is the bootstrap attribute.
<phpunit bootstrap="framework/tests/bootstrap.php" colors="true">
    <testsuite name="Default">
        <directory>mysite/tests</directory>
        <directory>cms/tests</directory>
        <directory>framework/tests</directory>
    </testsuite>

    <testsuite name="Framework">
        <directory>framework/tests</directory>
    </testsuite>

    <testsuite name="CMS">
        <directory>cms/tests</directory>
    </testsuite>

    <testsuite name="Silvershop">
        <directory>silvershop/tests</directory>
    </testsuite>

    <listeners>
        <listener class="SS_TestListener" file="framework/dev/TestListener.php" />
    </listeners>

    <groups>
        <exclude>
            <group>sanitychecks</group>
        </exclude>
    </groups>

    <php>
        <request name="db" value="sqlite3"/>
    </php>
</phpunit>
sorry, pasted twice somehow…
do you have these in your require-dev?
"require-dev": {
  "phpunit/PHPUnit": "~3.7",
  "silverstripe/sqlite3": "^1.4",
  "omnipay/dummy": "~2.1",
  "omnipay/paymentexpress": "~2.1",
  "omnipay/paypal": "^2.5",
  "guzzle/guzzle": "^3.9",
  "omnipay/tests": "^2.0",
  "omnipay/common": "~2.5"
},
Morven Lewis-Everley
@mlewis-everley
Hmm, not all those
just updating
Ugh, finally!
looks like it is working now
Roman Schmid
@bummzack
awesome
Morven Lewis-Everley
@mlewis-everley
I think it was the paymentexpress module
Roman Schmid
@bummzack
yeah… when testing modules this way (eg. when they are imported as a dependency) you'd have to add their dev-dependencies to your main composer file
because composer doesn't install these… I'm not sure if there's a flag for this though. Probably :)
Morven Lewis-Everley
@mlewis-everley
that is annoying
I usually just use composer require or composer update on local/dev, then composer install --no-dev on live
Roman Schmid
@bummzack
yeah, but even if you install regularly, it will only install dev requirements of your main composer file
Morven Lewis-Everley
@mlewis-everley
I had never realised that
I did try running composer update --dev but that didn't seem to work
Roman Schmid
@bummzack
no it wont. the dev requirements are only relevant to the library itself, not the global project
I guess that's the reasoning behind that…
no need to install all dev dependencies of all required modules
Morven Lewis-Everley
@mlewis-everley
hmm, any reason this test exists?
apparently it has no assertions?
Roman Schmid
@bummzack
haha. interesting…
Morven Lewis-Everley
@mlewis-everley
Should I remove it?
Roman Schmid
@bummzack
better mark as incomplete I guess
Morven Lewis-Everley
@mlewis-everley
How do I that?
Roman Schmid
@bummzack
$this->markTestIncomplete('getCMSFields tests');
Morven Lewis-Everley
@mlewis-everley
OK, the way I have re-written this does not allow for returning $this->httpError() so easily
so I am adding some more exception types
and throwing exceptions from the functions, then catching them in the action
does that sound ok?
Roman Schmid
@bummzack
@mlewis-everley hmm I'd like to avoid that if possible
let me have a look
why do you need to throw the exceptions? Can't you just return null there and output an error in case the return value is null?
Morven Lewis-Everley
@mlewis-everley
Well you were outputting two different error codes (403 and 404)
Roman Schmid
@bummzack
yes
403 if the intent is invalid