by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Caleb Maclennan
    @alerque
    I'm no at a computer but I dropped in to metion there is stuff in the comcit history from before when we started using standard commit formats that is in this release too.
    --system-luarocks should be --with-system-luarocks
    Maybe mention more detailed traces with -t
    Caleb Maclennan
    @alerque
    Also we (esp me) have been using conventional commits a bit wrong. We need to be a lot more sparing of fix(x): for only user facing fixes since the last realease, not for fixing the code buggaboos we just added or are trying to add but haven't even been used yet.
    Caleb Maclennan
    @alerque
    And yes, the Github built files and just wrap-ups of the git tree. The output of make dist is what people need.
    Caleb Maclennan
    @alerque
    Caleb Maclennan
    @alerque
    Somewhat spectacularly, the Windows Azure build isn't that broken. It builds and runs, but has issues with Lua module include paths.
    Simon Cozens
    @simoncozens
    I've got day job things on today until about 3pm GMT. If you want to get the release notes out before that, feel free. Otherwise I'll do it when I get back.
    Caleb Maclennan
    @alerque
    Okay thanks.
    Kolay gelsin.
    Caleb Maclennan
    @alerque
    Done. Feel free to edit and tweak, I'm not the kind to think blog posts have to be 100% set in stone ;-)
    Also the website needs some proper typography.
    Caleb Maclennan
    @alerque
    Getting the Homebrew formula updated is probably the biggest next step. I don't have a working macOS machine at the moment :-(
    Caleb Maclennan
    @alerque
    Working on a formula but will need you to check it.
    Caleb Maclennan
    @alerque
    Simon Cozens
    @simoncozens
    So the Homebrew CI is failing ./configure on luarepl, despite the fact that the rock was successfully installed.
    Caleb Maclennan
    @alerque
    Is it perhaps lua-repl or repl internally, not luarepl?
    Simon Cozens
    @simoncozens
    The package name is repl, but that's apparently what we test for:
    checking for required Lua library repl... not found
    configure: error: cannot find Lua library repl - install from luarocks package luarepl
    Caleb Maclennan
    @alerque
    You're welcome to push to my repo / branch for that PR by the way, I just thought I'd get things started.
    Simon Cozens
    @simoncozens
    That's the only one failing, strangely, so setting up the luarocks path must be working.
    And I've now reproduced it locally. Let me see.
    Caleb Maclennan
    @alerque
    Good luck, you have a leg up on me there since I have no operational Mac.
    Simon Cozens
    @simoncozens
    OK, I am confused. You're using --with-system-luarocks but you are also installing the luarocks into /usr/local/Cellar/sile/0.10.0_1/libexec/vendor//share/lua/
    I thought --with-system-luarocks meant "use the normal Lua installation paths".
    Caleb Maclennan
    @alerque
    That is the system Lua rocks path in this case, no? Basically the Formula is setup to pretend there is a system install of the rocks but runs the whole thing on an island to itself.
    It does. --without-system-luarocks would cause the make process to fetch and bundle them all with SILE without telling brew anything about them.
    Here brew is stepping in and giving a sort of sand boxed system path so it can handle the downloading, checksumming, etc. itself rather than fetching the deps at build time.
    Simon Cozens
    @simoncozens
    Let me do a debugging build.
    OK, think I got it.
    I could check out your entire homebrew repo and post a patch to it in half an hour when it's done, or you could replace line 102 of sile.rb with
        ENV["LUA_PATH"] = "#{luapath}/share/lua/5.3/?.lua;#{luapath}/share/lua/5.3/?/init.lua;#{luapath}/share/lua/5.3/lxp/?.lua"
    Caleb Maclennan
    @alerque
    Pushed.
    You could have also just added my repo as a remote to your existing clone and you wouldn't have to wait half an hour ;-)
    Simon Cozens
    @simoncozens
    Oh, yeah, I forgot homebrew worked like that. :-)
    Caleb Maclennan
    @alerque
    Do the various brew ... commands from Homebrew's PR checklist pan out for you? If so I'll check them off.
    Simon Cozens
    @simoncozens
    I'm working on it.
    We don't pull in the std rock but still require it in configure. I'll add it to the formula.
    Caleb Maclennan
    @alerque
    Oh that's an oops that affects everybody!
    Simon Cozens
    @simoncozens
    Do we require it in the codebase at all or just in configure?
    Caleb Maclennan
    @alerque
    Actually we do have it in the rockspec, so most people will get it. It's not in my Arch Linux deps though.
    Simon Cozens
    @simoncozens
    Ah, ./core/sile.lua:std = require("std")
    So people doing --without-system-luarocks will get it auto-installed, and people doing the --with-system-luarocks thing will be told what to do to install it. Inconvenient but not awful.
    Caleb Maclennan
    @alerque
    That loads it, but the "stdlib == 41.2.2-1" in sile-dev-1.rockspec is what actually triggers it to be installed when --without-system-luarocks is in action.
    Yes, but that's the case for all the Luarocks if they choose to provide them themselves.
    Simon Cozens
    @simoncozens
    Right.
    Caleb Maclennan
    @alerque
    Hence why it's mostly up to packagers to include them all. And I missed it not just putting together that Formula but Arch and Void too.
    Simon Cozens
    @simoncozens
    OK, off we go again. This time the formula built for me.
    Caleb Maclennan
    @alerque
    No I didn't, it's there in Arch....holdover from before. It should have been in the Homebrew Formula already too, 0.9.x needed it too!
    brew test / brew audit?
    Simon Cozens
    @simoncozens
    Audit was happy. test is being silly:
    $ brew test sile -v
    Error: Testing requires the latest version of sile
    Caleb Maclennan
    @alerque
    What does that even mean?