Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 09 21:49
    cihant opened #1032
  • May 08 18:15
    cihant opened #1031
  • Apr 20 23:34
    SamsDkh edited #1030
  • Apr 20 23:33
    SamsDkh opened #1030
  • Apr 14 06:18
    fulminous commented #1018
  • Mar 24 05:54
    UsmanSaddique opened #1029
  • Feb 25 10:54
    sangspd20 opened #1027
  • Feb 25 10:49
    sangspd20 opened #1026
  • Feb 08 03:03

    thiennn on master

    Update simpl-build.sh to work w… (compare)

  • Feb 08 03:03
    thiennn closed #1025
  • Jan 31 08:30
    minhhut opened #1025
  • Jan 19 12:07
    LesterCerioli closed #1021
  • Jan 19 12:07
    LesterCerioli commented #1021
  • Jan 19 12:05
    LesterCerioli opened #1022
  • Jan 19 11:42
    LesterCerioli opened #1021
  • Jan 14 10:28
    nqtuyen commented #1020
  • Jan 14 10:26
    nqtuyen commented #1020
  • Jan 14 10:13
    nqtuyen opened #1020
  • Dec 13 2021 14:17

    thiennn on master

    Localization_Resource changes (… (compare)

  • Dec 13 2021 14:17
    thiennn closed #1019
Thien Nguyen Le Quynh
@thiennn
if you just edit a view in a theme, no dotnet watch neeed
Hisham Bin Ateya
@hishamco
dotnet watch useful outside of VS
bugproof
@bugproof
oh so all that was needed was AddRazorRuntimeCompilation
good to know
:smile:
bugproof
@bugproof
I'm trying to create a payment module
but unlike other modules VS can't open my own
image.png
<Project Sdk="Microsoft.NET.Sdk.Razor">
  <ItemGroup>
    <ProjectReference Include="..\..\SimplCommerce.Infrastructure\SimplCommerce.Infrastructure.csproj" />
    <ProjectReference Include="..\SimplCommerce.Module.Core\SimplCommerce.Module.Core.csproj" />
    <ProjectReference Include="..\SimplCommerce.Module.Orders\SimplCommerce.Module.Orders.csproj" />
    <ProjectReference Include="..\SimplCommerce.Module.Payments\SimplCommerce.Module.Payments.csproj" />
  </ItemGroup>
</Project>
what's going on?
bugproof
@bugproof
image.png
and it looks the same way as the other modules...
bugproof
@bugproof
I think
 <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
    <GenerateEmbeddedFilesManifest>true</GenerateEmbeddedFilesManifest>
  </PropertyGroup>
is required
with ItemGroup only it doesn't seem to work...
bugproof
@bugproof
@thiennn thoughts?
I will release the code if I do it successfully
Thien Nguyen Le Quynh
@thiennn
@bugproof actually it works. If you look at other modules, you will see something similar.
And please make sure that your module code is in the src/Modules folder
bugproof
@bugproof
hmm yeah I probably did something wrong
it appears to be working now :o
maybe VS bugged
and didn't recognize Directory.Build.props
SimplCommerce is better than every other e-commerce for .net :D
only postgres/mysql should be used by default
SQL server doesn't play well with open source
bugproof
@bugproof
I think shipping method should dictate if the shipping address is required or not and provide custom fields for shipment
I would like to integrate shipping method where you just specify one point and that point is just a code
currently, you can't select shipping method without filling all address fields
bugproof
@bugproof
image.png
that will require some changes
because there are shipping providers that don't require any of this, they just give you a map of points where you can pick a point eg (POINT01)
bugproof
@bugproof
opened an issue for that simplcommerce/SimplCommerce#849
bugproof
@bugproof
how do you maintain translations?
I think with a query to check which translations are missing
I mean how do you ensure all translations are up to date
StaticData-DefaultLocalization.sql will always contain up to date translations ?
bugproof
@bugproof
it woudl be nice to have some translation system or tests
hmm
bugproof
@bugproof
maybe replace StaticData with custom module that does seeding?
it would work with all EF providers then
or something to eliminate raw SQL
maybe use JSON for it
then we'd have de.json, vn.json, us.json
etc
bugproof
@bugproof
I translated SimplCommerce to polish and added all polish provinces, PRs soon
Hisham Bin Ateya
@hishamco
Great job
I'm waiting for your PRS