Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 25 21:05

    skeate on v1.4.0

    (compare)

  • Mar 25 21:05

    skeate on v1.4.1

    (compare)

  • Mar 25 21:05

    skeate on v1.4.2

    (compare)

  • Mar 25 21:05

    skeate on master

    1.4.2 Update docs, changelog (compare)

  • Mar 25 20:57

    skeate on master

    Added check for key down target… Merge pull request #146 from dm… (compare)

  • Mar 25 20:57
    skeate closed #146
  • Mar 25 20:57
    skeate commented #146
  • Mar 25 20:45
    dmundra opened #146
  • Mar 22 16:31
    L0per commented #133
  • Mar 21 19:42
    skeate closed #100
  • Mar 21 19:42
    skeate commented #100
  • Mar 21 19:37
    skeate closed #133
  • Mar 21 19:37
    skeate commented #133
  • Mar 21 19:24

    skeate on master

    1.2.0 chore(package): update babel-je… cleanup document events on remo… and 17 more (compare)

  • Mar 21 18:26

    skeate on develop

    1.2.0 chore(package): update babel-je… Merge pull request #86 from ske… and 21 more (compare)

  • Mar 20 01:20

    dependabot[bot] on npm_and_yarn

    (compare)

  • Mar 20 01:20

    dependabot[bot] on npm_and_yarn

    (compare)

  • Mar 20 01:20

    dependabot[bot] on npm_and_yarn

    (compare)

  • Mar 20 01:20

    dependabot[bot] on npm_and_yarn

    (compare)

  • Mar 20 01:20

    dependabot[bot] on npm_and_yarn

    (compare)

Mark Stuart
@markstuart
That’d be awesome to rewrite in ES2015 :+1:
It’d be great to get test coverage before the rewrite though, right? To confirm there are no functional changes?
Jonathan Skeate
@skeate
Yes, it would be nice, but... (a) It's not terribly well-written right now, so it's a little hard to test. The one thing that would be super easy is the interval tree, which I plan on moving into another project (diesal) and then pulling from there. (b) The coffeescript -> es2015 (still not used to that name) conversion is largely mechanical, anyway, so I'm not too worried about messing something up
Jonathan Skeate
@skeate
@markstuart Not sure if you're watching the repo / still interested, but it's been rewritten and I've added tests! :D
Going to tweak the examples to work with the new API, then release 1.0.0-beta today; hopefully get some feedback and release 1.0.0 this weekend
Mark Stuart
@markstuart
Wicked, I'm definitely still interested! Will try to find some time today to take a look over the code/tests.
rpavery
@rpavery
Hi Jonathan, I just started using Timeline and it's great! I have a question that hopefully isn't too difficult. Basically, when the end time is reached, I'd rather change the color of a feature rather than removing it. Short of modifying the code, I thought the easiest solution would be to copy my data to another timeline object where I can set the original end time as the start time and style them grey - but then I run into issue #23 about multiple timelines. Do you (or anybody else) have an idea for a more elegant solution? Otherwise I'll probably just duplicate the data and set a separate style for the duplicated data, but this seems inefficient, especially for larger arrays. Curious to know what you think. Thanks again!
Jonathan Skeate
@skeate
Hi! I can probably add some events on feature start/end so the default behavior (insert/remove) can be overridden
rpavery
@rpavery
awesome, i'm happy to test when you're ready. I'm working on a project that will go live in a few days, so probably won't use it for that, was just curious how you'd approach it.
Mark Stuart
@markstuart
You could have a separate geojson layer with all the same data and listen to the change event on the timeline, then filter out the features that returned by the getDisplayed function.
rpavery
@rpavery
that might get me most of the way there - hadn't thought of that. I also want to remove all features after the time shown in the timeline, if that makes sense. Otherwise at the beginning all the features will show in grey for example, and I only want them to be grey after they've appeared then disappeared in the timeline.
Mark Stuart
@markstuart
okay, so the intial layer for the grayed out features would be empty, and then you just add the features returned by getDisplayed on change
I guess you need to handle people manually moving the slider
So you’d need to keep track of what time was returned by the change event, check whether it’s increasing or decreasing, and add the features from getDisplayed if time is increasing, remove if decreasing
though I’m not sure how often that event fires, so it might not be the whole solution
Anyway, it’s an idea ;)
Jonathan Skeate
@skeate
change should fire on every tick (during playback) or whenever the user changes the slider
Mark Stuart
@markstuart
Yeah, so if the user slides from end to start quickly, it fires once?
Jonathan Skeate
@skeate
iirc, it depends on the waitToUpdateMap property
because the control sets the time on the layer, and the layer fires the event. if waitToUpdateMap is true, then the control doesn't set the layer's time until the user's done fiddling with the slider
Mark Stuart
@markstuart
Actually, a better approach might be to have all the data in the duplicate layer, but apply a hidden style to the features with time values before the features returned by getDisplayed
It’s time sorted data, should be easy enough to figure out which features on the dupe layer should be hidden based on the current features displayed in the timeline
Might be quite a nice feature to provide the user with the ability to define the behaviour of the plugin at the start/end times of each feature
Jonathan Skeate
@skeate
shouldn't be too hard, either
Mark Stuart
@markstuart
I’d love to have a play with that (esp now that I can read the code lol) but my work commitments are intense atm sorry @skeate
Thanks for the ES2015 conversion, looks good
Jonathan Skeate
@skeate
no worries
Jonathan Skeate
@skeate
Working on getting the beta up now
documentation's a drag
Jonathan Skeate
@skeate
I did wind up killing the gulp server stuff :sweat_drops:
There's a webpack dev server but I haven't gotten it set up right yet
Mark Stuart
@markstuart
Oh, yeah, that’s cool. Just niceties really, I like that reload on change stuff :)
rpavery
@rpavery
Hi, I updated my test to use the new 1.0.0 beta with two separate files controlled by the same slider. Each file works fine by itself, but when I add both timelines to the control, it looks like features are not removed correctly in the map so then the lines get darker and darker with all of the objects left on the map. Here's a link to my demo: http://ryanavery.net/cc/test.html
You can see that it's not removing items because when you return to the beginning of the slider, there should be no completed projects showing, but there are some still there. Hope this helps!
rpavery
@rpavery
looks like it's something in the timeline.getDisplayed() function - when there are multiple layers, getDisplayed returns an empty array, which causes the behavior seen. Now I just need to see if I can figure out why that happens. Do you want me to open an issue?
Jonathan Skeate
@skeate
please
Eric Sherman
@easherma
hey, quick question: thinking about using this for a small project, however I don't have units of time for my data. I do have the chronological order, but the unit of time is essentially arbitrary (currently the rows are just numbered in ascending order), I just need to make sure they are filtered in the correct order. do you think it would be a simple matter to adapt this plugin (and/or my data) for this use case or will it be overkill?
Jonathan Skeate
@skeate
You could probably map the data and use the index as the "time"
Eric Sherman
@easherma
do I not need a start/end for each?
Jonathan Skeate
@skeate
Do they overlap? Or is it completely sequential
Eric Sherman
@easherma
completely sequential, or at least I have an already defined sequential index
Jonathan Skeate
@skeate
You can make the start the index, and the end the next index.
Eric Sherman
@easherma
but does it expect those to be pre-written properties of the geojson for each individual feature, or do can I define the start and end as a numeric range?
Eric Sherman
@easherma
is this expected to work with leaflet 1.0 ?
Eric Sherman
@easherma
so for some reason, aside from the first and last positions each position on the slider shows two objects at once instead of one. is that expected?
i just changed my end param to end - 1
Dr-Eman1
@Dr-Eman1
Hi
I am new here. Wishing I could do stuff. Am trying. I have a bit of a dream.
I want to make a timeline map. Am trying a few things to try get it started. Does anyone have any thoughts?
Dr-Eman1
@Dr-Eman1
Ok. So researched what you guys were talking about with leaflet and indexing etc. Seems that I might ave a good start on mouse positions on my interactive view of a community.