Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Ovidiu Cherecheș
    @skidding
    cool. It will get a nice update from skidding/cosmos#105 soon
    Sergey Lapin
    @sergey-lapin
    great, I will check it I had some troubles to make cosmos work with webpack, and because my main purpose was to make react-hot-loader work, I made some one way hacker changes. U'll see
    Ovidiu Cherecheș
    @skidding
    The cosmos bundle will get better as well. I've refactored the bundle from the ground up from gulp to webpack but it's not yet pushed to npm or uploaded. the repo still points to 0.4.x but 0.5.x wip is already integrated with webpack so should make your life easier in the future
    Sergey Lapin
    @sergey-lapin
    @skidding https://github.com/lapanoid/hot-cosmos - check this please
    Ovidiu Cherecheș
    @skidding
    cool!
    you managed to make the playground reload on fixture before I got to it. I like the name hot-cosmos :P
    Sergey Lapin
    @sergey-lapin
    =)
    Ovidiu Cherecheș
    @skidding
    I'm curious, which is the line that makes the hot-loader react to fixture changes. is it https://github.com/lapanoid/hot-cosmos/blob/master/webpack.hot.config.js#L8?
    Sergey Lapin
    @sergey-lapin
    Actually I have no idea it just works=)
    Ovidiu Cherecheș
    @skidding
    hah
    Sergey Lapin
    @sergey-lapin
    As u can see I use some modification of cosmos, it would be better to depend on your project via npm
    Ovidiu Cherecheș
    @skidding
    yes, it's cleaner via npm
    Sergey Lapin
    @sergey-lapin
    But I am sure u are more expert in your code than me) Maybe if you bundle cosmos in commonjs way I can easily use it.
    Ovidiu Cherecheș
    @skidding
    should already work https://www.npmjs.com/package/cosmos-js
    Sergey Lapin
    @sergey-lapin
    okey will try
    Ovidiu Cherecheș
    @skidding
    Just published Cosmos 0.5.0 https://github.com/skidding/cosmos/releases/tag/0.5.0 - available on npm as well
    Sergey Lapin
    @sergey-lapin
    awesome!
    Sergey Lapin
    @sergey-lapin
    @skidding I am running this issue http://joxi.ru/ZrJjXwdUM8Wwrj using cosmos.commonjs
    Sergey Lapin
    @sergey-lapin
    @skidding Hah it was silly issue with lodash, but I still can not use cosmos 0.5.0. I build dev common js cosmos, now I am getting http://joxi.ru/eAO67wRipVDL2o. I guess playground changed and now I can hardly understand what is happening=(Is that valid "cosmos\examples\component-playground\component-playground.html" - http://joxi.ru/nAy6qybijDbOrZ ?
    Ovidiu Cherecheș
    @skidding
    yes, the example is valid but it looks kinda weird because component playground loads component playground..
    it's weird that props.component is undefined. it should contain the name of the component (see https://github.com/skidding/cosmos#component-lookup)
    but the ComponentPlayground populates it automatically so you don't have to add it in the fixture: https://github.com/skidding/cosmos/blob/master/components/component-playground.jsx#L94
    can you show me the fixturePath from the url for the screenshot you posted
    ?
    Sergey Lapin
    @sergey-lapin
    @skidding http://localhost:63342/cosmos/examples/component-playground/component-playground.html?fixturePath=ComponentPlayground%2Fwith-fixture-selected
    Ovidiu Cherecheș
    @skidding
    localhost is on your machine, can't open that :)
    Sergey Lapin
    @sergey-lapin
    Yeah) I just use your example, you can run it on your machine ;)
    Or you want me to host it?
    Ovidiu Cherecheș
    @skidding
    it runs just fine on my machine. doesn't throw any error
    Sergey Lapin
    @sergey-lapin
    I don have any error either it just looks weird and wrong
    Ovidiu Cherecheș
    @skidding
    it's because it loads an component playground inside a component playground inside a component playground. It has to stop at the 3rd level otherwise it would be an infinite loop
    I'm curious why did your project stop working though
    Sergey Lapin
    @sergey-lapin
    you mean that I have only 2 levels?
    Ovidiu Cherecheș
    @skidding
    I mean this: http://joxi.ru/eAO67wRipVDL2o
    the 3rd level is meant to be blank in the cosmos example, it's the same for me
    hence: https://github.com/skidding/cosmos/blob/master/examples/component-playground/component-playground.html#L23-L79
    Sergey Lapin
    @sergey-lapin
    "// The Component Playground inside itself might not be the best example :)" - totaly agreed =)
    Ovidiu Cherecheș
    @skidding
    :D
    Sergey Lapin
    @sergey-lapin
    It is really ambigues, and looks like something is broken
    May be you use something simple like https://github.com/lapanoid/hot-cosmos/tree/master/components ?
    If you implement some simple example it would be really helpful for me to understand how it should work
    Ovidiu Cherecheș
    @skidding
    we'll I'm trying to integrate it in a project that has hundreds of fixtures using Cosmos, but no component playground
    after that I might learn a few things that need to be tweaked as well on the playground
    still. you're saying it worked with 0.4.0 and doesn't work with 0.5.0?
    Sergey Lapin
    @sergey-lapin
    Not exactly I picked cosmos 0.4.0 and modified for my "hot" needs
    Ovidiu Cherecheș
    @skidding
    because the playground example was the same before the upgrade...
    Sergey Lapin
    @sergey-lapin
    https://github.com/lapanoid/hot-cosmos/blob/master/cosmos.js - here it is
    Nothing special I just solved a couple issues, I dont deeply understand cosmos yet=(
    Sergey Lapin
    @sergey-lapin
    @skidding I assume this \cosmos\examples\component-playground\component-playground.html - general example that show all power of cosmos, but it is complicated, some really primitive example would be nice
    Ovidiu Cherecheș
    @skidding
    yeah, you're right