Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Sergey Lapin
    @sergey-lapin
    I can do git traverse thing, but it would be cool if you prepare cosmos in that way, if you like an idea
    Ovidiu Cherecheș
    @skidding
    well you need the components and fixtures folders, other than that node_modules/.bin/component-playgroundwill work on any given commit
    Sergey Lapin
    @sergey-lapin
    Are you sure that every user of cosmos will keep component-playground in path root/component-playground? it should be some strict criteria, maybe "component-playground" name of folder, or some meta config file with special name. It is up to you to decide
    This message was deleted
    var rootPath = path.join(__dirname, '..'), playgroundPath = path.join(rootPath, 'component-playground'); hardcode =(
    Ovidiu Cherecheș
    @skidding
    those paths are inside the cosmos package, not the project using it
    also, you can put the components and the fixtures in different places and specify their path like node_modules/.bin/component-playground --components-path src/components --fixtures-path tests/fixtures
    Sergey Lapin
    @sergey-lapin
    Again in that case I can’t if I dump robo recognize where user fixtures and components located
    Ovidiu Cherecheș
    @skidding
    I think it's a bit confusing because before you had the playground in your project, now it's just an executable from the cosmos package. so it has no more boilerplate
    well you should know where components/fixtures are are located per project, otherwise you're kinda blindfolded...
    Sergey Lapin
    @sergey-lapin
    This is exactlly what I am talking about
    If there is no meta in repo I can’t know
    Ovidiu Cherecheș
    @skidding
    yeah.. component-playground.config.js seems like the future to replace the --components-path src/components --fixtures-path tests/fixtures cli args
    Sergey Lapin
    @sergey-lapin
    That would be great=)
    Ovidiu Cherecheș
    @skidding
    :dancers:
    Dan Weaver
    @dan-weaver
    hey what happened to the site with all the documentation
    does it still exist?
    Ovidiu Cherecheș
    @skidding
    well it got split in more pieces
    and the philosophical stuff in the wiki :) https://github.com/skidding/cosmos/wiki
    Sergey Lapin
    @sergey-lapin
    Ovidiu Cherecheș
    @skidding
    "Since every application state mutation is triggered by an action" is this true? – do you always trigger an action for a state mutation, even when that state is not reflected on the server?
    either way, it's awesome!
    Sergey Lapin
    @sergey-lapin
    Ultimatlly every app state has equvalent sequense of action events and vise versa
    You can't get that with angular with its two way bindings everywhere
    Sergey Lapin
    @sergey-lapin
    Which is pretty awesome yep)
    Sergey Lapin
    @sergey-lapin
    @skidding just made a minor RP adding "auto-generated-empty-fixtures" skidding/cosmos#136
    Sergey Lapin
    @sergey-lapin
    @skidding fixed my PR sorry for delay
    Sergey Lapin
    @sergey-lapin
    @skidding what do you think about "fluxifying" your code? https://github.com/gaearon/redux-devtools - is out and this could really boost development on cosmos, and reduce on-boarding barrier as new devs could run your code and play with actions and states to uderstand it better, as well as you)
    It would be great to integrate cosmos to redux-devtools actually, but I think it should be "fluxified" before. Git history integration (showing history of component on each commit, I talked about before) is also troubled without flux. But with it writing a plugin for cosmos is really easy.
    Sergey Lapin
    @sergey-lapin
    @skidding please share your perspective on that.
    Ovidiu Cherecheș
    @skidding
    @lapanoid I responded on your PR
    As for the redux-devtools integration, I don't know what "fluxified" means
    Sergey Lapin
    @sergey-lapin
    No this is a separate thing
    Don't focuse on this it is just my thought for future. I don't know straight way to do it now
    Fluxifing means move all logic to event generation and updating cosmos on these events
    Sergey Lapin
    @sergey-lapin
    @skidding Many of my clients argue against cosmos that it has not such automatization as unit tests despite that workflow is definetly better with it, so I made https://github.com/lapanoid/cosmos-mocha to solve this. It generates tests that checks that component at least renders on fixtures data(only props supported)
    Luca Colonnello
    @LucaColonnello
    hey guys!
    I have an error on react 0.13 boilerplate
    I'm using react 0.14
    how can I integrate?
    Sergey Lapin
    @sergey-lapin
    14 not supported yet, but @skidding said that it will be soon
    Luca Colonnello
    @LucaColonnello
    ok, so by now we can't use it
    Ovidiu Cherecheș
    @skidding
    Good news, just pushed a boilerplate for 0.14! https://twitter.com/skidding/status/667128832554569729
    Josh Perez
    @goatslacker
    I found quite a lot of value in having an easy binary that just setup a project with hot loading given no configuration (or very little) are there any plans on supporting this use case or should I create one based on the latest?
    Ideally, I'd like an easy way to build an interactive playground site or let people clone a repo and have an interactive example they can easily run and play with.
    Ovidiu Cherecheș
    @skidding
    The problem with the binary was that is was very much coupled with your local webpack config, so you'd end up merging bits of your local webpack config into the Cosmos internal webpack config, without having full control over the resulting webpack config used by the playground.
    This became more difficult when Cosmos switched from react-hot-loader to babel-plugin-react-transform, because from what I could tell Babel looks for plugins under current working directory, wheres before I managed to hide dependencies inside the Cosmos package and include them via webpack's resolveLoader option: https://github.com/skidding/cosmos/blob/df29f2051a8619761101920605edfec62edad4f0/component-playground/config.js#L49-L51
    The new boilerplate comes with a "npm run playground" cmd that you can run just as easily once you have everything set up, but I'm curious what do you have in mind. Contributions are definitely appreciated! @goatslacker