Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 13 01:52
    djspiewak unassigned #2683
  • Mar 13 01:52
    djspiewak unassigned #2680
  • Mar 13 01:52
    djspiewak unassigned #2679
  • Mar 13 01:52
    djspiewak unassigned #2678
  • Mar 13 01:52
    djspiewak unassigned #2317
  • Mar 13 01:52
    djspiewak unassigned #2677
  • Mar 13 01:52
    djspiewak unassigned #2189
  • Mar 13 01:52
    djspiewak unassigned #2115
  • Mar 13 01:52
    djspiewak unassigned #2086
  • Mar 13 01:52
    djspiewak unassigned #2079
  • Mar 13 01:52
    djspiewak unassigned #2075
  • Mar 13 01:52
    djspiewak unassigned #2070
  • Mar 13 01:52
    djspiewak unassigned #2067
  • Mar 13 01:52
    djspiewak unassigned #2051
  • Mar 13 01:52
    djspiewak unassigned #2066
  • Mar 13 01:52
    djspiewak unassigned #2046
  • Mar 13 01:52
    djspiewak unassigned #2034
  • Mar 13 01:52
    djspiewak unassigned #2025
  • Mar 13 01:52
    djspiewak unassigned #2033
  • Mar 13 01:52
    djspiewak unassigned #1892
SlamData
@slamdata-user
[Gary Burgess, SlamData Inc.] oh, right yeah, the problematic case is when we get { value: { city: ..., state: ... } } instead of { city: ..., state: ... } sometimes in fact, I think
[John De Goes, SlamData Inc.] Another case: SELECT {"foo": ...} FROM .... user is confused because it's wrapped in "0"
[Gary Burgess, SlamData Inc.] is there an explicit SELECT VALUE then? I didn't know about that
[John De Goes, SlamData Inc.] Yes, it was added later and not all dialects support it. But users will never think to try such a thing with IN and sub selects
[Gary Burgess, SlamData Inc.] that's true
SlamData
@slamdata-user

[Alissa Pajer, SlamData Inc.] @garyb so I've been trying to run the markdown query

state = {!``SELECT DISTINCT(state) FROM `../patients.json` ORDER BY state`\`}

but it's giving me the error
```
The field state has the query:

SELECT DISTINCT(state) FROM ../patients.json ORDER BY state

Which failed to parse with the following error:

Expected EOF

Go back to the previous card and edit the query to fix this error.
`\
any idea what that means?

[Alissa Pajer, SlamData Inc.] where the error title is: There was a problem populating a field based on a SQL² query.
[Gary Burgess, SlamData Inc.] looks like another bug in our SQL parser
[Nathan Faubion, SlamData Inc.] @alissa have you updated recently?
[Gary Burgess, SlamData Inc.] does
SELECT DISTINCT state FROM `../patients.json` ORDER BY state
[Gary Burgess, SlamData Inc.] work?
[Alissa Pajer, SlamData Inc.] @natefaubion I am running slamdata version 4.2.6, the latest one
[Gary Burgess, SlamData Inc.] I thought distinct applied to all the projections
[Nathan Faubion, SlamData Inc.] Before I fixed the parser everything returned EOF errors
[Alissa Pajer, SlamData Inc.] I get the same error when I remove the parentheses
[Nathan Faubion, SlamData Inc.] That query will parse in the current version we have test cases like that. It's probably failing because of the relative path which means you likely aren't using the latest assets for some reason
[Gary Burgess, SlamData Inc.] hmm, it worked in a query card for me as SELECT DISTINCT state FROM `../../zips` ORDER BY state
SlamData
@slamdata-user
[Alissa Pajer, SlamData Inc.] The query works for me as a query card but not as a markdown cad.
[Nathan Faubion, SlamData Inc.] @alissa also I removed all EOF errors from the parser anyway, so you definitely are not using there latest assets somehow
[Alissa Pajer, SlamData Inc.] @natefaubion ok thanks, I'll see what happened there

[Gary Burgess, SlamData Inc.] hmm, yeah there's something odd, I just tried exactly

state = {!``SELECT DISTINCT(state) FROM `../zips` ORDER BY state``}

too, and it is showing me a dropdown with the states when I show markdown

SlamData
@slamdata-user
[Alissa Pajer, SlamData Inc.] success with the markdown query now! I had to clear my browser cache for the new SlamData to load. Thanks @garyb for the idea.
SlamData
@slamdata-user

[github]
[slamdata/slamdata] New comment by Cmdv on issue #2071: Mimir as the default mount pointing to pre-baked examples we package. (assigned to Cmdv)
@damonLL

If we bake it in regardless, do we run the risk of overwriting existing mounts with the same name, or existing Mimir mounts pointing to the same physical directory?
my exact thoughts, that's why I wondered if giving a select box option (you get this with a lot of installers asking if you want demo content installed)

I'll just try and implement above as an option along with warning message.
installing demo content may overwrite any existing local mounts or something similar =D

SlamData
@slamdata-user
[github]
[slamdata/slamdata] New comment by beckyconning on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes (assigned to beckyconning)
@garyb please review : )
SlamData
@slamdata-user
[github]
[slamdata/slamdata] New comment by garyb on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
Can we avoid this rename these? There's no need to import DOM.Event.Types as qualified when the EventType type is already imported unqualified (the line below). Just need to update it to import EventType(..) so we get the constructor too.
[github]
[slamdata/slamdata] New comment by beckyconning on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
I often find it hard to locate where a constructor has come from when more than one types constructors have been imported using (..). Would you be okay with EventType(EventType) instead?
SlamData
@slamdata-user
[github]
[slamdata/slamdata] New comment by garyb on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
EventType is a newtype and only has one constructor. Plus editors have goto definition ;). But it's up to you... we generally only use (..), partially because that's what the auto-importing/suggestions will go with too.

[github]
[slamdata/slamdata] Issue created by Cmdv
slamdata/slamdata#2128
Description

In filesystem if you add new folders in empty folder, it seems that the JS heap, nodes & listeners just continually increase. The UI becomes sluggish, but refreshing the page returns the ui to normal speed and though still a little slow reading large folder (to be expected) the rest of the filesytem is snappy :runner:

Reproduction guide

fileSystem -> mount mongo -> add empty folder -> navigate into folder and add as many folders as you see fit!!

Results

From doing a bit of profiling, I spotted that the function canonicalize from purescript-pathy has a lot of time spent in it but that is likely due to evaluation the paths.

Bellow is a screen shot of the profile and also the profile it self that can be loaded into Chrome devtools under the Performance tab =D

addingFoldersInFileSystem-profile.json.zip

screen shot 2017-08-25 at 12 13 08

SlamData
@slamdata-user

[github]
[slamdata/slamdata] New comment by beckyconning on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
There is also TraverseCard(..) TraverseDeck(..) and Milliseconds(..). Although in this case its somewhat clear from the name there is no easy way just from reading to be sure which constructor is associated with which data type.

Goto definition certainly helps but I often read source on GitHub (often on my phone) which does not yet have this feature.

I dunno maybe its not that important but to me it seems that no more than one types constructors should be imported using (..). Maybe this is somewhat similar to the idea that no more than one modules values should be imported without a list of values to import or a qualification?

SlamData
@slamdata-user
[github]
[slamdata/slamdata] New comment by garyb on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
Can we call this constTrueEventListener or alwaysTrueEventListener? Ideally we wouldn't export it at all, but then we'd have to faff around with adding an export list to this module, so nevermind!

[github]
[slamdata/slamdata] New comment by garyb on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
Hmm, looks like the auto import formatting still isn't quite right in psc-ide, since this should have moved down really!

[github]
[slamdata/slamdata] New comment by garyb on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
Sorry, I should have noticed this earlier, but the whole EventType import conversation could have been avoided, as this is already provided by purescript-dom. It's EventTypes.beforeunload (EventTypes is already in scope in this module).

[github]
[slamdata/slamdata] New comment by garyb on pull request #2030: Pivot table leaf value formatting (assigned to garyb)
Looks like this is another casualty of making the repo private, this is no longer connected to my branch.
[github]
[slamdata/slamdata] Pull request closed: slamdata/slamdata#2030 by garyb
SlamData
@slamdata-user
[github]
[slamdata/slamdata] New comment by beckyconning on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
Should have or should not have?

[github]
[slamdata/slamdata] New comment by garyb on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
The reason that was introduced is not to aid discoverability, although it's a happy consequence of that restriction. It's to ensure adding members to libraries does not break things that depend on it downstream. The same thing doesn't apply to constructors, since changing the constructors of a type is a breaking change anyway.

I get where you're coming from, I just prefer to do as little as possible when it comes to managing imports, since they're there as a necessary evil, not something that I really want to think much about when solving problems.

[github]
[slamdata/slamdata] New comment by garyb on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
Should not have - open imports are meant to stay at the top, and a hiding (blah) is still an open import.
[github]
[slamdata/slamdata] New comment by garyb on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes
We can drop the (..) now =D
[github]
[slamdata/slamdata] Pull request submitted by garyb
slamdata/slamdata#2129
Will resolve #1882
SlamData
@slamdata-user
[github]
[slamdata/slamdata] New comment by beckyconning on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes (assigned to beckyconning)
@garyb all good? : )
SlamData
@slamdata-user
[github]
[slamdata/slamdata] New comment by garyb on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes (assigned to beckyconning)
I think we should do enableOnBeforeUnloadConfirmation in saveWorkspace also, and then trigger disableOnBeforeUnloadConfirmation at the end of the save, removing it from queueSave. There are places where saveWorkspace is called directly, so we'd this behaviour for those as well as the debounced version.
SlamData
@slamdata-user
[github]
[slamdata/slamdata] New comment by beckyconning on pull request #2125: Added are you sure you want to leave this page dialog while unsaved changes (assigned to beckyconning)
Oops missed a spot!
SlamData
@slamdata-user
[github]
[slamdata/slamdata] Issue created by garyb
slamdata/slamdata#2130
We either need to add a cancel button or have it so that when re-selecting the visualisation that is currently chosen it doesn't reset the options for it.
SlamData
@slamdata-user
[github]
[slamdata/slamdata] Pull request submitted by garyb
slamdata/slamdata#2131
The indicator currently be all insane on Windows (or on a Mac if you have scrollbars visible)
SlamData
@slamdata-user
[github]
[slamdata:master] 2 new commits by Gary Burgess:
`slamdata/slamdata@5b60947Fix indicator overflow - Gary Burgessslamdata/slamdata@c3cfd54` Merge pull request #2131 from garyb/indicator-overflow - Gary Burgess
[github]
[slamdata/slamdata] Pull request closed: slamdata/slamdata#2131 by garyb
SlamData
@slamdata-user
[github]
[slamdata/slamdata] New comment by natefaubion on issue #2128: Filesystem potential memory leak
What happens when you explicitly run a GC during profiling (the trashcan item at the top)? I tried profiling (in chrome) both spork and halogen in a minimal test for adding and removing elements. They both seem to balloon a little bit on elements and event listeners, but with an explicit GC, everything is collected appropriately (so I think chrome is just taking longer to GC nodes and handlers), which means there isn't a fundamental leak in the DOM diffing stuff.
[github]
[slamdata/slamdata] New comment by natefaubion on issue #2128: Filesystem potential memory leak
The JS Heap size is concerning, because I didn't see that balloon in my test.
[github]
[slamdata/slamdata] New comment by natefaubion on issue #2128: Filesystem potential memory leak
In your report, you say that it increases as you add folders? That's expected isn't it? You are adding more nodes and handlers.
SlamData
@slamdata-user

[github]
[slamdata/slamdata] New comment by safareli on issue #1481: Add charts color editing / chart color palette picker (assigned to safareli, cryogenian)
While I was flying with no internet I have fetched some materials and implemented cubehelix schema. in this scheme brightness is perceived as increasing which is what we want for sequential schemes and gives great results. here is an one example https://bl.ocks.org/mbostock/11415064
Will open PR on this issue sharkdp/purescript-colors#30)

Meanwhile this is that I got:

<img width="433" alt="screen shot 2017-08-25 at 8 34 06 pm" src="https://user-images.githubusercontent.com/1932383/29727565-c2a20af8-89d4-11e7-9ef8-c31e58cef6c6.png">
<img width="443" alt="screen shot 2017-08-25 at 8 33 57 pm" src="https://user-images.githubusercontent.com/1932383/29727568-c43d674a-89d4-11e7-9238-8b5d3d12016f.png">
<img width="430" alt="screen shot 2017-08-25 at 8 33 43 pm" src="https://user-images.githubusercontent.com/1932383/29727572-c747aaa4-89d4-11e7-860a-2f81bb9bdd84.png">
<img width="444" alt="screen shot 2017-08-25 at 8 34 42 pm" src="https://user-images.githubusercontent.com/1932383/29727586-d8e12786-89d4-11e7-98ea-c8c9df7e10e9.png">

This is great result as even for 20 stops, brightness difference is still perceived!

SlamData
@slamdata-user

[github]
[slamdata/slamdata] Pull request submitted by Cmdv
slamdata/slamdata#2132
Directories with large amount of folders can take time to become visible.
Added a spinner as shown bellow: :point_down:

2017-08-25 17 36 51

this fixes #1830