Howdy - opened this a few days ago : Theodo-UK/sls-dev-tools#96 - anything else required to get it merged?
Also when I ran yarn lint it threw out a fair number of warnings - is that expected? Should that be clean?
As for the yarn lint it's something we are aware of and planning to fix all the warnings this week and get CI checks in place for this
No problem - happy to have a go at making it better/follow on with the changes to add a UI element like the event bridge event injection.
For CI either github actions or Circle CI was the plan
Raised this Theodo-UK/sls-dev-tools#118 - should introduce a modal for lambda invoke along the same lines as event bridge injection
Although I realised I didn't update the help modal or docs to indicate you can inject a payload with the lambda function as well.
Theodo-UK/sls-dev-tools#191 - I had a look at this last night and when mfa is enabled you need to have a way for the person to enter the MFA token. This is done by adding a function to the params for SharedIniFileCredentials. How would we want that to work? Need to bring up a blocking modal within this callback to enter the MFA token before letting the app try and initialise as it will just fail. I have recreated it so don't mind having a go at fixing it.
@jnmullen It would be amazing if you could have a go a fixing it! A blocking modal makes sense on startup if it needs an MFA token. The region wizard is a modal that is blocking so possibly looking at something like that to have as a blocking modal? I think the modal will just need to contain a single form field an a submit button
@DotGav quick one - what marks the region wizard as being a blocking modal? I think I've got something which will work but I am struggling for my modal to be blocking. My new modal shows up then the app continues to load over the top of it. Slightly different thing is the modal is being trigger by a function call from the AWS SDK in relation to your config containing mfa_serial within the profile.
Hey @jnmullen , the blocking modals are all created here in the code before the Main() object is created, to avoid it being initialised without the necessary parameters. That's probably the easiest place to add another conditional blocking modal
Raised this PR Theodo-UK/sls-dev-tools#210 to add a mfa token modal. Happy to hear feedback on it - did struggle a bit with the AWS SDK and the callback loading the modal but it appears to work.
Was thinking of having a look at Theodo-UK/sls-dev-tools#42 - any thoughts on where that info should be displayed? Quiet a lot of info already being shown about a lambda in the lambda table. How about a separate right button to view layer info - like the "All Resources"
@jnmullen I was thinking this would be another column on the functions table but you're right - there is not much space. I think we should ensure the tool should be usable at full width on a 13" machine. As you suggest another -> like the all resources seems a good solution if not enough space and we can add it to the "l" stats modal which needs a layout redesign in my opinion anyway.
Raised this PR Theodo-UK/sls-dev-tools#230 which adds some displaying of lambda layers (Y/N) on the lambda table and then a further table on the lambda statistics modal.