Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    James Mullen
    @jnmullen

    Howdy - opened this a few days ago : Theodo-UK/sls-dev-tools#96 - anything else required to get it merged?

    Also when I ran yarn lint it threw out a fair number of warnings - is that expected? Should that be clean?

    Gavin Williams
    @DotGav
    Hey James, sorry about not getting back to you sooner on the PR! Yeah I've taken a look at it and it seems to work well! Thank you so much for doing this :)
    As for the yarn lint it's something we are aware of and planning to fix all the warnings this week and get CI checks in place for this
    James Mullen
    @jnmullen
    OK cool I was going to ask about CI type checks/tests would be good for that stuff.
    No problem - happy to have a go at making it better/follow on with the changes to add a UI element like the event bridge event injection.
    Gavin Williams
    @DotGav
    Yes something we definitely want to have is CI in the next few days!
    James Mullen
    @jnmullen
    What are using for CI? Github actions?
    Gavin Williams
    @DotGav
    Yeah that would be great it was our plan for the invocations to work similar to the event injection, if you want to have a go at it that would be great! More than happy to help with that in ay way as well :)
    For CI either github actions or Circle CI was the plan
    James Mullen
    @jnmullen
    Raised this Theodo-UK/sls-dev-tools#118 - should introduce a modal for lambda invoke along the same lines as event bridge injection
    Gavin Williams
    @DotGav
    Great I'll take a look
    James Mullen
    @jnmullen
    :+1:
    Gavin Williams
    @DotGav
    @jnmullen Amazing work again! Merged with only a small linting tweak! Thank you so much for contributing :)
    James Mullen
    @jnmullen
    Cool no problem - was pretty simple taking all the inspiration from the event injection modal
    Although I realised I didn't update the help modal or docs to indicate you can inject a payload with the lambda function as well.
    Gavin Williams
    @DotGav
    Thats a very good point! I'll edit the help wording and the docs for this
    James Mullen
    @jnmullen
    OK great
    James Mullen
    @jnmullen
    Theodo-UK/sls-dev-tools#191 - I had a look at this last night and when mfa is enabled you need to have a way for the person to enter the MFA token. This is done by adding a function to the params for SharedIniFileCredentials. How would we want that to work? Need to bring up a blocking modal within this callback to enter the MFA token before letting the app try and initialise as it will just fail. I have recreated it so don't mind having a go at fixing it.
    Gavin Williams
    @DotGav
    @jnmullen It would be amazing if you could have a go a fixing it! A blocking modal makes sense on startup if it needs an MFA token. The region wizard is a modal that is blocking so possibly looking at something like that to have as a blocking modal? I think the modal will just need to contain a single form field an a submit button
    James Mullen
    @jnmullen
    OK cool will have a look at that modal - yeah I was thinking the same one field and submit button
    Gavin Williams
    @DotGav
    @jnmullen Great! Thank you so much!
    James Mullen
    @jnmullen
    @DotGav quick one - what marks the region wizard as being a blocking modal? I think I've got something which will work but I am struggling for my modal to be blocking. My new modal shows up then the app continues to load over the top of it. Slightly different thing is the modal is being trigger by a function call from the AWS SDK in relation to your config containing mfa_serial within the profile.
    Gavin Williams
    @DotGav
    @mansurpasha will probably be able to answer that better as he wrote the modal so the rest of the screen did not display
    mansurpasha
    @mansurpasha
    Hey @jnmullen , the blocking modals are all created here in the code before the Main() object is created, to avoid it being initialised without the necessary parameters. That's probably the easiest place to add another conditional blocking modal
    James Mullen
    @jnmullen
    ok so just the calling of Main.render() is where the app is then started. I think I am struggling with callbacks and async stuff which is causing the app to continue and run Main.render() anyway. Will continue to have a look at that area.
    mansurpasha
    @mansurpasha
    Sounds good! Also, will be more than happy to answer any questions you have about async programming when using the the AWS SDK
    James Mullen
    @jnmullen
    Raised this PR Theodo-UK/sls-dev-tools#210 to add a mfa token modal. Happy to hear feedback on it - did struggle a bit with the AWS SDK and the callback loading the modal but it appears to work.
    mansurpasha
    @mansurpasha
    @jnmullen Really great work! Merged and soon to be released, thanks so much again!
    James Mullen
    @jnmullen
    @mansurpasha cool thanks
    James Mullen
    @jnmullen
    Was thinking of having a look at Theodo-UK/sls-dev-tools#42 - any thoughts on where that info should be displayed? Quiet a lot of info already being shown about a lambda in the lambda table. How about a separate right button to view layer info - like the "All Resources"
    Ben Ellerby
    @BenEllerby
    @jnmullen I was thinking this would be another column on the functions table but you're right - there is not much space. I think we should ensure the tool should be usable at full width on a 13" machine. As you suggest another -> like the all resources seems a good solution if not enough space and we can add it to the "l" stats modal which needs a layout redesign in my opinion anyway.
    James Mullen
    @jnmullen
    Will have a play about then. I think you can have five layers so that could be a fair chunk of info to view in the table - but adding it into the stats modal sounds good as well.
    Ben Ellerby
    @BenEllerby
    Maybe an indication layers are there in the table and the list in the modal?
    James Mullen
    @jnmullen
    :thumbsup: that sounds like a good combination - will have a look
    Ben Ellerby
    @BenEllerby
    Awesome - we're here if you need any help/feedback :)
    James Mullen
    @jnmullen
    Raised this PR Theodo-UK/sls-dev-tools#230 which adds some displaying of lambda layers (Y/N) on the lambda table and then a further table on the lambda statistics modal.
    Gavin Williams
    @DotGav
    @jnmullen Amazing, I will review this morning!
    Gavin Williams
    @DotGav
    @jnmullen Thank you again! Works perfectly for showing the lambda layers!
    James Mullen
    @jnmullen
    @DotGav no worries.