Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    David M. Lloyd
    @dmlloyd
    also: is there a good process for requesting/coordinating releases?
    Ken Finnigan
    @kenfinnigan
    @dmlloyd Sure, will trigger one now
    A bunch of people have access to Semaphore to trigger a release
    I can add you if you have an account
    David M. Lloyd
    @dmlloyd
    I don't but I can add it to my todo list
    Ken Finnigan
    @kenfinnigan
    though I did just realize that parent is still released from a script in the repo, oops
    need to setup CI for the release
    Derek P. Moore
    @derekm
    What is GraphQL introspecting? Services and objects? It just exposes all classes and public methods?
    Phillip Krüger
    @phillip-kruger
    Ability to introspect all queries, mutations, types and scalars.
    Derek P. Moore
    @derekm
    so it is tied more to JPA?
    Phillip Krüger
    @phillip-kruger
    Nope. Not at all.
    Can we used with JPA if you want to
    Derek P. Moore
    @derekm
    it exposes classes that have public methods?
    Phillip Krüger
    @phillip-kruger
    No it expose the GraphQL Schema.
    The Schema is build (in our case) from classes and methods
    Derek P. Moore
    @derekm
    one blacklists internals that aren't part of the public API surface area?
    is SmallRye GraphQL meant to allow the service to be discovered and utilized by a central GraphQL server? or does it turn the service into a GraphQL server itself?
    Phillip Krüger
    @phillip-kruger
    Second one. It will work like JAX-RS
    You are building a GraphQL Server
    or Services
    So you can annotate a method with @Query and that will become a GraphQL Query. Same for @Mutation
    Derek P. Moore
    @derekm
    ah, I see, very cool
    so I'm left to use a traditional GraphQL server to span across microservices that use SmallRye GraphQL?
    Phillip Krüger
    @phillip-kruger
    Yes. Or you can code another service that does that.
    Not sure if API gateways support GraphQL
    Derek P. Moore
    @derekm
    Btw, here's the module in Swagger that scans for JAX-RS annotations: https://github.com/swagger-api/swagger-core/tree/master/modules/swagger-jaxrs2/src/main/java/io/swagger/v3/jaxrs2
    Ken Finnigan
    @kenfinnigan
    @dmlloyd https://repo1.maven.org/maven2/io/smallrye/smallrye-parent/13/
    Derek P. Moore
    @derekm
    it would be cool if SmallRye GraphQL could span over my pre-existing Swagger-/OpenAPI-enabled microservices
    Phillip Krüger
    @phillip-kruger
    You will have to build that. Would not be difficult, basically MP RestClient and then MP GraphQL Queries that facade that.
    David M. Lloyd
    @dmlloyd
    thanks @kenfinnigan
    Derek P. Moore
    @derekm
    CDI isn't great at efficiently scanning method-level annotations. If you can require a class-level annotation, like JAX-RS does (any JAX-RS app requires at least one class-level @Path annotation), then things can become much simpler. E.g., https://github.com/hammock-project/hammock/blob/56904f888d74176c32940dc9c8426cd32c5a6a06/rest-jersey/src/main/java/ws/ament/hammock/rest/jersey/JerseyCdiExtension.java
    re: MP Rest Client + MP GraphQL Queries -- I put all my JAX-RS annotations on interfaces so that my server-side endpoint implementations and my client-side proxy clients can use the same behavior/protocol definitions -- might be cool if I could just add the thinnest layer of GraphQL annotations to those same interfaces
    David M. Lloyd
    @dmlloyd
    ah look at all those dependabot PRs for smallrye-parent
    wait till they fail because none of those projects use the JBoss repository...
    David M. Lloyd
    @dmlloyd
    was just going to ask about a smallrye-parent tag
    thanks @kenfinnigan !
    Ken Finnigan
    @kenfinnigan
    No problem!
    David M. Lloyd
    @dmlloyd
    I notice that dependabot hasn't picked up on the SRConfig 1.5 changes
    probably due to the relocations
    we might have to go through and open issues on the various SR projects to manually set the version and change the group ID
    Ken Finnigan
    @kenfinnigan
    yeah, was just doing some PR cleanup and noticed the same
    will try and work through them this week
    David M. Lloyd
    @dmlloyd
    for Quarkus I ended up adding a fixed dependency on 1.5.0 for the old group ID to force the relocation to be used - this prevents Maven from pulling in two conflicting versions (in case some dependency uses 1.4.x or something)
    Ken Finnigan
    @kenfinnigan
    how do you fix a dependency? version range?
    David M. Lloyd
    @dmlloyd
    just hard code the version to 1.5.0 in the project parent POM dependencyManagement section
    for the old group ID only
    Ken Finnigan
    @kenfinnigan
    ah
    David M. Lloyd
    @dmlloyd
    then if any transitive dep uses the old group ID, it'll be relocated to the new group ID
    I deliberately didn't use a property for it in Quarkus, and added a big comment, specifically to prevent helpful people from "fixing" it :)
    ("helpful people" possibly including the future me who forgot all about this hackery)