smeijer/leaflet-geosearch

geosearching / geocoding control

Daniel Smullen

@drspangle

and as a result i can use the objects exported by them

Stephan Meijer

@smeijer

okay, I understand.

a quick fix, would be to handle leaflet-geosearch the same as you handle jquery.

node-modules/leaflet-geosearch/dist/bundle.js

Than there must be a global GeoSearch, the OSM provider should be under GeoSearch.OpenStreetMapProvider

Daniel Smullen

@drspangle

i attempted that, let me see if i needed to qualify it with GeoSearch.*

one moment

Stephan Meijer

@smeijer

A map would than be loaded with:

var searchControl = new GeoSearch.GeoSearchControl({
  provider: new GeoSearch.OpenStreetMapProvider(),
});

var map = new L.Map('map');
map.addControl(searchControl);

Daniel Smullen

@drspangle

let's see if this works...

nope, GeoSearch is undefined

so it seems i am not able to get the top level object from your library, at all

Stephan Meijer

@smeijer

Is it possible that that because it's not in your public dir?

Daniel Smullen

@drspangle

that is a possibility, which i will look into, but i'm not totally sure how to determine that

the reason why it is in the npm managed node-modules folder is because i could not get the dist/ folder when using bower to install

of course i can copy it manually, but in order to maintain the installation process for the app in general, i must find some way to get the dist/ folder contents through bower, since that would be the idea behind providing a module through bower

in fact the idea behind distributing the module that way, i believe, would be to decouple the module from the build process' itself's dependencies

Stephan Meijer

@smeijer

yes, I understand of course. Just curious if that can be the reason.

Is it possible to refer external (cdn hosted for example), libraries?

Daniel Smullen

@drspangle

it is a very reasonable suggestion

to answer the cdn question, i am not sure, but maybe it is possible since i think i've done that in the line where i get material icons

but i am not sure how desirable this is

this means that my configuration file must have a static binding to that URL, so if it changes i have to update everything, whereas using bower's manifest i can automatically insert these dependencies since their path is predictable based on my bower config file

the leaflet bower package, for example, already has a dist/ folder

Stephan Meijer

@smeijer

Sorry, I have a phone call. Be right back.

Daniel Smullen

@drspangle

sure

Daniel Smullen

@drspangle

i believe your bower.json might be fixed by replacing the line

"main": "src/js/l.control.geosearch.js",

with

"main": "dist/bundle.js",

and then committing the dist/ folder inside the git repository

then $ bower install leaflet-geosearch will work out of the box

also, to answer the CDN question, it is not possible - the purpose of bower is to also manage your module's dependencies as well, so that it can be linked to them after downloading them once, rather than managing a separate version for each module

for example, if you depend on angularJS, bower will ensure that it is downloaded once, and then all other bower-installed modules which depend on it will link to it, rather than managing it's own copy

you must define these dependencies in the bower.json file

and you can control what version you depend on as well

Stephan Meijer

@smeijer

Okay; makes sense. Although I do not understand why that fixes your problem. Why can you than refer to the globals, and not when you point directly to the bundle.js. It's strange for me.

Daniel Smullen

@drspangle

it's strange for me as well, i don't have a good explanation for why i can't use bundle.js as it is

Stephan Meijer

@smeijer

I must think about this. I'm not really in favor of committing build files to a git repo. Especially since bower is already advising to start using yarn in favor of bower.

Daniel Smullen

@drspangle

indeed

it is an important decision, the issue revolves around supporting bower, which is still supported

webpack and yarn and the like are suggested for new projects

Stephan Meijer

@smeijer

true

Daniel Smullen

@drspangle

but unfortunately my project still depends on bower for building

Stephan Meijer

@smeijer

and when installing trough bower, you can specify a git branch or something?

Daniel Smullen

@drspangle

i'm not sure about that, i think you must specify a git endpoint, and you use tags to specify the version/branch

so you could use the tags to specify a particular version, but you could also use it to specify a particular branch for releases that support bower

or both of course

i.e. v2.0.0-bower

Stephan Meijer

@smeijer

what would be the command to install a particular release?

Daniel Smullen

@drspangle

you wouldn't do that from the command line - you would just do bower install leaflet-geosearch --save to automatically add the dependency, but it would download the latest version that's defined in the bower package you registered

what i would do if i wanted a specific version would be to add a dependency on that particular version in my own bower.json file, and then when i run bower install it would automatically download that one only

i believe that the tags you use on github are the way you manage the versioning directly

the semantic versioning spec is what is used, in fact the version string in the bower.json file in your package is not used

by versioning spec i mean, this is what you must use when you define your tags on the git

Where communities thrive

People

Repo info

Activity