Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 13 2020 18:05
    adamw commented #64
  • Jan 13 2020 17:23
    agilesteel commented #64
  • Jul 10 2019 11:04
    lrytz opened #65
  • Jun 28 2019 13:37
    adamw commented #64
  • Jun 27 2019 22:50
    bjchambers opened #64
  • Mar 14 2019 17:25

    kciesielski on 0.6.1

    (compare)

  • Mar 14 2019 16:55

    kciesielski on master

    Update sbt to 0.13.7 Add a predefined constant for n… (compare)

  • Mar 14 2019 13:23
    nonsleepr opened #63
  • Mar 13 2019 13:34
    nonsleepr commented #49
  • Mar 12 2019 14:53

    kciesielski on master

    Fix fatal warnings example (compare)

  • Feb 20 2019 09:59
    adamw commented #30
  • Feb 20 2019 01:58
    nafg commented #30
  • Jan 31 2019 08:09

    kciesielski on master

    Adjust tests (compare)

  • Jan 31 2019 07:51

    kciesielski on v0.6.0

    (compare)

  • Jan 31 2019 07:49

    kciesielski on master

    Support fatal warnings Update version to 0.6.0 Allow defining fatal warnings w… and 1 more (compare)

  • Dec 14 2018 07:22
    adamw commented #62
  • Dec 14 2018 02:40
    acruise opened #62
  • Sep 23 2018 17:36
    quasi-coherent commented #57
  • May 11 2018 11:17
    adamw commented #57
  • May 10 2018 06:56
    michelemauro commented #57
Shane Delmore
@ShaneDelmore
Yeah, definitely order based. I have test a and b, each passes on their own. When run together the a passes and b fails. If I re-order them b passes and a fails. First test passes, then all others fail.
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore I think I know what might be the problem
@ShaneDelmore as a workaround, can you make a new toolbox for each test? Because I suppose you have a single one for all of them?
Shane Delmore
@ShaneDelmore
Yes.
Krzysiek Ciesielski
@kciesielski
hmm wait, we use a single toolbox for all tests too
but I noticed another difference
I switched to toolbox.compile instead of toolbox.eval
Only for better readability, but maybe it’s actually important
(having a separate toolbox for each tests is also worth trying if this won’t help)
Shane Delmore
@ShaneDelmore
For better readability of the error messages? Or were you thinking compile and eval did the same thing but preferred the word compile?
Krzysiek Ciesielski
@kciesielski
I saw it some other example and I tried it out, turned out it did compilation and I thought I’ll leave compile for better readability of code
I wanted to check out what’s the actual difference but forgot about it
I can see now that eval additionally "runs the tree"
skipping this may be relevant then
Shane Delmore
@ShaneDelmore
compile vs eval made no difference, but making a new toolbox each test did fix it, although at the cost of much slower tests. I don't have a ton so this is workable.
Krzysiek Ciesielski
@kciesielski
I think I have a possible fix
I’ll post an update here if it works (or not)
Shane Delmore
@ShaneDelmore
Great, appreciate the ideas.
Krzysiek Ciesielski
@kciesielski
Thans for being a “power user”, testing my dirty hacks :D
And sorry for the turbulences ;)
Shane Delmore
@ShaneDelmore
This is all very interesting to me as the next thing I want to do myself is learn how to write a compiler plugin.
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore I just published 0.4.1-SNAPSHOT, can you check if it deals well with the problem we overcame with a single toolbox?
Shane Delmore
@ShaneDelmore
Sure. I just published 0.4.1-SNAPSHOT locally to overcome the SSL error :D
If I remove my local will the snapshot be found, or do I need to build your branch locally?
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore good question, I am not sure TBH. Let me quickly build 0.4.2-SNAPSHOT so we are 100% sure which one is used
Shane Delmore
@ShaneDelmore
Thanks.
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore done, both plugin and pluginSbt 0.4.2-SNAPSHOT published
Shane Delmore
@ShaneDelmore
Great, I'll get back to you in 10 minutes with results.
Shane Delmore
@ShaneDelmore
I can't find 0.4.2-SNAPSHOT. I think those might be local only.
If you push your branch I can pull it local and build it.
Shane Delmore
@ShaneDelmore
I probably do not have them added if it is a manual step. Let me try it now.
Krzysiek Ciesielski
@kciesielski
Yes, it requires adding
resolvers += 
  "Sonatype OSS Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots”
I need to run now, I’ll check back in the morning (It’s 1:20 AM CET now :)
Shane Delmore
@ShaneDelmore
Thanks.
Shane Delmore
@ShaneDelmore
@kciesielski I was unable to run my tests with your snapshot due to the SSL error I have been receiving but if you can stack your changes onto my branch which allows proceeding even if the central server is unreachable then I can test again tomorrow. softwaremill/scala-clippy#37
Shane Delmore
@ShaneDelmore
@kciesielski Thanks for the review, redundant docs removed.
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore I merged your PR, thanks a lot for this contribution.
Could you check whether 0.4.2-SNAPSHOT fixes the issue with requiring re-creating of toolbox?
Shane Delmore
@ShaneDelmore
I checked yesterday and it didn't build due to the SSL errors. Have you published a new snapshot on top of my changes?
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore published just now
0.4.2-SNAPSHOT
Shane Delmore
@ShaneDelmore
@kciesielski Success!
Krzysiek Ciesielski
@kciesielski
:sparkles:
Otto Chrons
@ochrons
I don't think the colors work as intended here:
blob
Shane Delmore
@ShaneDelmore
Highlighting error messages correctly is tricky. I worked on error messages in Dotty a bit and Felix Mulder put together a really nice framework for highlighting messages there. Depending on interest we might try to backport that to clippy.
Shane Delmore
@ShaneDelmore
I found this issue related to Path, unless there is objection I will just make a pr and file it away under this issue. http4s/http4s#559
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore Sounds very interesting with the dotty highlighter. Are you sure the http4s path issue relates to Clippy?
@ochrons Are you using windows? Because this looks like softwaremill/scala-clippy#40