Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 13 2020 18:05
    adamw commented #64
  • Jan 13 2020 17:23
    agilesteel commented #64
  • Jul 10 2019 11:04
    lrytz opened #65
  • Jun 28 2019 13:37
    adamw commented #64
  • Jun 27 2019 22:50
    bjchambers opened #64
  • Mar 14 2019 17:25

    kciesielski on 0.6.1

    (compare)

  • Mar 14 2019 16:55

    kciesielski on master

    Update sbt to 0.13.7 Add a predefined constant for n… (compare)

  • Mar 14 2019 13:23
    nonsleepr opened #63
  • Mar 13 2019 13:34
    nonsleepr commented #49
  • Mar 12 2019 14:53

    kciesielski on master

    Fix fatal warnings example (compare)

  • Feb 20 2019 09:59
    adamw commented #30
  • Feb 20 2019 01:58
    nafg commented #30
  • Jan 31 2019 08:09

    kciesielski on master

    Adjust tests (compare)

  • Jan 31 2019 07:51

    kciesielski on v0.6.0

    (compare)

  • Jan 31 2019 07:49

    kciesielski on master

    Support fatal warnings Update version to 0.6.0 Allow defining fatal warnings w… and 1 more (compare)

  • Dec 14 2018 07:22
    adamw commented #62
  • Dec 14 2018 02:40
    acruise opened #62
  • Sep 23 2018 17:36
    quasi-coherent commented #57
  • May 11 2018 11:17
    adamw commented #57
  • May 10 2018 06:56
    michelemauro commented #57
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore done, both plugin and pluginSbt 0.4.2-SNAPSHOT published
Shane Delmore
@ShaneDelmore
Great, I'll get back to you in 10 minutes with results.
Shane Delmore
@ShaneDelmore
I can't find 0.4.2-SNAPSHOT. I think those might be local only.
If you push your branch I can pull it local and build it.
Shane Delmore
@ShaneDelmore
I probably do not have them added if it is a manual step. Let me try it now.
Krzysiek Ciesielski
@kciesielski
Yes, it requires adding
resolvers += 
  "Sonatype OSS Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots”
I need to run now, I’ll check back in the morning (It’s 1:20 AM CET now :)
Shane Delmore
@ShaneDelmore
Thanks.
Shane Delmore
@ShaneDelmore
@kciesielski I was unable to run my tests with your snapshot due to the SSL error I have been receiving but if you can stack your changes onto my branch which allows proceeding even if the central server is unreachable then I can test again tomorrow. softwaremill/scala-clippy#37
Shane Delmore
@ShaneDelmore
@kciesielski Thanks for the review, redundant docs removed.
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore I merged your PR, thanks a lot for this contribution.
Could you check whether 0.4.2-SNAPSHOT fixes the issue with requiring re-creating of toolbox?
Shane Delmore
@ShaneDelmore
I checked yesterday and it didn't build due to the SSL errors. Have you published a new snapshot on top of my changes?
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore published just now
0.4.2-SNAPSHOT
Shane Delmore
@ShaneDelmore
@kciesielski Success!
Krzysiek Ciesielski
@kciesielski
:sparkles:
Otto Chrons
@ochrons
I don't think the colors work as intended here:
blob
Shane Delmore
@ShaneDelmore
Highlighting error messages correctly is tricky. I worked on error messages in Dotty a bit and Felix Mulder put together a really nice framework for highlighting messages there. Depending on interest we might try to backport that to clippy.
Shane Delmore
@ShaneDelmore
I found this issue related to Path, unless there is objection I will just make a pr and file it away under this issue. http4s/http4s#559
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore Sounds very interesting with the dotty highlighter. Are you sure the http4s path issue relates to Clippy?
@ochrons Are you using windows? Because this looks like softwaremill/scala-clippy#40
Otto Chrons
@ochrons
yeah
Krzysiek Ciesielski
@kciesielski
We are going to add support for custom Ansi RESET color, so windows users can set it to light-grey or whatever. For some reason it doesn't work well on Windows (when used with Li Haoyi's fansi lib)
Otto Chrons
@ochrons
Win10 and mingw bash under ConEmu terminal
Krzysiek Ciesielski
@kciesielski
@ochrons you can use clippy 0.5.1-SNAPSHOT as a workaround for now (described in issue). We'll soon add the mentioned option as a proper fix.
Otto Chrons
@ochrons
ok, will try at some point :)
Shane Delmore
@ShaneDelmore
@kciesielski User error, that was meant for the https room
@kciesielski not at all related to clippy.
Greg Pfeil
@sellout
So, is there a way I can conditionally disable clippy for certain projects via my ~/…/global.sbt? Like if (sbt.project == "scala") scalacOptions += "-P:clippy:enable=false"?
Shane Delmore
@ShaneDelmore
I'm getting the following error again. Anyone else? Information:scalac: Unable to load/store local Clippy advice due to: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
Shane Delmore
@ShaneDelmore
The error cleared up. I have no idea why. Weird.
prateekmane99
@prateekmane99
I have added addCompilerPlugin("com.softwaremill.clippy" %% "plugin" % "0.5.2" classifier "bundle") in my sbt
I cant see Clippy errors in my console
Shane Delmore
@ShaneDelmore
What error are you using to test?
Oron Port
@soronpo
Does clippy replace scalac errors or just adds information?
Adam Warski
@adamw
@soronpo only adds information. The original error is always there
Oron Port
@soronpo
What do you think of adding an optional flag that sets if we want the original error message to replaced?
Adam Warski
@adamw
@soronpo well, what would be the use-case? :)
Oron Port
@soronpo
I'm creating a DSL and
some of its users will be less confused that way
Adam Warski
@adamw
well there are mechanisms like @implicitNotFound for customizing error messages. I'd be cautious in replacing the original error message entirely, I suppose we would need to have a good motivating example to include that
Oron Port
@soronpo
@adamw On one hand, @implicitNotFound is very limited, and on the other hand, the missing implicit messages for my library are too verbose. This is not a must feature, but if a library owner has an optional flag for that, I do not see the harm.
Crucial feature that I am currently missing is the ability to grab text from the original message and place it in the new/hint message.
chris vale
@crispywalrus

I’ve started seeing this

21:06:25.829 DEBUG akka://ENSIME/user/ensime-main/tcp-server/con1/3 o.e.s.RequestHandler - received handled message SymbolDesignations(RawFile(.),List()) from Actor[akka://ENSIME/user/ensime-main/project/scalac#1727592554] in state receive
java.lang.ClassCastException: com.softwaremill.clippy.InjectReporteranonanon1 cannot be cast to scala.tools.nsc.Global$GlobalPhase
at scala.tools.nsc.Global$Run.$anonfun$compileLate$3(Global.scala:1519)
at scala.tools.nsc.Global$Run.$anonfun$compileLate$2(Global.scala:1519)
at scala.tools.nsc.Global$Run.$anonfun$compileLate$2$adapted(Global.scala:1518)
at scala.tools.nsc.Global$Run$$Lambda$1471/168254663.apply(Unknown Source)
at scala.collection.Iterator.foreach(Iterator.scala:929)
at scala.collection.Iterator.foreach$(Iterator.scala:929)
at scala.collection.AbstractIterator.foreach(Iterator.scala:1406)
at scala.tools.nsc.Global$Run.compileLate(Global.scala:1518)
at scala.tools.nsc.interactive.Global.parseAndEnter(Global.scala:645)
at scala.tools.nsc.interactive.Global.$anonfun$backgroundCompile$4(Global.scala:554)
at scala.tools.nsc.interactive.Global.$anonfun$backgroundCompile$3(Global.scala:551)
at scala.tools.nsc.interactive.Global.backgroundCompile(Global.scala:551)
at scala.tools.nsc.interactive.PresentationCompilerThread.run(PresentationCompilerThread.scala:25)

interaction between clippy (or so it appear) and ensime. Commenting out clippy (which I’ve been loading via my global sbt plugins) resolves the issue but at quite a loss.

Shane Delmore
@ShaneDelmore
Does the issue happen with 0.5.2?
I don't use ensime but added a feature in 0.5.3 and am worried there might be a conflict.
Although I don't know anything about how the reporter is injected, that was another contributor who worked on that but I do remember it changing a few releases back when the nice coloring was added.